Clippy fixes (#1181)

Author: LegNeato

juniper/src/executor/mod.rs

@@ -112,11 +112,7 @@ where
     Self: PartialEq,
 {
     fn partial_cmp(&self, other: &ExecutionError<S>) -> Option<Ordering> {
-        (&self.location, &self.path, &self.error.message).partial_cmp(&(
-            &other.location,
-            &other.path,
-            &other.error.message,
-        ))
+        Some(self.cmp(other))
     }
 }
 

juniper/src/executor_tests/directives.rs

@@ -21,7 +21,7 @@ impl TestType {
 
 async fn run_variable_query<F>(query: &str, vars: Variables<DefaultScalarValue>, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     let schema = RootNode::new(
         TestType,
@@ -44,7 +44,7 @@ where
 
 async fn run_query<F>(query: &str, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     run_variable_query(query, Variables::new(), f).await;
 }

juniper/src/executor_tests/enums.rs

@@ -32,7 +32,7 @@ impl TestType {
 
 async fn run_variable_query<F>(query: &str, vars: Variables<DefaultScalarValue>, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     let schema = RootNode::new(
         TestType,
@@ -55,7 +55,7 @@ where
 
 async fn run_query<F>(query: &str, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     run_variable_query(query, Variables::new(), f).await;
 }

juniper/src/executor_tests/introspection/enums.rs

@@ -89,7 +89,7 @@ impl Root {
 
 async fn run_type_info_query<F>(doc: &str, f: F)
 where
-    F: Fn((&Object<DefaultScalarValue>, &Vec<Value<DefaultScalarValue>>)) -> (),
+    F: Fn((&Object<DefaultScalarValue>, &Vec<Value<DefaultScalarValue>>)),
 {
     let schema = RootNode::new(
         Root,

juniper/src/executor_tests/introspection/input_object.rs

@@ -114,7 +114,7 @@ impl Root {
 
 async fn run_type_info_query<F>(doc: &str, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>, &Vec<Value<DefaultScalarValue>>) -> (),
+    F: Fn(&Object<DefaultScalarValue>, &Vec<Value<DefaultScalarValue>>),
 {
     let schema = RootNode::new(
         Root,

juniper/src/executor_tests/variables.rs

@@ -120,7 +120,7 @@ impl TestType {
 
 async fn run_variable_query<F>(query: &str, vars: Variables<DefaultScalarValue>, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     let schema = RootNode::new(
         TestType,
@@ -143,7 +143,7 @@ where
 
 async fn run_query<F>(query: &str, f: F)
 where
-    F: Fn(&Object<DefaultScalarValue>) -> (),
+    F: Fn(&Object<DefaultScalarValue>),
 {
     run_variable_query(query, graphql_vars! {}, f).await;
 }

juniper/src/parser/tests/document.rs

@@ -16,7 +16,7 @@ where
         s,
         &SchemaType::new::<QueryRoot, MutationRoot, SubscriptionRoot>(&(), &(), &()),
     )
-    .expect(&format!("Parse error on input {s:#?}"))
+    .unwrap_or_else(|_| panic!("Parse error on input {s:#?}"))
 }
 
 fn parse_document_error<S: ScalarValue>(s: &str) -> Spanning<ParseError> {

juniper/src/parser/tests/lexer.rs

@@ -1,6 +1,6 @@
 use crate::parser::{Lexer, LexerError, ScalarToken, SourcePosition, Spanning, Token};
 
-fn tokenize_to_vec<'a>(s: &'a str) -> Vec<Spanning<Token<'a>>> {
+fn tokenize_to_vec(s: &str) -> Vec<Spanning<Token<'_>>> {
     let mut tokens = Vec::new();
     let mut lexer = Lexer::new(s);
 
@@ -21,7 +21,7 @@ fn tokenize_to_vec<'a>(s: &'a str) -> Vec<Spanning<Token<'a>>> {
     tokens
 }
 
-fn tokenize_single<'a>(s: &'a str) -> Spanning<Token<'a>> {
+fn tokenize_single(s: &str) -> Spanning<Token<'_>> {
     let mut tokens = tokenize_to_vec(s);
 
     assert_eq!(tokens.len(), 2);
@@ -178,7 +178,7 @@ fn strings() {
         Spanning::start_end(
             &SourcePosition::new(0, 0, 0),
             &SourcePosition::new(20, 0, 20),
-            Token::Scalar(ScalarToken::String(r#"escaped \n\r\b\t\f"#))
+            Token::Scalar(ScalarToken::String(r"escaped \n\r\b\t\f"))
         )
     );
 
@@ -187,7 +187,7 @@ fn strings() {
         Spanning::start_end(
             &SourcePosition::new(0, 0, 0),
             &SourcePosition::new(15, 0, 15),
-            Token::Scalar(ScalarToken::String(r#"slashes \\ \/"#))
+            Token::Scalar(ScalarToken::String(r"slashes \\ \/"))
         )
     );
 
@@ -196,7 +196,7 @@ fn strings() {
         Spanning::start_end(
             &SourcePosition::new(0, 0, 0),
             &SourcePosition::new(34, 0, 34),
-            Token::Scalar(ScalarToken::String(r#"unicode \u1234\u5678\u90AB\uCDEF"#)),
+            Token::Scalar(ScalarToken::String(r"unicode \u1234\u5678\u90AB\uCDEF")),
         )
     );
 }

juniper/src/parser/tests/value.rs

@@ -36,7 +36,7 @@ impl Query {
     }
 
     fn float_field() -> f64 {
-        3.14
+        3.12
     }
 
     fn string_field() -> String {
@@ -65,11 +65,12 @@ where
     S: ScalarValue,
 {
     let mut lexer = Lexer::new(s);
-    let mut parser = Parser::new(&mut lexer).expect(&format!("Lexer error on input {s:#?}"));
+    let mut parser =
+        Parser::new(&mut lexer).unwrap_or_else(|_| panic!("Lexer error on input {s:#?}"));
     let schema = SchemaType::new::<Query, EmptyMutation<()>, EmptySubscription<()>>(&(), &(), &());
 
     parse_value_literal(&mut parser, false, &schema, Some(meta))
-        .expect(&format!("Parse error on input {s:#?}"))
+        .unwrap_or_else(|_| panic!("Parse error on input {s:#?}"))
 }
 
 #[test]

juniper/src/schema/translate/graphql_parser.rs

@@ -264,7 +264,7 @@ impl GraphQLParserTranslator {
                     .map(|x| GraphQLParserTranslator::translate_argument(x))
                     .collect()
             })
-            .unwrap_or_else(Vec::new);
+            .unwrap_or_default();
 
         ExternalField {
             position: Pos::default(),