Replaced smartstring with compact_str

- implement `String` scalar for `compact_str::CompactString`

Author: tyranron

juniper/CHANGELOG.md

@@ -64,6 +64,7 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
         - Made `name()` method returning `ArcStr`.
     - `GraphQLValue`:
         - Made `type_name()` method returning `ArcStr`.
+- Switched `ParseError::UnexpectedToken` to `compact_str::CompactString` instead of `smartstring::SmartString`. ([todo])
 
 ### Added
 
@@ -77,6 +78,7 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
     - `jiff::tz::Offset` as `UtcOffset` scalar.
     - `jiff::Span` as `Duration` scalar.
 - `http::GraphQLResponse::into_result()` method. ([#1293])
+- `String` scalar implementation for `compact_str::CompactString`. ([todo])
 
 ### Changed
 
@@ -103,6 +105,7 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
 [#1318]: /../../pull/1318
 [#1319]: /../../pull/1319
 [1b1fc618]: /../../commit/1b1fc61879ffdd640d741e187dc20678bf7ab295
+[todo]: /../../commit/todo
 
 
 

juniper/Cargo.toml

@@ -50,6 +50,7 @@ bigdecimal = { version = "0.4", optional = true }
 bson = { version = "2.4", optional = true }
 chrono = { version = "0.4.30", features = ["alloc"], default-features = false, optional = true }
 chrono-tz = { version = "0.10", default-features = false, optional = true }
+compact_str = "0.9"
 fnv = "1.0.5"
 futures = { version = "0.3.22", features = ["alloc"], default-features = false }
 graphql-parser = { version = "0.4", optional = true }
@@ -60,7 +61,6 @@ rust_decimal = { version = "1.20", default-features = false, optional = true }
 ryu = { version = "1.0", optional = true }
 serde = { version = "1.0.122", features = ["derive"] }
 serde_json = { version = "1.0.18", features = ["std"], default-features = false, optional = true }
-smartstring = "1.0"
 static_assertions = "1.1"
 time = { version = "0.3.37", features = ["formatting", "macros", "parsing"], optional = true }
 url = { version = "2.0", optional = true }

juniper/src/parser/parser.rs

@@ -1,6 +1,6 @@
 use std::{error::Error, fmt};
 
-use smartstring::alias::String;
+use compact_str::{CompactString, format_compact};
 
 use crate::parser::{Lexer, LexerError, Spanning, Token};
 
@@ -10,7 +10,7 @@ pub enum ParseError {
     /// An unexpected token occurred in the source
     // TODO: Previously was `Token<'a>`.
     //       Revisit on `graphql-parser` integration.
-    UnexpectedToken(String),
+    UnexpectedToken(CompactString),
 
     /// The input source abruptly ended
     UnexpectedEndOfFile,
@@ -48,14 +48,7 @@ impl ParseError {
     /// Creates a [`ParseError::UnexpectedToken`] out of the provided [`Token`].
     #[must_use]
     pub fn unexpected_token(token: Token<'_>) -> Self {
-        use std::fmt::Write as _;
-
-        let mut s = String::new();
-        // PANIC: Unwrapping is OK here, as it may panic only on allocation
-        //        error.
-        write!(s, "{token}").unwrap();
-
-        Self::UnexpectedToken(s)
+        Self::UnexpectedToken(format_compact!("{token}"))
     }
 }
 

juniper/src/types/scalars.rs

@@ -207,6 +207,26 @@ mod impl_arcstr_scalar {
     }
 }
 
+#[graphql_scalar]
+#[graphql(name = "String", with = impl_compactstring_scalar, parse_token(String))]
+type CompactString = compact_str::CompactString;
+
+mod impl_compactstring_scalar {
+    use crate::{InputValue, ScalarValue, Value};
+
+    use super::CompactString;
+
+    pub(super) fn to_output<S: ScalarValue>(v: &CompactString) -> Value<S> {
+        Value::scalar(v.to_string())
+    }
+
+    pub(super) fn from_input<S: ScalarValue>(v: &InputValue<S>) -> Result<CompactString, String> {
+        v.as_string_value()
+            .map(Into::into)
+            .ok_or_else(|| format!("Expected `String`, found: {v}"))
+    }
+}
+
 impl<S> reflect::WrappedType<S> for str {
     const VALUE: reflect::WrappedValue = 1;
 }