Fix Rejection handling in juniper_warp filters (#1222, #1177)

- rework `make_graphql_filter()` and `make_graphql_filter_sync()` to execute `context_extractor` only once
- handle all non-recoverable `Rejection`s in `make_graphql_filter()` and `make_graphql_filter_sync()`
- relax requirement for `context_extractor` to be a `BoxedFilter` only
- remove `JoinError` from public API
- provide example of fallible `context_extractor` in `make_graphql_filter()` API docs

Additionally:
- split  `juniper_warp` modules into separate files
- add @tyranron as `juniper_warp` co-author

Author: tyranron

juniper_warp/CHANGELOG.md

@@ -11,6 +11,7 @@ All user visible changes to `juniper_warp` crate will be documented in this file
 ### BC Breaks
 
 - Switched to 0.16 version of [`juniper` crate].
+- Removed `JoinError` from public API. ([#1222], [#1177])
 
 ### Added
 
@@ -20,11 +21,18 @@ All user visible changes to `juniper_warp` crate will be documented in this file
 ### Changed
 
 - Made `schema` argument of `make_graphql_filter()` and `make_graphql_filter_sync()` polymorphic, allowing to specify external `Arc`ed `schema`. ([#1136], [#1135])
+- Relaxed requirement for `context_extractor` to be a `BoxedFilter` only. ([#1222], [#1177])
+
+### Fixed
+
+- Excessive `context_extractor` execution in `make_graphql_filter()` and `make_graphql_filter_sync()`. ([#1222], [#1177])
 
 [#1135]: /../../issues/1136
 [#1136]: /../../pull/1136
 [#1158]: /../../pull/1158
+[#1177]: /../../issues/1177
 [#1191]: /../../pull/1191
+[#1222]: /../../pull/1222
 
 
 

juniper_warp/Cargo.toml

@@ -5,7 +5,10 @@ edition = "2021"
 rust-version = "1.73"
 description = "`juniper` GraphQL integration with `warp`."
 license = "BSD-2-Clause"
-authors = ["Tom Houlé <[email protected]>"]
+authors = [
+    "Tom Houlé <[email protected]>",
+    "Kai Ren <[email protected]>",
+]
 documentation = "https://docs.rs/juniper_warp"
 homepage = "https://github.com/graphql-rust/juniper/tree/master/juniper_warp"
 repository = "https://github.com/graphql-rust/juniper"
@@ -20,21 +23,21 @@ rustdoc-args = ["--cfg", "docsrs"]
 
 [features]
 subscriptions = [
+    "dep:futures",
     "dep:juniper_graphql_ws",
     "dep:log",
     "warp/websocket",
 ]
 
 [dependencies]
-anyhow = "1.0.47"
-futures = "0.3.22"
+futures = { version = "0.3.22", optional = true }
 juniper = { version = "0.16.0-dev", path = "../juniper", default-features = false }
 juniper_graphql_ws = { version = "0.4.0-dev", path = "../juniper_graphql_ws", features = ["graphql-transport-ws", "graphql-ws"], optional = true }
 log = { version = "0.4", optional = true }
 serde = { version = "1.0.122", features = ["derive"] }
 serde_json = "1.0.18"
 thiserror = "1.0"
-tokio = { version = "1.0", features = ["rt-multi-thread"] }
+tokio = { version = "1.0", features = ["rt"] }
 warp = { version = "0.3.2", default-features = false }
 
 # Fixes for `minimal-versions` check.
@@ -44,6 +47,7 @@ headers = "0.3.8"
 [dev-dependencies]
 async-stream = "0.3"
 env_logger = "0.10"
+futures = "0.3.22"
 juniper = { version = "0.16.0-dev", path = "../juniper", features = ["expose-test-schema"] }
 log = "0.4"
 percent-encoding = "2.1"

juniper_warp/LICENSE

@@ -1,6 +1,6 @@
 BSD 2-Clause License
 
-Copyright (c) 2018-2022, Tom Houlé
+Copyright (c) 2018-2023, Tom Houlé, Kai Ren
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

juniper_warp/examples/subscription.rs

@@ -160,7 +160,7 @@ async fn main() {
         .and(warp::path("graphql"))
         .and(juniper_warp::make_graphql_filter(
             schema.clone(),
-            warp::any().map(|| Context).boxed(),
+            warp::any().map(|| Context),
         )))
     .or(
         warp::path("subscriptions").and(juniper_warp::subscriptions::make_ws_filter(