Skip to content

Commit 5f82b53

Browse files
committed
Mention in CHANGELOG
1 parent 93ffb18 commit 5f82b53

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

juniper/CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
6464
- Made `name()` method returning `ArcStr`.
6565
- `GraphQLValue`:
6666
- Made `type_name()` method returning `ArcStr`.
67-
- Switched `ParseError::UnexpectedToken` to `compact_str::CompactString` instead of `smartstring::SmartString`. ([todo])
67+
- Switched `ParseError::UnexpectedToken` to `compact_str::CompactString` instead of `smartstring::SmartString`. ([20609366])
68+
- Replaced `Value`'s `From` implementations with `IntoValue` ones. ([#1324])
69+
- Replaced `InputValue`'s `From` implementations with `IntoInputValue` ones. ([#1324])
6870

6971
### Added
7072

@@ -78,7 +80,10 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
7880
- `jiff::tz::Offset` as `UtcOffset` scalar.
7981
- `jiff::Span` as `Duration` scalar.
8082
- `http::GraphQLResponse::into_result()` method. ([#1293])
83+
- `String` scalar implementation for `arcstr::ArcStr`. ([#1247])
8184
- `String` scalar implementation for `compact_str::CompactString`. ([20609366])
85+
- `ScalarValue::from_displayable()` method allowing to specialize `ScalarValue` conversion from custom string types. ([#1324], [#819])
86+
- `IntoValue` and `IntoInputValue` conversion traits allowing to work around orphan rules with custom `ScalarValue`. ([#1324])
8287

8388
### Changed
8489

@@ -103,6 +108,7 @@ All user visible changes to `juniper` crate will be documented in this file. Thi
103108
[#1293]: /../../pull/1293
104109
[#1311]: /../../pull/1311
105110
[#1318]: /../../pull/1318
111+
[#1324]: /../../pull/1324
106112
[#1325]: /../../pull/1325
107113
[1b1fc618]: /../../commit/1b1fc61879ffdd640d741e187dc20678bf7ab295
108114
[20609366]: /../../commit/2060936635609b0186d46d8fbd06eb30fce660e3

juniper_codegen/src/scalar_value/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ impl Definition {
309309
let from_displayable = self.from_displayable.as_ref().map(|expr| {
310310
quote! {
311311
fn from_displayable<Str: ::core::fmt::Display + ::core::any::Any + ?Sized>(
312-
__s: &Str
312+
__s: &Str,
313313
) -> Self {
314314
#expr(__s)
315315
}

0 commit comments

Comments
 (0)