Strip Sized from ToInputValue

Author: tyranron

juniper/src/ast.rs

@@ -231,8 +231,8 @@ pub trait FromInputValue<S = DefaultScalarValue>: Sized {
     }
 }
 
-/// Losslessly clones a Rust data type into an InputValue.
-pub trait ToInputValue<S = DefaultScalarValue>: Sized {
+/// Losslessly clones a Rust data type into an [`InputValue`].
+pub trait ToInputValue<S = DefaultScalarValue> {
     /// Performs the conversion.
     fn to_input_value(&self) -> InputValue<S>;
 }

juniper/src/lib.rs

@@ -103,8 +103,8 @@ pub use crate::{
     },
     validation::RuleError,
     value::{
-        AnyExt, DefaultScalarValue, FromScalarValue, ToScalarValue, IntoValue, Object,
-        ParseScalarResult, ParseScalarValue, Scalar, ScalarValue, TryToPrimitive, Value,
+        AnyExt, DefaultScalarValue, FromScalarValue, IntoValue, Object, ParseScalarResult,
+        ParseScalarValue, Scalar, ScalarValue, ToScalarValue, TryToPrimitive, Value,
         WrongInputScalarTypeError,
     },
 };

juniper/src/types/containers.rs

@@ -90,7 +90,10 @@ impl<S, T: FromInputValue<S>> FromInputValue<S> for Option<T> {
     }
 }
 
-impl<S, T: ToInputValue<S>> ToInputValue<S> for Option<T> {
+impl<S, T> ToInputValue<S> for Option<T>
+where
+    T: ToInputValue<S>,
+{
     fn to_input_value(&self) -> InputValue<S> {
         match self {
             Some(v) => v.to_input_value(),
@@ -176,7 +179,6 @@ impl<S: ScalarValue, T: FromInputValue<S>> FromInputValue<S> for Vec<T> {
 impl<T, S> ToInputValue<S> for Vec<T>
 where
     T: ToInputValue<S>,
-    S: ScalarValue,
 {
     fn to_input_value(&self) -> InputValue<S> {
         InputValue::list(self.iter().map(T::to_input_value).collect())
@@ -270,10 +272,9 @@ where
     }
 }
 
-impl<T, S> ToInputValue<S> for &[T]
+impl<T, S> ToInputValue<S> for [T]
 where
     T: ToInputValue<S>,
-    S: ScalarValue,
 {
     fn to_input_value(&self) -> InputValue<S> {
         InputValue::list(self.iter().map(T::to_input_value).collect())
@@ -462,7 +463,6 @@ where
 impl<T, S, const N: usize> ToInputValue<S> for [T; N]
 where
     T: ToInputValue<S>,
-    S: ScalarValue,
 {
     fn to_input_value(&self) -> InputValue<S> {
         InputValue::list(self.iter().map(T::to_input_value).collect())

juniper/src/types/nullable.rs

@@ -302,11 +302,10 @@ impl<S, T: FromInputValue<S>> FromInputValue<S> for Nullable<T> {
 impl<S, T> ToInputValue<S> for Nullable<T>
 where
     T: ToInputValue<S>,
-    S: ScalarValue,
 {
     fn to_input_value(&self) -> InputValue<S> {
-        match *self {
-            Self::Some(ref v) => v.to_input_value(),
+        match self {
+            Self::Some(v) => v.to_input_value(),
             _ => InputValue::null(),
         }
     }

juniper/src/types/pointers.rs

@@ -1,4 +1,4 @@
-use std::{fmt, sync::Arc};
+use std::sync::Arc;
 
 use arcstr::ArcStr;
 
@@ -11,7 +11,7 @@ use crate::{
         async_await::GraphQLValueAsync,
         base::{Arguments, GraphQLType, GraphQLValue},
     },
-    value::{FromScalarValue, ToScalarValue, ScalarValue},
+    value::{FromScalarValue, ScalarValue, ToScalarValue},
 };
 
 impl<S, T> GraphQLType<S> for Box<T>
@@ -122,8 +122,7 @@ where
 
 impl<T, S> ToInputValue<S> for Box<T>
 where
-    S: fmt::Debug,
-    T: ToInputValue<S>,
+    T: ToInputValue<S> + ?Sized,
 {
     fn to_input_value(&self) -> InputValue<S> {
         (**self).to_input_value()
@@ -224,8 +223,7 @@ where
 
 impl<T, S> ToInputValue<S> for &T
 where
-    S: fmt::Debug,
-    T: ToInputValue<S>,
+    T: ToInputValue<S> + ?Sized,
 {
     fn to_input_value(&self) -> InputValue<S> {
         (**self).to_input_value()
@@ -340,8 +338,7 @@ where
 
 impl<T, S> ToInputValue<S> for Arc<T>
 where
-    S: fmt::Debug,
-    T: ToInputValue<S>,
+    T: ToInputValue<S> + ?Sized,
 {
     fn to_input_value(&self) -> InputValue<S> {
         (**self).to_input_value()

juniper/src/types/scalars.rs

@@ -317,7 +317,7 @@ impl<S: ScalarValue> ToScalarValue<S> for str {
     }
 }
 
-impl<S> ToInputValue<S> for &str
+impl<S> ToInputValue<S> for str
 where
     str: ToScalarValue<S>,
 {

juniper/src/value/mod.rs

@@ -9,8 +9,8 @@ use compact_str::CompactString;
 pub use self::{
     object::Object,
     scalar::{
-        AnyExt, DefaultScalarValue, FromScalarValue, ToScalarValue, ParseScalarResult,
-        ParseScalarValue, Scalar, ScalarValue, TryToPrimitive, WrongInputScalarTypeError,
+        AnyExt, DefaultScalarValue, FromScalarValue, ParseScalarResult, ParseScalarValue, Scalar,
+        ScalarValue, ToScalarValue, TryToPrimitive, WrongInputScalarTypeError,
     },
 };
 use crate::{