Make it lint

Author: tyranron

juniper/src/schema/translate/mod.rs

@@ -1,6 +1,9 @@
 use crate::{ScalarValue, SchemaType};
 
-#[cfg_attr(not(feature = "schema-language"), allow(dead_code))]
+#[cfg_attr(
+    not(feature = "schema-language"),
+    expect(dead_code, reason = "common abstraction")
+)]
 pub trait SchemaTranslator<'a, T> {
     fn translate_schema<S: 'a + ScalarValue>(s: &'a SchemaType<S>) -> T;
 }

juniper_axum/src/lib.rs

@@ -2,6 +2,11 @@
 #![cfg_attr(any(doc, test), doc = include_str!("../README.md"))]
 #![cfg_attr(not(any(doc, test)), doc = env!("CARGO_PKG_NAME"))]
 
+// TODO: Try remove on upgrade of `axum` crate.
+mod for_minimal_versions_check_only {
+    use bytes as _;
+}
+
 pub mod extract;
 pub mod response;
 #[cfg(feature = "subscriptions")]

juniper_hyper/src/lib.rs

@@ -16,8 +16,10 @@ use juniper::{
 use serde_json::error::Error as SerdeError;
 use url::form_urlencoded;
 
+/// Executes synchronously  the provided GraphQL [`Request`] against the provided `schema` in the
+/// provided `context`, returning the encoded [`Response`].
 pub async fn graphql_sync<CtxT, QueryT, MutationT, SubscriptionT, S, B>(
-    root_node: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
+    schema: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
     context: Arc<CtxT>,
     req: Request<B>,
 ) -> Response<String>
@@ -33,13 +35,15 @@ where
     B: Body<Error: fmt::Display>,
 {
     match parse_req(req).await {
-        Ok(req) => execute_request_sync(root_node, context, req).await,
+        Ok(req) => execute_request_sync(schema, context, req).await,
         Err(resp) => resp,
     }
 }
 
+/// Executes the provided GraphQL [`Request`] against the provided `schema` in the provided
+/// `context`, returning the encoded [`Response`].
 pub async fn graphql<CtxT, QueryT, MutationT, SubscriptionT, S, B>(
-    root_node: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
+    schema: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
     context: Arc<CtxT>,
     req: Request<B>,
 ) -> Response<String>
@@ -55,7 +59,7 @@ where
     B: Body<Error: fmt::Display>,
 {
     match parse_req(req).await {
-        Ok(req) => execute_request(root_node, context, req).await,
+        Ok(req) => execute_request(schema, context, req).await,
         Err(resp) => resp,
     }
 }
@@ -137,6 +141,11 @@ where
     )))
 }
 
+/// Generates a [`Response`] page containing [GraphiQL].
+///
+/// This does not handle routing, so you can mount it on any endpoint.
+///
+/// [GraphiQL]: https://github.com/graphql/graphiql
 pub async fn graphiql(
     graphql_endpoint: &str,
     subscriptions_endpoint: Option<&str>,
@@ -148,6 +157,11 @@ pub async fn graphiql(
     resp
 }
 
+/// Generates a [`Response`] page containing [GraphQL Playground].
+///
+/// This does not handle routing, so you can mount it on any endpoint.
+///
+/// [GraphQL Playground]: https://github.com/prisma/graphql-playground
 pub async fn playground(
     graphql_endpoint: &str,
     subscriptions_endpoint: Option<&str>,
@@ -168,7 +182,7 @@ where
 }
 
 async fn execute_request_sync<CtxT, QueryT, MutationT, SubscriptionT, S>(
-    root_node: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
+    schema: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
     context: Arc<CtxT>,
     request: GraphQLBatchRequest<S>,
 ) -> Response<String>
@@ -182,7 +196,7 @@ where
     CtxT: Sync,
     S: ScalarValue + Send + Sync,
 {
-    let res = request.execute_sync(&*root_node, &context);
+    let res = request.execute_sync(&*schema, &context);
     let body = serde_json::to_string_pretty(&res).unwrap();
     let code = if res.is_ok() {
         StatusCode::OK
@@ -199,7 +213,7 @@ where
 }
 
 async fn execute_request<CtxT, QueryT, MutationT, SubscriptionT, S>(
-    root_node: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
+    schema: Arc<RootNode<'static, QueryT, MutationT, SubscriptionT, S>>,
     context: Arc<CtxT>,
     request: GraphQLBatchRequest<S>,
 ) -> Response<String>
@@ -213,7 +227,7 @@ where
     CtxT: Sync,
     S: ScalarValue + Send + Sync,
 {
-    let res = request.execute(&*root_node, &context).await;
+    let res = request.execute(&*schema, &context).await;
     let body = serde_json::to_string_pretty(&res).unwrap();
     let code = if res.is_ok() {
         StatusCode::OK

juniper_warp/Cargo.toml

@@ -34,9 +34,7 @@ futures = { version = "0.3.22", optional = true }
 juniper = { version = "0.16", path = "../juniper", default-features = false }
 juniper_graphql_ws = { version = "0.4.0", path = "../juniper_graphql_ws", features = ["graphql-transport-ws", "graphql-ws"], optional = true }
 log = { version = "0.4", optional = true }
-serde = { version = "1.0.122", features = ["derive"] }
 serde_json = "1.0.18"
-thiserror = "2.0"
 tokio = { version = "1.0", features = ["rt"] }
 warp = { version = "0.3.2", default-features = false }
 

juniper_warp/src/lib.rs

@@ -3,6 +3,11 @@
 #![cfg_attr(docsrs, feature(doc_cfg))]
 #![deny(missing_docs)]
 
+// TODO: Try remove on upgrade of `warp` crate.
+mod for_minimal_versions_check_only {
+    use headers as _;
+}
+
 mod response;
 #[cfg(feature = "subscriptions")]
 pub mod subscriptions;

tests/integration/Cargo.toml

@@ -5,10 +5,7 @@ edition = "2024"
 publish = false
 
 [dev-dependencies]
-async-trait = "0.1.39"
 chrono = { version = "0.4", default-features = false }
-derive_more = { version = "2.0", features = ["from"] }
-fnv = "1.0"
 futures = "0.3"
 itertools = "0.14"
 juniper = { path = "../../juniper", features = ["chrono"] }
@@ -24,7 +21,5 @@ allow_attributes_without_reason = "warn"
 closure_returning_async_block = "warn"
 future_incompatible = { level = "warn", priority = -1 }
 impl_trait_redundant_captures = "warn"
-missing_docs = "warn"
 non_ascii_idents = "forbid"
 unsafe_code = "forbid"
-unused_crate_dependencies = "warn"

tests/integration/tests/codegen_enum_derive.rs

@@ -10,7 +10,6 @@ use juniper::{
 use self::common::util::{schema, schema_with_scalar};
 
 // Override `std::prelude` items to check whether macros expand hygienically.
-#[allow(unused_imports)]
 use self::common::hygiene::*;
 
 mod trivial {
@@ -125,7 +124,6 @@ mod ignored_variant {
     #[derive(GraphQLEnum)]
     enum Character {
         Human,
-        #[allow(dead_code)]
         #[graphql(ignore)]
         Droid,
     }
@@ -210,7 +208,7 @@ mod ignored_generic_variant {
     enum Character<T> {
         Human,
         Droid,
-        #[allow(dead_code)]
+        #[expect(dead_code, reason = "GraphQL schema testing")]
         #[graphql(ignore)]
         Ignored(T),
     }
@@ -390,7 +388,7 @@ mod description_from_doc_comment {
 }
 
 mod deprecation_from_attr {
-    #![allow(deprecated)]
+    #![expect(deprecated, reason = "GraphQL schema testing")]
 
     use super::*;
 
@@ -492,8 +490,6 @@ mod deprecation_from_attr {
 }
 
 mod deprecation_from_graphql_attr {
-    #![allow(deprecated)]
-
     use super::*;
 
     /// Character doc.
@@ -594,7 +590,7 @@ mod deprecation_from_graphql_attr {
 }
 
 mod explicit_name_description_and_deprecation {
-    #![allow(deprecated)]
+    #![expect(deprecated, reason = "GraphQL schema testing")]
 
     use super::*;
 
@@ -834,7 +830,7 @@ mod explicit_generic_scalar {
     enum Character<S: ScalarValue> {
         Human,
         Droid,
-        #[allow(dead_code)]
+        #[expect(dead_code, reason = "GraphQL schema testing")]
         #[graphql(ignore)]
         Scalar(S),
     }
@@ -900,7 +896,7 @@ mod bounded_generic_scalar {
 mod explicit_custom_context {
     use super::*;
 
-    struct CustomContext(#[allow(dead_code)] prelude::String);
+    struct CustomContext(#[expect(dead_code, reason = "GraphQL schema testing")] prelude::String);
 
     impl juniper::Context for CustomContext {}
 

tests/integration/tests/codegen_input_object_derive.rs

@@ -10,7 +10,6 @@ use juniper::{
 use self::common::util::schema;
 
 // Override `std::prelude` items to check whether macros expand hygienically.
-#[allow(unused_imports)]
 use self::common::hygiene::*;
 
 mod trivial {

tests/integration/tests/codegen_interface_attr_struct.rs

@@ -10,7 +10,6 @@ use juniper::{
 use self::common::util::{schema, schema_with_scalar};
 
 // Override `std::prelude` items to check whether macros expand hygienically.
-#[allow(unused_imports)]
 use self::common::hygiene::*;
 
 mod no_implers {
@@ -2234,7 +2233,7 @@ mod field_return_union_subtyping {
         value: i32,
     }
 
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "GraphQL schema testing")]
     #[derive(GraphQLUnion)]
     enum KeyFeature {
         Strength(Strength),
@@ -3063,7 +3062,7 @@ mod branching_subtyping {
 mod preserves_visibility {
     use super::*;
 
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "GraphQL schema testing")]
     type Foo = self::inner::CharacterValue;
 
     pub(crate) mod inner {

tests/integration/tests/codegen_interface_attr_trait.rs

@@ -1,6 +1,6 @@
 //! Tests for `#[graphql_interface]` macro placed on a trait.
 
-#![allow(dead_code)]
+#![expect(dead_code, reason = "GraphQL schema definition")]
 // Assert that `#[graphql_interface]` macro placed on a trait stops Clippy from enforcing `# Errors`
 // and `# Panics` sections in GraphQL descriptions.
 #![deny(clippy::missing_errors_doc, clippy::missing_panics_doc)]
@@ -16,7 +16,6 @@ use juniper::{
 use self::common::util::{schema, schema_with_scalar};
 
 // Override `std::prelude` items to check whether macros expand hygienically.
-#[allow(unused_imports)]
 use self::common::hygiene::*;
 
 mod no_implers {
@@ -2367,7 +2366,7 @@ mod explicit_custom_context {
 
     #[graphql_object(impl = CharacterValue, context = CustomContext)]
     impl Droid {
-        #[allow(clippy::needless_lifetimes)] // intentionally
+        #[expect(clippy::needless_lifetimes, reason = "intentional")]
         async fn id<'a>(&'a self) -> &'a str {
             &self.id
         }
@@ -2376,7 +2375,7 @@ mod explicit_custom_context {
             &self.primary_function
         }
 
-        #[allow(clippy::needless_lifetimes)] // intentionally
+        #[expect(clippy::needless_lifetimes, reason = "intentional")]
         async fn info<'b>(&'b self) -> &'b str {
             &self.primary_function
         }
@@ -2675,7 +2674,7 @@ mod executor {
             &self.home_planet
         }
 
-        #[allow(clippy::needless_lifetimes)] // intentionally
+        #[expect(clippy::needless_lifetimes, reason = "intentional")]
         async fn info<'b>(&'b self, _arg: prelude::Option<i32>) -> &'b str {
             &self.home_planet
         }
@@ -3068,7 +3067,7 @@ mod field_return_union_subtyping {
         value: i32,
     }
 
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "GraphQL schema testing")]
     #[derive(GraphQLUnion)]
     enum KeyFeature {
         Strength(Strength),
@@ -3898,7 +3897,7 @@ mod branching_subtyping {
 mod preserves_visibility {
     use super::*;
 
-    #[allow(dead_code)]
+    #[expect(dead_code, reason = "GraphQL schema testing")]
     type Foo = self::inner::CharacterValue;
 
     pub(crate) mod inner {