Replace 'dtslint' with TS integration test

Author: IvanGoncharov

.eslintrc.yml

@@ -477,11 +477,11 @@ rules:
   wrap-regex: off
   yield-star-spacing: off
 
+ignorePatterns: 'integrationTests/ts/*.ts'
 overrides:
   - files: '**/*.ts'
     parser: '@typescript-eslint/parser'
     parserOptions:
-      tsconfigRootDir: './types/'
       project: ['tsconfig.json']
     plugins:
       - '@typescript-eslint'
@@ -633,6 +633,16 @@ overrides:
       import/no-extraneous-dependencies: [error, { devDependencies: true }]
       import/no-nodejs-modules: off
       no-sync: off
+  - files: 'integrationTests/**'
+    parserOptions:
+      sourceType: script
+    rules:
+      node/no-unpublished-import: off
+      node/no-unpublished-require: off
+      node/no-sync: off
+      import/no-extraneous-dependencies: [error, { devDependencies: true }]
+      import/no-nodejs-modules: off
+      no-console: off
   - files: 'resources/**'
     parserOptions:
       sourceType: script

.github/workflows/ci.yml

@@ -35,6 +35,29 @@ jobs:
       - name: Lint Flow
         run: npm run check
 
+  integrationTests:
+    name: Run integration tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v2
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.NODE_VERSION_USED_FOR_DEVELOPMENT }}
+
+      # We install bunch of packages during integration tests without locking them
+      # so we skip cache action to not pollute cache for other jobs.
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Build NPM package
+        run: npm run build
+
+      - name: Run Integration Tests
+        run: npm run check:integrations
+
   coverage:
     name: Measure test coverage
     runs-on: ubuntu-latest

.gitignore

@@ -7,5 +7,6 @@
 npm-debug.log
 
 dist
+integrationTmp
 node_modules
 coverage

integrationTests/README.md

@@ -0,0 +1 @@
+# TBD

integrationTests/integration-test.js

@@ -0,0 +1,30 @@
+// @noflow
+
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+const childProcess = require('child_process');
+
+const { describe, it } = require('mocha');
+
+function exec(command, options = {}) {
+  return childProcess.execSync(command, {
+    stdio: 'inherit',
+    ...options,
+  });
+}
+
+describe('Integration Tests', () => {
+  const tmpDir = path.resolve('./integrationTmp');
+  fs.rmdirSync(tmpDir, { recursive: true });
+  fs.mkdirSync(tmpDir);
+
+  it('Should compile with all supported TS versions', () => {
+    exec(`cp -R ${path.join(__dirname, 'ts')} ${tmpDir}`);
+
+    const cwd = path.join(tmpDir, 'ts');
+    exec('npm install --silent', { cwd });
+    exec('npm test', { cwd });
+  }).timeout(40000);
+});

types/test.ts renamed to integrationTests/ts/index.ts

@@ -0,0 +1,19 @@
+{
+  "scripts": {
+    "test": "node test.js"
+  },
+  "dependencies": {
+    "@types/node": "14.0.13",
+    "express-graphql": "file:../../dist",
+    "typescript-3.0": "npm:[email protected]",
+    "typescript-3.1": "npm:[email protected]",
+    "typescript-3.2": "npm:[email protected]",
+    "typescript-3.3": "npm:[email protected]",
+    "typescript-3.4": "npm:[email protected]",
+    "typescript-3.5": "npm:[email protected]",
+    "typescript-3.6": "npm:[email protected]",
+    "typescript-3.7": "npm:[email protected]",
+    "typescript-3.8": "npm:[email protected]",
+    "typescript-3.9": "npm:[email protected]"
+  }
+}

integrationTests/ts/package.json

@@ -0,0 +1,19 @@
+// @noflow
+
+'use strict';
+
+const path = require('path');
+const childProcess = require('child_process');
+
+const { dependencies } = require('./package.json');
+
+const tsVersions = Object.keys(dependencies)
+  .filter((pkg) => pkg.startsWith('typescript-'))
+  .sort((a, b) => b.localeCompare(a));
+
+for (const version of tsVersions) {
+  console.log(`Testing on ${version} ...`);
+
+  const tscPath = path.join(__dirname, 'node_modules', version, 'bin/tsc');
+  childProcess.execSync(tscPath, { stdio: 'inherit' });
+}

integrationTests/ts/test.js

@@ -0,0 +1,8 @@
+{
+  "compilerOptions": {
+    "module": "commonjs",
+    "lib": ["es6", "esnext.asynciterable"],
+    "strict": true,
+    "noEmit": true
+  }
+}