Skip to content

Commit 2500288

Browse files
authored
remove Warning: useLayoutEffect does nothing on the server, because … warnings on SSR (#3937)
* remove `Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format` warnings on SSR * Update .changeset/flat-beers-help.md
1 parent 2bfbb06 commit 2500288

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

.changeset/flat-beers-help.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@graphiql/react': patch
3+
'graphiql': patch
4+
---
5+
6+
remove `Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format` warnings on SSR

packages/graphiql-react/src/theme.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useLayoutEffect, useState } from 'react';
1+
import { useEffect, useState } from 'react';
22
import { useStorageContext } from './storage';
33

44
/**
@@ -30,11 +30,7 @@ export function useTheme(defaultTheme: Theme = null) {
3030
}
3131
});
3232

33-
useLayoutEffect(() => {
34-
if (typeof window === 'undefined') {
35-
return;
36-
}
37-
33+
useEffect(() => {
3834
document.body.classList.remove('graphiql-light', 'graphiql-dark');
3935
if (theme) {
4036
document.body.classList.add(`graphiql-${theme}`);

packages/graphiql-react/src/utility/resize.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useEffect, useLayoutEffect, useRef, useState } from 'react';
1+
import { useEffect, useRef, useState } from 'react';
22
import { useStorageContext } from '../storage';
33
import { debounce } from './debounce';
44

@@ -45,7 +45,7 @@ type UseDragResizeArgs = {
4545
};
4646

4747
export function useDragResize({
48-
defaultSizeRelation = DEFAULT_FLEX,
48+
defaultSizeRelation = 1,
4949
direction,
5050
initiallyHidden,
5151
onHiddenElementChange,
@@ -91,7 +91,7 @@ export function useDragResize({
9191
/**
9292
* Set initial flex values
9393
*/
94-
useLayoutEffect(() => {
94+
useEffect(() => {
9595
const storedValue =
9696
(storageKey && storage?.get(storageKey)) || defaultFlexRef.current;
9797

@@ -114,9 +114,9 @@ export function useDragResize({
114114
}, [direction, storage, storageKey]);
115115

116116
/**
117-
* Hide and show items when state changes
117+
* Hide and show items when the state changes
118118
*/
119-
useLayoutEffect(() => {
119+
useEffect(() => {
120120
const hide = (resizableElement: ResizableElement) => {
121121
const element =
122122
resizableElement === 'first' ? firstRef.current : secondRef.current;
@@ -285,6 +285,5 @@ export function useDragResize({
285285
};
286286
}
287287

288-
const DEFAULT_FLEX = 1;
289288
const HIDE_FIRST = 'hide-first';
290289
const HIDE_SECOND = 'hide-second';

0 commit comments

Comments
 (0)