chore: drop IE support, remove regenerator runtime (#1628)

use es6 as default typescript target
use browserslist always
remove all usage of regenerator runtime

Author: acao

.browserslistrc

@@ -1,5 +1,6 @@
-ie 11
-ios 10
-last 2 chrome versions
-last 2 edge versions
-last 2 firefox versions
+last 2 versions
+Firefox ESR
+not dead
+not IE 11
+not ios 10
+maintained node versions

README.md

@@ -128,6 +128,29 @@ An online immutable parser for [GraphQL](http://graphql.org/), designed to be us
 
 Utilities to support the [GraphQL Language Service](packages/graphql-language-service#readme).
 
+## Browser & Runtime Support
+
+Many of these packages need to work in multiple environments.
+
+By default, all typescript packages target `es6`.
+
+`graphql-language-service-server` and `graphql-language-service-cli` are made for the node runtime, so they target `es2017`
+
+`codemirror-graphql` and the `graphiql` browser bundle use the [`.browserslistrc`](./.browserlistrc), which targets modern browsers to keep bundle size small and keep the language services performant where async/await is used, and especially to avoid the requirement of `rengenerator-runtime` or special babel configuration.
+
+### [`.browserslistrc`](./.browserlistrc):
+
+```
+last 2 versions
+Firefox ESR
+not dead
+not IE 11
+not ios 10
+maintained node versions
+```
+
+To be clear, we do _not_ support Internet Explorer or older versions of evergreen browsers.
+
 ## Development
 
 To get setup for local development of this monorepo, refer to [DEVELOPMENT.md](./DEVELOPMENT.md)

babel.config.js

@@ -1,20 +1,18 @@
 // for ESM don't transpile modules
 
 const envConfig = {
-  ignoreBrowserslistConfig: true,
   modules: 'commonjs',
-  targets: { node: true },
-  bugfixes: true,
 };
 
 if (process.env.ESM) {
   envConfig.modules = false;
+  envConfig.targets = { node: true };
+  envConfig.bugfixes = true;
 }
 
 if (process.env.CDN) {
-  envConfig.modules = 'amd';
+  envConfig.modules = 'umd';
   envConfig.targets = null;
-  envConfig.ignoreBrowserslistConfig = false;
 }
 
 module.exports = {
@@ -32,8 +30,5 @@ module.exports = {
       compact: false,
     },
   },
-  plugins: [
-    require.resolve('@babel/plugin-proposal-class-properties'),
-    require.resolve('@babel/plugin-syntax-dynamic-import'),
-  ],
+  plugins: [require.resolve('@babel/plugin-proposal-class-properties')],
 };

examples/graphiql-webpack/babel.config.js

@@ -10,8 +10,5 @@ module.exports = {
     ],
     require.resolve('@babel/preset-react'),
   ],
-  plugins: [
-    require.resolve('@babel/plugin-syntax-dynamic-import'),
-    require.resolve('@babel/plugin-proposal-class-properties'),
-  ],
+  plugins: [require.resolve('@babel/plugin-proposal-class-properties')],
 };

examples/monaco-graphql-webpack/babel.config.js

@@ -4,22 +4,11 @@ module.exports = {
     [
       require.resolve('@babel/preset-env'),
       {
-        // corejs: { version: 3, proposals: true },
-        // useBuiltIns: 'usage',
         targets: { browsers: ['last 2 chrome versions'] },
         bugfixes: true,
       },
     ],
     [require.resolve('@babel/preset-typescript'), {}],
   ],
-  plugins: [
-    require.resolve('@babel/plugin-syntax-dynamic-import'),
-    require.resolve('@babel/plugin-proposal-class-properties'),
-    [
-      '@babel/plugin-transform-runtime',
-      {
-        regenerator: true,
-      },
-    ],
-  ],
+  plugins: [require.resolve('@babel/plugin-proposal-class-properties')],
 };

examples/monaco-graphql-webpack/src/index.ts

@@ -1,7 +1,5 @@
 /* global monaco */
 
-import 'regenerator-runtime/runtime';
-
 import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';
 
 import { api as GraphQLAPI } from 'monaco-graphql';

package.json

@@ -65,8 +65,6 @@
     "@babel/core": "^7.9.0",
     "@babel/node": "^7.8.7",
     "@babel/plugin-proposal-class-properties": "^7.8.3",
-    "@babel/plugin-syntax-dynamic-import": "^7.8.3",
-    "@babel/plugin-transform-runtime": "^7.9.0",
     "@babel/polyfill": "^7.8.7",
     "@babel/preset-env": "7.9.5",
     "@babel/preset-flow": "7.9.0",

packages/graphiql/index.html

@@ -28,11 +28,11 @@
     "build": "yarn build-clean && yarn build-cjs && yarn build-esm",
     "build-cjs": "tsc",
     "build-esm": "tsc --project ./tsconfig.esm.json",
-    "build-clean": "rimraf webpack *.html bundle",
+    "build-clean": "rimraf webpack bundle monaco",
     "build-bundles": "yarn build-bundles-clean && yarn build-bundles-dev && yarn build-bundles-min",
     "build-bundles-dev": "cross-env NODE_ENV=development CDN=1 yarn webpack -d --bail && copy 'resources/renderExample.js' bundle/dev/",
     "build-bundles-min": "cross-env ANALYZE=1 NODE_ENV=production CDN=1 yarn webpack -p --bail && copy 'resources/renderExample.js' bundle/dist/",
-    "build-bundles-clean": "rimraf 'graphiql.*{js,css}' *.html",
+    "build-bundles-clean": "rimraf 'graphiql.*{js,css}'",
     "build-demo": "build-storybook -o ./storybook",
     "dev": "cross-env NODE_ENV=development webpack-dev-server --config resources/webpack.config.js",
     "cypress-open": "yarn e2e-server 'cypress open'",
@@ -53,7 +53,6 @@
     "i18next-browser-languagedetector": "^4.1.1",
     "monaco-editor": "^0.20.0",
     "react-i18next": "^11.4.0",
-    "regenerator-runtime": "^0.13.5",
     "theme-ui": "^0.3.1",
     "@theme-ui/core": "^0.4.0-alpha.1"
   },

packages/graphiql/package.json

@@ -24,7 +24,7 @@ const resultConfig = {
   output: {
     path: isDev ? rootPath('bundle/dev') : rootPath('bundle/dist'),
     // library: 'GraphiQL',
-    libraryTarget: 'umd',
+    libraryTarget: 'window',
     // libraryExport: 'default',
     filename: '[name].js',
     globalObject: 'this',