Skip to content

Commit 833a727

Browse files
committed
add comments
1 parent 0b7115b commit 833a727

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const genSchemaPath =
3131
// this may be cumbersome with offset position assertions but possible
3232
// if we can create consistency that doesn't limit variability
3333
// - convert each it() into a nested describe() block (or a top level describe() in another file), and sprinkle in it() statements to replace comments
34-
// - fix TODO comments where bugs were found that couldn't be resolved quickly (2-4hr timebox)
34+
// - fix TODO comments where bugs were found that couldn't be resolved quickly (2-4hr time box)
3535

3636
describe('MessageProcessor with no config', () => {
3737
afterEach(() => {
@@ -327,7 +327,7 @@ describe('project with simple config and graphql files', () => {
327327
position: { character: 20, line: 17 },
328328
});
329329
expect(schemaDefs[0].uri).toEqual(URI.parse(genSchemaPath).toString());
330-
// note: if the graphiql test schema changes,
330+
// note: if the graphiql test schema changes,
331331
// this might break, please adjust if you see a failure here
332332
expect(serializeRange(schemaDefs[0].range)).toEqual({
333333
start: {
@@ -436,7 +436,10 @@ describe('project with simple config and graphql files', () => {
436436
// 'b/schema.graphql',
437437
// schemaFile[1] + '\ntype Example1 { field: }',
438438
// );
439-
// TODO: this didn't work at all, how to register incomplete changes to model autocomplete, etc?
439+
// TODO: this didn't work at all for multi project,
440+
// whereas a schema change works above in a single schema context as per updating the cache
441+
//
442+
// how to register incomplete changes to model autocomplete, etc?
440443
// await project.lsp.handleWatchedFilesChangedNotification({
441444
// changes: [
442445
// { uri: project.uri('b/schema.graphql'), type: FileChangeType.Changed },

packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { Logger as VSCodeLogger } from 'vscode-jsonrpc';
44
import { URI } from 'vscode-uri';
55
import { FileChangeType } from 'vscode-languageserver';
66
import { FileChangeTypeKind } from 'graphql-language-service';
7-
import { mock } from 'fetch-mock';
87

98
export type MockFile = [filename: string, text: string];
109

@@ -74,6 +73,7 @@ export class MockProject {
7473
loadConfigOptions: { rootDir: root },
7574
});
7675
}
76+
7777
public async init(filename?: string, fileText?: string) {
7878
await this.lsp.handleInitializeRequest({
7979
rootPath: this.root,

0 commit comments

Comments
 (0)