Skip to content

Commit b0b6642

Browse files
committed
docs: prefer function body [skip ci]
1 parent d4157d7 commit b0b6642

File tree

4 files changed

+33
-28
lines changed

4 files changed

+33
-28
lines changed

README.md

Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ const server = http.createServer(async (req, res) => {
6868
url: req.url,
6969
method: req.method,
7070
headers: req.headers,
71-
body: await new Promise((resolve) => {
72-
let body = '';
73-
req.on('data', (chunk) => (body += chunk));
74-
req.on('end', () => resolve(body));
75-
}),
71+
body: () =>
72+
new Promise((resolve) => {
73+
let body = '';
74+
req.on('data', (chunk) => (body += chunk));
75+
req.on('end', () => resolve(body));
76+
}),
7677
raw: req,
7778
});
7879
res.writeHead(init.status, init.statusText, init.headers).end(body);
@@ -119,11 +120,12 @@ const server = http2.createSecureServer(
119120
url: req.url,
120121
method: req.method,
121122
headers: req.headers,
122-
body: await new Promise((resolve) => {
123-
let body = '';
124-
req.on('data', (chunk) => (body += chunk));
125-
req.on('end', () => resolve(body));
126-
}),
123+
body: () =>
124+
new Promise((resolve) => {
125+
let body = '';
126+
req.on('data', (chunk) => (body += chunk));
127+
req.on('end', () => resolve(body));
128+
}),
127129
raw: req,
128130
});
129131
res.writeHead(init.status, init.statusText, init.headers).end(body);
@@ -155,11 +157,12 @@ app.use('/graphql', async (req, res) => {
155157
url: req.url,
156158
method: req.method,
157159
headers: req.headers,
158-
body: await new Promise((resolve) => {
159-
let body = '';
160-
req.on('data', (chunk) => (body += chunk));
161-
req.on('end', () => resolve(body));
162-
}),
160+
body: () =>
161+
new Promise((resolve) => {
162+
let body = '';
163+
req.on('data', (chunk) => (body += chunk));
164+
req.on('end', () => resolve(body));
165+
}),
163166
raw: req,
164167
});
165168
res.writeHead(init.status, init.statusText, init.headers).end(body);
@@ -227,7 +230,7 @@ await serve(
227230
url: req.url,
228231
method: req.method,
229232
headers,
230-
body: await req.text(),
233+
body: () => req.text(),
231234
raw: req,
232235
});
233236
return new Response(body, init);
@@ -686,11 +689,12 @@ const server = http.createServer(async (req, res) => {
686689
url: req.url,
687690
method: req.method,
688691
headers: req.headers,
689-
body: await new Promise((resolve) => {
690-
let body = '';
691-
req.on('data', (chunk) => (body += chunk));
692-
req.on('end', () => resolve(body));
693-
}),
692+
body: () =>
693+
new Promise((resolve) => {
694+
let body = '';
695+
req.on('data', (chunk) => (body += chunk));
696+
req.on('end', () => resolve(body));
697+
}),
694698
raw: req,
695699
});
696700
res.writeHead(init.status, init.statusText, init.headers).end(body);

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ const server = http.createServer(async (req, res) => {
195195
url: req.url,
196196
method: req.method,
197197
headers: req.headers,
198-
body: await new Promise((resolve) => {
198+
body: () => new Promise((resolve) => {
199199
let body = '';
200200
req.on('data', (chunk) => (body += chunk));
201201
req.on('end', () => resolve(body));

src/__tests__/utils/tserver.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,12 @@ export function startTServer(
4444
url: req.url,
4545
method: req.method,
4646
headers: req.headers,
47-
body: await new Promise<string>((resolve) => {
48-
let body = '';
49-
req.on('data', (chunk) => (body += chunk));
50-
req.on('end', () => resolve(body));
51-
}),
47+
body: () =>
48+
new Promise<string>((resolve) => {
49+
let body = '';
50+
req.on('data', (chunk) => (body += chunk));
51+
req.on('end', () => resolve(body));
52+
}),
5253
raw: req,
5354
context: null,
5455
}),

src/handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ export type Handler<RawRequest = unknown, Context = unknown> = (
325325
* url: req.url,
326326
* method: req.method,
327327
* headers: req.headers,
328-
* body: await new Promise((resolve) => {
328+
* body: () => new Promise((resolve) => {
329329
* let body = '';
330330
* req.on('data', (chunk) => (body += chunk));
331331
* req.on('end', () => resolve(body));

0 commit comments

Comments
 (0)