Skip to content

Commit fae7e59

Browse files
enisdenjogithub-actions[bot]
enisdenjo
and
github-actions[bot]
authored
fix(audits/server): JSON parsing errors format shouldnt be audited (#47)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 54fdb10 commit fae7e59

File tree

23 files changed

+113
-247
lines changed

23 files changed

+113
-247
lines changed

‎implementations/apollo-server/README.md

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ _* This report was auto-generated by graphql-http_
22

33
# GraphQL over HTTP audit report
44

5-
- **79** audits in total
5+
- **78** audits in total
66
- ✅ **53** pass
7-
- ⚠️ **26** warnings (optional)
7+
- ⚠️ **25** warnings (optional)
88

99
## Passing
1010
1. SHOULD accept application/graphql-response+json and match the content-type
@@ -1108,28 +1108,4 @@ The server _SHOULD_ support these, but is not required.
11081108
```
11091109
</details>
11101110

1111-
26. SHOULD not contain the data entry on JSON parsing failure when accepting application/graphql-response+json<br />
1112-
1113-
<details>
1114-
<summary>Response body is not valid JSON</summary>
1115-
1116-
```json
1117-
{
1118-
"statusText": "Bad Request",
1119-
"status": 400,
1120-
"headers": {
1121-
"x-powered-by": "Express",
1122-
"x-content-type-options": "nosniff",
1123-
"date": "<timestamp>",
1124-
"content-type": "text/html; charset=utf-8",
1125-
"content-security-policy": "default-src 'none'",
1126-
"content-length": "1108",
1127-
"connection": "close",
1128-
"access-control-allow-origin": "*"
1129-
},
1130-
"body": null
1131-
}
1132-
```
1133-
</details>
1134-
11351111

‎implementations/apollo-server/report.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"total": 79,
2+
"total": 78,
33
"ok": 53,
4-
"warn": 26,
4+
"warn": 25,
55
"error": 0
66
}

‎implementations/deno/README.md

Lines changed: 8 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ _* This report was auto-generated by graphql-http_
22

33
# GraphQL over HTTP audit report
44

5-
- **79** audits in total
5+
- **78** audits in total
66
- ✅ **35** pass
7-
- ⚠️ **44** warnings (optional)
7+
- ⚠️ **43** warnings (optional)
88

99
## Passing
1010
1. MUST accept application/json and match the content-type
@@ -796,27 +796,7 @@ The server _SHOULD_ support these, but is not required.
796796
```
797797
</details>
798798

799-
38. SHOULD not contain the data entry on JSON parsing failure when accepting application/graphql-response+json<br />
800-
801-
<details>
802-
<summary>Response body is not valid JSON</summary>
803-
804-
```json
805-
{
806-
"statusText": "Not Acceptable",
807-
"status": 406,
808-
"headers": {
809-
"vary": "Accept-Encoding",
810-
"date": "<timestamp>",
811-
"content-type": "text/plain;charset=UTF-8",
812-
"content-length": "14"
813-
},
814-
"body": null
815-
}
816-
```
817-
</details>
818-
819-
39. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json<br />
799+
38. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json<br />
820800

821801
<details>
822802
<summary>Response status code is not 400</summary>
@@ -836,7 +816,7 @@ The server _SHOULD_ support these, but is not required.
836816
```
837817
</details>
838818

839-
40. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json<br />
819+
39. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json<br />
840820

841821
<details>
842822
<summary>Response body is not valid JSON</summary>
@@ -856,7 +836,7 @@ The server _SHOULD_ support these, but is not required.
856836
```
857837
</details>
858838

859-
41. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json<br />
839+
40. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json<br />
860840

861841
<details>
862842
<summary>Response status code is not 400</summary>
@@ -876,7 +856,7 @@ The server _SHOULD_ support these, but is not required.
876856
```
877857
</details>
878858

879-
42. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json<br />
859+
41. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json<br />
880860

881861
<details>
882862
<summary>Response body is not valid JSON</summary>
@@ -896,7 +876,7 @@ The server _SHOULD_ support these, but is not required.
896876
```
897877
</details>
898878

899-
43. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json<br />
879+
42. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json<br />
900880

901881
<details>
902882
<summary>Response status code is not 400</summary>
@@ -916,7 +896,7 @@ The server _SHOULD_ support these, but is not required.
916896
```
917897
</details>
918898

919-
44. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json<br />
899+
43. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json<br />
920900

921901
<details>
922902
<summary>Response body is not valid JSON</summary>

‎implementations/deno/report.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"total": 79,
2+
"total": 78,
33
"ok": 35,
4-
"warn": 44,
4+
"warn": 43,
55
"error": 0
66
}

‎implementations/express-graphql/README.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ _* This report was auto-generated by graphql-http_
22

33
# GraphQL over HTTP audit report
44

5-
- **79** audits in total
6-
- ✅ **46** pass
5+
- **78** audits in total
6+
- ✅ **45** pass
77
- ⚠️ **33** warnings (optional)
88

99
## Passing
@@ -43,16 +43,15 @@ _* This report was auto-generated by graphql-http_
4343
34. MUST allow map {extensions} parameter when accepting application/json
4444
35. SHOULD use 4xx or 5xx status codes on JSON parsing failure when accepting application/graphql-response+json
4545
36. SHOULD use 400 status code on JSON parsing failure when accepting application/graphql-response+json
46-
37. SHOULD not contain the data entry on JSON parsing failure when accepting application/graphql-response+json
47-
38. SHOULD use 4xx or 5xx status codes if parameters are invalid when accepting application/graphql-response+json
48-
39. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json
49-
40. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json
50-
41. SHOULD use 4xx or 5xx status codes on document parsing failure when accepting application/graphql-response+json
51-
42. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json
52-
43. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json
53-
44. SHOULD use 4xx or 5xx status codes on document validation failure when accepting application/graphql-response+json
54-
45. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json
55-
46. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json
46+
37. SHOULD use 4xx or 5xx status codes if parameters are invalid when accepting application/graphql-response+json
47+
38. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json
48+
39. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json
49+
40. SHOULD use 4xx or 5xx status codes on document parsing failure when accepting application/graphql-response+json
50+
41. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json
51+
42. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json
52+
43. SHOULD use 4xx or 5xx status codes on document validation failure when accepting application/graphql-response+json
53+
44. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json
54+
45. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json
5655

5756
## Warnings
5857
The server _SHOULD_ support these, but is not required.

‎implementations/express-graphql/report.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"total": 79,
3-
"ok": 46,
2+
"total": 78,
3+
"ok": 45,
44
"warn": 33,
55
"error": 0
66
}

‎implementations/graph-client/README.md

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ _* This report was auto-generated by graphql-http_
22

33
# GraphQL over HTTP audit report
44

5-
- **79** audits in total
6-
- ✅ **79** pass
5+
- **78** audits in total
6+
- ✅ **78** pass
77

88
## Passing
99
1. SHOULD accept application/graphql-response+json and match the content-type
@@ -75,14 +75,13 @@ _* This report was auto-generated by graphql-http_
7575
67. SHOULD use 200 status code on document validation failure when accepting application/json
7676
68. SHOULD use 4xx or 5xx status codes on JSON parsing failure when accepting application/graphql-response+json
7777
69. SHOULD use 400 status code on JSON parsing failure when accepting application/graphql-response+json
78-
70. SHOULD not contain the data entry on JSON parsing failure when accepting application/graphql-response+json
79-
71. SHOULD use 4xx or 5xx status codes if parameters are invalid when accepting application/graphql-response+json
80-
72. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json
81-
73. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json
82-
74. SHOULD use 4xx or 5xx status codes on document parsing failure when accepting application/graphql-response+json
83-
75. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json
84-
76. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json
85-
77. SHOULD use 4xx or 5xx status codes on document validation failure when accepting application/graphql-response+json
86-
78. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json
87-
79. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json
78+
70. SHOULD use 4xx or 5xx status codes if parameters are invalid when accepting application/graphql-response+json
79+
71. SHOULD use 400 status code if parameters are invalid when accepting application/graphql-response+json
80+
72. SHOULD not contain the data entry if parameters are invalid when accepting application/graphql-response+json
81+
73. SHOULD use 4xx or 5xx status codes on document parsing failure when accepting application/graphql-response+json
82+
74. SHOULD use 400 status code on document parsing failure when accepting application/graphql-response+json
83+
75. SHOULD not contain the data entry on document parsing failure when accepting application/graphql-response+json
84+
76. SHOULD use 4xx or 5xx status codes on document validation failure when accepting application/graphql-response+json
85+
77. SHOULD use 400 status code on document validation failure when accepting application/graphql-response+json
86+
78. SHOULD not contain the data entry on document validation failure when accepting application/graphql-response+json
8887

‎implementations/graph-client/report.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"total": 79,
3-
"ok": 79,
2+
"total": 78,
3+
"ok": 78,
44
"warn": 0,
55
"error": 0
66
}

‎implementations/graphql-helix/README.md

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ _* This report was auto-generated by graphql-http_
22

33
# GraphQL over HTTP audit report
44

5-
- **79** audits in total
5+
- **78** audits in total
66
- ✅ **49** pass
7-
- ⚠️ **30** warnings (optional)
7+
- ⚠️ **29** warnings (optional)
88

99
## Passing
1010
1. MUST accept application/json and match the content-type
@@ -785,27 +785,4 @@ The server _SHOULD_ support these, but is not required.
785785
```
786786
</details>
787787

788-
30. SHOULD not contain the data entry on JSON parsing failure when accepting application/graphql-response+json<br />
789-
790-
<details>
791-
<summary>Response body is not valid JSON</summary>
792-
793-
```json
794-
{
795-
"statusText": "Bad Request",
796-
"status": 400,
797-
"headers": {
798-
"x-powered-by": "Express",
799-
"x-content-type-options": "nosniff",
800-
"date": "<timestamp>",
801-
"content-type": "text/html; charset=utf-8",
802-
"content-security-policy": "default-src 'none'",
803-
"content-length": "1108",
804-
"connection": "close"
805-
},
806-
"body": null
807-
}
808-
```
809-
</details>
810-
811788

‎implementations/graphql-helix/report.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"total": 79,
2+
"total": 78,
33
"ok": 49,
4-
"warn": 30,
4+
"warn": 29,
55
"error": 0
66
}

0 commit comments

Comments
 (0)