Skip to content

Commit 25f02fd

Browse files
authored
internal: add type checking for deno dist (#4620)
uncovered errors with TS version in deno in: - #4617 this should robustify our process.
1 parent 3ec8142 commit 25f02fd

File tree

2 files changed

+29
-0
lines changed

2 files changed

+29
-0
lines changed

.github/workflows/ci.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,3 +243,30 @@ jobs:
243243
with:
244244
name: denoDist
245245
path: ./denoDist
246+
247+
type-check-deno-dist:
248+
name: Type check denoDist on Deno v${{ matrix.deno_version_to_setup }}
249+
needs: build-deno-dist
250+
runs-on: ubuntu-latest
251+
strategy:
252+
fail-fast: false
253+
matrix:
254+
# Keep minors pinned to preserve backward-compat coverage; include v2.x
255+
# so CI also exercises the latest Deno release used for publishing.
256+
deno_version_to_setup: [2.4.x, 2.5.x, 2.6.x, 2.7.x, v2.x]
257+
permissions:
258+
contents: read # for actions/download-artifact
259+
steps:
260+
- name: Download denoDist package
261+
uses: actions/download-artifact@v4
262+
with:
263+
name: denoDist
264+
path: ./denoDist
265+
266+
- name: Setup Deno v${{ matrix.deno_version_to_setup }}
267+
uses: denoland/setup-deno@v2
268+
with:
269+
deno-version: ${{ matrix.deno_version_to_setup }}
270+
271+
- name: Check denoDist package
272+
run: deno check ./denoDist/index.ts

resources/integration-test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import { describe, it } from 'mocha';
44

55
import { localRepoPath, makeTmpDir, npm, readPackageJSON } from './utils.js';
66

7+
// Keep these pinned to minimum supported runtime versions so integration
8+
// checks continue to verify backward compatibility behavior.
79
const BUN_VERSION = '1.2.18';
810
const DENO_VERSION = '2.4.1';
911

0 commit comments

Comments
 (0)