Check for valid field arg names

Author: jmandel

src/type/__tests__/validation.js

@@ -353,6 +353,47 @@ describe('Type System: Objects must have fields', () => {
 });
 
 
+describe('Type System: Fields args must be properly named', () => {
+
+  it('accepts field args with valid names', () => {
+    expect(
+      () => schemaWithFieldType(new GraphQLObjectType({
+        name: 'SomeObject',
+        fields: {
+          goodField: {
+            type: GraphQLString,
+            args: {
+              goodArg: { type: GraphQLString }
+            }
+          }
+        }
+      }))
+    ).not.to.throw();
+  });
+
+  it('rejects field arg with invalid names', () => {
+    expect(
+      () => {
+        var QueryType = new GraphQLObjectType({
+          name: 'SomeObject',
+          fields: {
+            badField: {
+              type: GraphQLString,
+              args: {
+                'bad-name-with-dashes': { type: GraphQLString }
+              }
+            }
+          }
+        });
+        return new GraphQLSchema({ query: QueryType });
+      }).to.throw(
+      'Field arg names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "bad-name-with-dashes" does not.'
+    );
+  });
+
+});
+
+
 describe('Type System: Fields args must be objects', () => {
 
   it('accepts an Object type with field args', () => {

src/type/schema.js

@@ -149,6 +149,14 @@ function typeMapReducer(map: TypeMap, type: ?GraphQLType): TypeMap {
       var field = fieldMap[fieldName];
       if (field.args) {
         var fieldArgTypes = field.args.map(arg => arg.type);
+
+        field.args.forEach(arg =>
+          invariant(
+            /^[_a-zA-Z][_a-zA-Z0-9]*$/.test(arg.name),
+            `Field arg names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ ` +
+            `but "${arg.name}" does not.`
+        ));
+
         reducedMap = fieldArgTypes.reduce(typeMapReducer, reducedMap);
       }
       reducedMap = typeMapReducer(reducedMap, field.type);