Drop support for node14 (#3855)

Author: IvanGoncharov

.eslintrc.cjs

@@ -390,7 +390,7 @@ module.exports = {
     'prefer-exponentiation-operator': 'error',
     'prefer-named-capture-group': 'off', // TODO: needs a better support in TS, see https://github.com/microsoft/TypeScript/issues/32098
     'prefer-numeric-literals': 'error',
-    'prefer-object-has-own': 'off', // TODO: requires Node.js v16.9.0
+    'prefer-object-has-own': 'error',
     'prefer-object-spread': 'error',
     'prefer-promise-reject-errors': 'error',
     'prefer-regex-literals': 'error',

.github/workflows/ci.yml

@@ -145,7 +145,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node_version_to_setup: [14, 16, 18]
+        node_version_to_setup: [16, 18, 19]
     permissions:
       contents: read # for actions/checkout
     steps:

package-lock.json

@@ -26,7 +26,7 @@
     "graphql-js"
   ],
   "engines": {
-    "node": "^14.19.0 || ^16.10.0 || ^18.0.0 || >=19.0.0"
+    "node": "^16.19.0 || ^18.14.0 || >=19.7.0"
   },
   "scripts": {
     "preversion": ". ./resources/checkgit.sh && npm ci --ignore-scripts",

package.json

@@ -1,6 +1,6 @@
 {
   "private": true,
   "engines": {
-    "node": ">= 14.0.0"
+    "node": ">= 16.0.0"
   }
 }

resources/eslint-internal-rules/package.json

@@ -92,7 +92,7 @@ function coerceVariableValues(
       continue;
     }
 
-    if (!hasOwnProperty(inputs, varName)) {
+    if (!Object.hasOwn(inputs, varName)) {
       if (varDefNode.defaultValue) {
         coercedValues[varName] = valueFromAST(varDefNode.defaultValue, varType);
       } else if (isNonNullType(varType)) {
@@ -186,7 +186,7 @@ export function getArgumentValues(
       const variableName = valueNode.name.value;
       if (
         variableValues == null ||
-        !hasOwnProperty(variableValues, variableName)
+        !Object.hasOwn(variableValues, variableName)
       ) {
         if (argDef.defaultValue !== undefined) {
           coercedValues[name] = argDef.defaultValue;
@@ -249,7 +249,3 @@ export function getDirectiveValues(
     return getArgumentValues(directiveDef, directiveNode, variableValues);
   }
 }
-
-function hasOwnProperty(obj: unknown, prop: string): boolean {
-  return Object.prototype.hasOwnProperty.call(obj, prop);
-}

src/execution/values.ts

@@ -1449,7 +1449,7 @@ export class Parser {
   parseDirectiveLocation(): NameNode {
     const start = this._lexer.token;
     const name = this.parseName();
-    if (Object.prototype.hasOwnProperty.call(DirectiveLocation, name.value)) {
+    if (Object.hasOwn(DirectiveLocation, name.value)) {
       return name;
     }
     throw this.unexpected(start);

src/language/parser.ts

@@ -7,10 +7,10 @@
   ],
   "compilerOptions": {
     "lib": [
-      "es2020",
+      "es2022",
       "dom" // Workaround for missing web-compatible globals in `@types/node`
     ],
-    "target": "es2020",
+    "target": "es2021",
     "module": "es2022",
     "moduleResolution": "node",
     "noEmit": true,