Skip to content

Commit 94b7e72

Browse files
extendSchema: remove dead check on number of directives (#2309)
`directives` are always array but it can be empty: https://github.com/graphql/graphql-js/blob/2d583c7f5e60853266545628fa71faa7351b1f71/src/type/schema.js#L131 So ATM this statement doesn't check anything.
1 parent 2d583c7 commit 94b7e72

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

src/utilities/extendSchema.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ export function extendSchema(
179179
...operationTypes,
180180
types: objectValues(typeMap),
181181
directives: [
182-
...replaceDirectives(schemaConfig.directives),
182+
...schemaConfig.directives.map(replaceDirective),
183183
...astBuilder.buildDirectives(directiveDefs),
184184
],
185185
astNode: schemaDef || schemaConfig.astNode,
@@ -208,17 +208,11 @@ export function extendSchema(
208208
return ((typeMap[type.name]: any): T);
209209
}
210210

211-
function replaceDirectives(
212-
directives: $ReadOnlyArray<GraphQLDirective>,
213-
): Array<GraphQLDirective> {
214-
devAssert(directives, 'schema must have default directives.');
215-
216-
return directives.map(directive => {
217-
const config = directive.toConfig();
218-
return new GraphQLDirective({
219-
...config,
220-
args: mapValue(config.args, extendArg),
221-
});
211+
function replaceDirective(directive: GraphQLDirective): GraphQLDirective {
212+
const config = directive.toConfig();
213+
return new GraphQLDirective({
214+
...config,
215+
args: mapValue(config.args, extendArg),
222216
});
223217
}
224218

0 commit comments

Comments
 (0)