Sync validation TS definitions with flow (#2119)

Jackson Kearl · IvanGoncharov · commit 9c3e816d727c · 2019-08-24T01:42:39.000+03:00
* Sync tstypes/validation TS definitions with Flow
Note: not tstypes/validation/rules yet

* Sync validation/rules TS with Flow
diff --git a/tstypes/validation/ValidationContext.d.ts b/tstypes/validation/ValidationContext.d.ts
@@ -1,5 +1,6 @@
 import Maybe from '../tsutils/Maybe';
 import { GraphQLError } from '../error';
+import { ASTVisitor } from '../language/visitor';
 import {
   DocumentNode,
   OperationDefinitionNode,
@@ -9,16 +10,15 @@ import {
   FragmentDefinitionNode,
 } from '../language/ast';
 import { GraphQLSchema } from '../type/schema';
+import { GraphQLDirective } from '../type/directives';
 import {
   GraphQLInputType,
   GraphQLOutputType,
   GraphQLCompositeType,
   GraphQLField,
   GraphQLArgument,
 } from '../type/definition';
-import { GraphQLDirective } from '../type/directives';
 import { TypeInfo } from '../utilities/TypeInfo';
-import { ASTVisitor } from '../language/visitor';
 
 type NodeWithSelectionSet = OperationDefinitionNode | FragmentDefinitionNode;
 type VariableUsage = {
@@ -40,35 +40,44 @@ export class ASTValidationContext {
   getErrors(): ReadonlyArray<GraphQLError>;
 
   getDocument(): DocumentNode;
+
+  getFragment(name: string): Maybe<FragmentDefinitionNode>;
+
+  getFragmentSpreads(node: SelectionSetNode): ReadonlyArray<FragmentSpreadNode>;
+
+  getRecursivelyReferencedFragments(
+    operation: OperationDefinitionNode,
+  ): ReadonlyArray<FragmentDefinitionNode>;
 }
 
 export class SDLValidationContext extends ASTValidationContext {
-  constructor(ast: DocumentNode, schema?: Maybe<GraphQLSchema>);
+  constructor(
+    ast: DocumentNode,
+    schema: Maybe<GraphQLSchema>,
+    onError?: (err: GraphQLError) => void,
+  );
 
   getSchema(): Maybe<GraphQLSchema>;
 }
 
 export type SDLValidationRule = (context: SDLValidationContext) => ASTVisitor;
 
 export class ValidationContext extends ASTValidationContext {
-  constructor(schema: GraphQLSchema, ast: DocumentNode, typeInfo: TypeInfo);
+  constructor(
+    schema: GraphQLSchema,
+    ast: DocumentNode,
+    typeInfo: TypeInfo,
+    onError?: (err: GraphQLError) => void,
+  );
 
   getSchema(): GraphQLSchema;
 
-  getFragment(name: string): Maybe<FragmentDefinitionNode>;
-
-  getFragmentSpreads(node: SelectionSetNode): ReadonlyArray<FragmentSpreadNode>;
+  getVariableUsages(node: NodeWithSelectionSet): ReadonlyArray<VariableUsage>;
 
   getRecursivelyReferencedFragments(
     operation: OperationDefinitionNode,
   ): ReadonlyArray<FragmentDefinitionNode>;
 
-  getVariableUsages(node: NodeWithSelectionSet): ReadonlyArray<VariableUsage>;
-
-  getRecursiveVariableUsages(
-    operation: OperationDefinitionNode,
-  ): ReadonlyArray<VariableUsage>;
-
   getType(): Maybe<GraphQLOutputType>;
 
   getParentType(): Maybe<GraphQLCompositeType>;
diff --git a/tstypes/validation/rules/ExecutableDefinitions.d.ts b/tstypes/validation/rules/ExecutableDefinitions.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function nonExecutableDefinitionMessage(defName: string): string;
 
diff --git a/tstypes/validation/rules/FieldsOnCorrectType.d.ts b/tstypes/validation/rules/FieldsOnCorrectType.d.ts
@@ -1,5 +1,12 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
+
+export function undefinedFieldMessage(
+  fieldName: string,
+  type: string,
+  suggestedTypeNames: ReadonlyArray<string>,
+  suggestedFieldNames: ReadonlyArray<string>,
+): string;
 
 /**
  * Fields on correct type
diff --git a/tstypes/validation/rules/FragmentsOnCompositeTypes.d.ts b/tstypes/validation/rules/FragmentsOnCompositeTypes.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function inlineFragmentOnNonCompositeErrorMessage(type: string): string;
 
diff --git a/tstypes/validation/rules/KnownArgumentNames.d.ts b/tstypes/validation/rules/KnownArgumentNames.d.ts
@@ -5,13 +5,13 @@ export function unknownArgMessage(
   argName: string,
   fieldName: string,
   typeName: string,
-  suggestedArgs: Array<string>,
+  suggestedArgs: ReadonlyArray<string>,
 ): string;
 
 export function unknownDirectiveArgMessage(
   argName: string,
   directiveName: string,
-  suggestedArgs: Array<string>,
+  suggestedArgs: ReadonlyArray<string>,
 ): string;
 
 /**
diff --git a/tstypes/validation/rules/KnownDirectives.d.ts b/tstypes/validation/rules/KnownDirectives.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext, SDLValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext, SDLValidationContext } from '../ValidationContext';
 
 export function unknownDirectiveMessage(directiveName: string): string;
 
diff --git a/tstypes/validation/rules/KnownFragmentNames.d.ts b/tstypes/validation/rules/KnownFragmentNames.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function unknownFragmentMessage(fragName: string): string;
 
diff --git a/tstypes/validation/rules/KnownTypeNames.d.ts b/tstypes/validation/rules/KnownTypeNames.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function unknownTypeMessage(
   typeName: string,
diff --git a/tstypes/validation/rules/LoneAnonymousOperation.d.ts b/tstypes/validation/rules/LoneAnonymousOperation.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function anonOperationNotAloneMessage(): string;
 
diff --git a/tstypes/validation/rules/LoneSchemaDefinition.d.ts b/tstypes/validation/rules/LoneSchemaDefinition.d.ts
@@ -1,5 +1,5 @@
-import { SDLValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
 
 export function schemaDefinitionNotAloneMessage(): string;
 
diff --git a/tstypes/validation/rules/NoFragmentCycles.d.ts b/tstypes/validation/rules/NoFragmentCycles.d.ts
@@ -1,9 +1,9 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function cycleErrorMessage(
   fragName: string,
-  spreadNames: Array<string>,
+  spreadNames: ReadonlyArray<string>,
 ): string;
 
 export function NoFragmentCycles(context: ValidationContext): ASTVisitor;
diff --git a/tstypes/validation/rules/NoUndefinedVariables.d.ts b/tstypes/validation/rules/NoUndefinedVariables.d.ts
@@ -1,6 +1,6 @@
 import Maybe from '../../tsutils/Maybe';
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function undefinedVarMessage(
   varName: string,
diff --git a/tstypes/validation/rules/NoUnusedFragments.d.ts b/tstypes/validation/rules/NoUnusedFragments.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function unusedFragMessage(fragName: string): string;
 
diff --git a/tstypes/validation/rules/NoUnusedVariables.d.ts b/tstypes/validation/rules/NoUnusedVariables.d.ts
@@ -1,6 +1,6 @@
 import Maybe from '../../tsutils/Maybe';
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function unusedVariableMessage(
   varName: string,
diff --git a/tstypes/validation/rules/OverlappingFieldsCanBeMerged.d.ts b/tstypes/validation/rules/OverlappingFieldsCanBeMerged.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function fieldsConflictMessage(
   responseName: string,
diff --git a/tstypes/validation/rules/PossibleFragmentSpreads.d.ts b/tstypes/validation/rules/PossibleFragmentSpreads.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function typeIncompatibleSpreadMessage(
   fragName: string,
diff --git a/tstypes/validation/rules/PossibleTypeExtensions.d.ts b/tstypes/validation/rules/PossibleTypeExtensions.d.ts
@@ -0,0 +1,21 @@
+import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
+
+export function extendingUnknownTypeMessage(
+  typeName: string,
+  suggestedTypes: $ReadOnlyArray<string>,
+): string;
+
+export function extendingDifferentTypeKindMessage(
+  typeName: string,
+  kind: string,
+): string;
+
+/**
+ * Possible type extension
+ *
+ * A type extension is only valid if the type is defined and has the same kind.
+ */
+export function PossibleTypeExtensions(
+  context: SDLValidationContext,
+): ASTVisitor;
diff --git a/tstypes/validation/rules/ProvidedRequiredArguments.d.ts b/tstypes/validation/rules/ProvidedRequiredArguments.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext, SDLValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext, SDLValidationContext } from '../ValidationContext';
 
 export function missingFieldArgMessage(
   fieldName: string,
diff --git a/tstypes/validation/rules/ScalarLeafs.d.ts b/tstypes/validation/rules/ScalarLeafs.d.ts
@@ -1,5 +1,5 @@
-import { ValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ValidationContext } from '../ValidationContext';
 
 export function noSubselectionAllowedMessage(
   fieldName: string,
diff --git a/tstypes/validation/rules/SingleFieldSubscriptions.d.ts b/tstypes/validation/rules/SingleFieldSubscriptions.d.ts
@@ -1,6 +1,6 @@
 import Maybe from '../../tsutils/Maybe';
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function singleFieldOnlyMessage(name: Maybe<string>): string;
 
diff --git a/tstypes/validation/rules/UniqueArgumentNames.d.ts b/tstypes/validation/rules/UniqueArgumentNames.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateArgMessage(argName: string): string;
 
diff --git a/tstypes/validation/rules/UniqueDirectiveNames.d.ts b/tstypes/validation/rules/UniqueDirectiveNames.d.ts
@@ -0,0 +1,13 @@
+import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
+
+export function duplicateDirectiveNameMessage(directiveName: string): string;
+
+export function existedDirectiveNameMessage(directiveName: string): string;
+
+/**
+ * Unique directive names
+ *
+ * A GraphQL document is only valid if all defined directives have unique names.
+ */
+export function UniqueDirectiveNames(context: SDLValidationContext): ASTVisitor;
diff --git a/tstypes/validation/rules/UniqueDirectivesPerLocation.d.ts b/tstypes/validation/rules/UniqueDirectivesPerLocation.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateDirectiveMessage(directiveName: string): string;
 
diff --git a/tstypes/validation/rules/UniqueEnumValueNames.d.ts b/tstypes/validation/rules/UniqueEnumValueNames.d.ts
@@ -0,0 +1,19 @@
+import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
+
+export function duplicateEnumValueNameMessage(
+  typeName: string,
+  valueName: string,
+): string;
+
+export function existedEnumValueNameMessage(
+  typeName: string,
+  valueName: string,
+): string;
+
+/**
+ * Unique enum value names
+ *
+ * A GraphQL enum type is only valid if all its values are uniquely named.
+ */
+export function UniqueEnumValueNames(context: SDLValidationContext): ASTVisitor;
diff --git a/tstypes/validation/rules/UniqueFieldDefinitionNames.d.ts b/tstypes/validation/rules/UniqueFieldDefinitionNames.d.ts
@@ -0,0 +1,21 @@
+import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
+
+export function duplicateFieldDefinitionNameMessage(
+  typeName: string,
+  fieldName: string,
+): string;
+
+export function existedFieldDefinitionNameMessage(
+  typeName: string,
+  fieldName: string,
+): string;
+
+/**
+ * Unique field definition names
+ *
+ * A GraphQL complex type is only valid if all its fields are uniquely named.
+ */
+export function UniqueFieldDefinitionNames(
+  context: SDLValidationContext,
+): ASTVisitor;
diff --git a/tstypes/validation/rules/UniqueFragmentNames.d.ts b/tstypes/validation/rules/UniqueFragmentNames.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateFragmentNameMessage(fragName: string): string;
 
diff --git a/tstypes/validation/rules/UniqueInputFieldNames.d.ts b/tstypes/validation/rules/UniqueInputFieldNames.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateInputFieldMessage(fieldName: string): string;
 
diff --git a/tstypes/validation/rules/UniqueOperationNames.d.ts b/tstypes/validation/rules/UniqueOperationNames.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateOperationNameMessage(operationName: string): string;
 
diff --git a/tstypes/validation/rules/UniqueOperationTypes.d.ts b/tstypes/validation/rules/UniqueOperationTypes.d.ts
@@ -0,0 +1,13 @@
+import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
+
+export function duplicateOperationTypeMessage(operation: string): string;
+
+export function existedOperationTypeMessage(operation: string): string;
+
+/**
+ * Unique operation types
+ *
+ * A GraphQL document is only valid if it has only one type per operation.
+ */
+export function UniqueOperationTypes(context: SDLValidationContext): ASTVisitor;
diff --git a/tstypes/validation/rules/UniqueTypeNames.d.ts b/tstypes/validation/rules/UniqueTypeNames.d.ts
@@ -0,0 +1,13 @@
+import { ASTVisitor } from '../../language/visitor';
+import { SDLValidationContext } from '../ValidationContext';
+
+export function duplicateTypeNameMessage(typeName: string): string;
+
+export function existedTypeNameMessage(typeName: string): string;
+
+/**
+ * Unique type names
+ *
+ * A GraphQL document is only valid if all defined types have unique names.
+ */
+export function UniqueTypeNames(context: SDLValidationContext): ASTVisitor;
diff --git a/tstypes/validation/rules/UniqueVariableNames.d.ts b/tstypes/validation/rules/UniqueVariableNames.d.ts
@@ -1,5 +1,5 @@
-import { ASTValidationContext } from '../ValidationContext';
 import { ASTVisitor } from '../../language/visitor';
+import { ASTValidationContext } from '../ValidationContext';
 
 export function duplicateVariableMessage(variableName: string): string;
 
diff --git a/tstypes/validation/rules/ValuesOfCorrectType.d.ts b/tstypes/validation/rules/ValuesOfCorrectType.d.ts
diff --git a/tstypes/validation/rules/VariablesAreInputTypes.d.ts b/tstypes/validation/rules/VariablesAreInputTypes.d.ts
diff --git a/tstypes/validation/rules/VariablesInAllowedPosition.d.ts b/tstypes/validation/rules/VariablesInAllowedPosition.d.ts
diff --git a/tstypes/validation/specifiedRules.d.ts b/tstypes/validation/specifiedRules.d.ts
diff --git a/tstypes/validation/validate.d.ts b/tstypes/validation/validate.d.ts
