use enableDevMode() or development condition instead of NODE_ENV

yaacovCR · yaacovCR · commit a732e3ded7cc · 2025-07-29T22:44:31.000+03:00
diff --git a/cspell.yml b/cspell.yml
@@ -68,8 +68,10 @@ words:
   - deno
   - denoland
   - hashbang
-  - Rspack
   - Rollup
+  - Rspack
+  - Rsbuild
+  - Turbopack
 
   # Website tech
   - Nextra
diff --git a/integrationTests/README.md b/integrationTests/README.md
@@ -20,7 +20,7 @@ The `conditions` subdirectory contains tests that verify the conditional exports
 
 ### Verifying Development Mode Tests
 
-Each subdirectory represents a different environment/bundler demonstrating enabling development mode by setting the environment variable `NODE_ENV` to `development`.
+Each subdirectory represents a different platform/bundler demonstrating enabling development mode by enabling the `development` condition or by calling `enableDevMode()`.
 
 ### Verifying Production Mode Tests
 
diff --git a/integrationTests/dev-bun/package.json b/integrationTests/dev-bun/package.json
@@ -2,7 +2,7 @@
   "description": "graphql-js development mode should work with Bun",
   "private": true,
   "scripts": {
-    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun test.js"
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun --conditions=development test.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz"
diff --git a/integrationTests/dev-bun/test.js b/integrationTests/dev-bun/test.js
@@ -1,4 +1,6 @@
-import { isObjectType } from 'graphql';
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
 
 class GraphQLObjectType {
   get [Symbol.toStringTag]() {
diff --git a/integrationTests/dev-deno-condition-based/package.json b/integrationTests/dev-deno-condition-based/package.json
@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js condition-based development mode should work with Deno",
+  "private": true,
+  "scripts": {
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:latest deno run --conditions=development --allow-env=NODE_ENV test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}
diff --git a/integrationTests/dev-deno-condition-based/test.js b/integrationTests/dev-deno-condition-based/test.js
@@ -9,7 +9,7 @@ class GraphQLObjectType {
 try {
   isObjectType(new GraphQLObjectType());
   throw new Error(
-    'Expected isObjectType to throw an error in Deno implicit dev mode.',
+    'Expected isObjectType to throw an error in Deno condition-based development mode.',
   );
 } catch (error) {
   if (!error.message.includes('from another module or realm')) {
diff --git a/integrationTests/dev-deno-explicit/package.json b/integrationTests/dev-deno-explicit/package.json
@@ -1,5 +1,5 @@
 {
-  "description": "graphql-js development mode should work with Deno",
+  "description": "graphql-js explicit development mode should work with Deno",
   "private": true,
   "scripts": {
     "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:alpine-\"$DENO_VERSION\" deno run --allow-env=NODE_ENV test.js"
diff --git a/integrationTests/dev-deno-explicit/test.js b/integrationTests/dev-deno-explicit/test.js
@@ -0,0 +1,20 @@
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit development mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}
diff --git a/integrationTests/dev-esbuild/package.json b/integrationTests/dev-esbuild/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm",
+    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm --conditions=development",
     "test": "npm run build && node dist/bundle.js"
   },
   "dependencies": {
diff --git a/integrationTests/dev-jest/jest.config.js b/integrationTests/dev-jest/jest.config.js
@@ -0,0 +1,22 @@
+const jestConfig = {
+  testEnvironment: 'node',
+
+  testEnvironmentOptions: {
+    customExportConditions: ['development'],
+  },
+
+  transform: {
+    '^.+\\.(t|j)sx?$': ['@swc/jest'],
+  },
+
+  transformIgnorePatterns: [
+    // Allow 'graphql' to be transformed, ignore all other node_modules.
+    // This regex means: "match /node_modules/ unless it's followed by graphql/"
+    '/node_modules/(?!graphql/)',
+    // Keep Jest's default for .pnp.js files if using Yarn PnP
+    '\\.pnp\\.[^\\/]+$',
+  ],
+};
+
+// eslint-disable-next-line no-restricted-exports, import/no-default-export
+export default jestConfig;
diff --git a/integrationTests/dev-jest/package.json b/integrationTests/dev-jest/package.json
@@ -1,5 +1,5 @@
 {
-  "description": "graphql-js development mode should work with Jest",
+  "description": "graphql-js development mode should work with Jest and SWC",
   "private": true,
   "type": "module",
   "scripts": {
@@ -9,6 +9,8 @@
     "graphql": "file:../graphql.tgz"
   },
   "devDependencies": {
-    "jest": "^29.7.0"
+    "jest": "^29.7.0",
+    "@swc/core": "^1.6.0",
+    "@swc/jest": "^0.2.36"
   }
 }
diff --git a/integrationTests/dev-node-condition-based/package.json b/integrationTests/dev-node-condition-based/package.json
@@ -0,0 +1,11 @@
+{
+  "description": "graphql-js condition-based development mode should work with node",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "test": "node --conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}
diff --git a/integrationTests/dev-node-condition-based/test.js b/integrationTests/dev-node-condition-based/test.js
@@ -9,7 +9,7 @@ class GraphQLObjectType {
 try {
   isObjectType(new GraphQLObjectType());
   throw new Error(
-    'Expected isObjectType to throw an error in Node.js implicit dev mode.',
+    'Expected isObjectType to throw an error in Node.js condition-based development mode.',
   );
 } catch (error) {
   if (!error.message.includes('from another module or realm')) {
diff --git a/integrationTests/dev-node-explicit/package.json b/integrationTests/dev-node-explicit/package.json
@@ -1,5 +1,5 @@
 {
-  "description": "graphql-js development mode should work with node",
+  "description": "graphql-js explicit development mode should work with node",
   "private": true,
   "type": "module",
   "scripts": {
diff --git a/integrationTests/dev-node-explicit/test.js b/integrationTests/dev-node-explicit/test.js
@@ -0,0 +1,20 @@
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Node.js development mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}
diff --git a/integrationTests/dev-rollup/package.json b/integrationTests/dev-rollup/package.json
@@ -8,6 +8,7 @@
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz",
-    "rollup": "^4.0.0"
+    "rollup": "^4.0.0",
+    "@rollup/plugin-node-resolve": "^15.0.0"
   }
 }
diff --git a/integrationTests/dev-rollup/rollup.config.js b/integrationTests/dev-rollup/rollup.config.js
@@ -1,9 +1,17 @@
+// eslint-disable-next-line n/no-missing-import
+import resolve from '@rollup/plugin-node-resolve';
+
 const rollupConfig = {
   input: 'index.js',
   output: {
     file: 'dist/bundle.js',
     format: 'es',
   },
+  plugins: [
+    resolve({
+      exportConditions: ['development'],
+    }),
+  ],
 };
 
 // eslint-disable-next-line no-restricted-exports, import/no-default-export
diff --git a/integrationTests/dev-rspack/rspack.config.js b/integrationTests/dev-rspack/rspack.config.js
@@ -11,6 +11,9 @@ const rspack = {
   },
   mode: 'development',
   target: 'node',
+  resolve: {
+    conditionNames: ['development'],
+  },
 };
 
 // eslint-disable-next-line no-restricted-exports, import/no-default-export
diff --git a/integrationTests/dev-swc/index.js b/integrationTests/dev-swc/index.js
@@ -1,4 +1,6 @@
-import { isObjectType } from 'graphql';
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
 
 class GraphQLObjectType {
   get [Symbol.toStringTag]() {
diff --git a/integrationTests/dev-vitest/vitest.config.js b/integrationTests/dev-vitest/vitest.config.js
@@ -2,6 +2,9 @@
 import { defineConfig } from 'vitest/config';
 
 const vitestConfig = defineConfig({
+  resolve: {
+    conditions: ['development'],
+  },
   test: {
     include: ['**/*.test.js'],
   },
diff --git a/integrationTests/dev-webpack/webpack.config.js b/integrationTests/dev-webpack/webpack.config.js
@@ -11,6 +11,9 @@ const webpackConfig = {
   },
   mode: 'development',
   target: 'node',
+  resolve: {
+    conditionNames: ['development'],
+  },
 };
 
 // eslint-disable-next-line no-restricted-exports, import/no-default-export
diff --git a/integrationTests/prod-bun/package.json b/integrationTests/prod-bun/package.json
@@ -2,7 +2,7 @@
   "description": "graphql-js production mode should work with Bun",
   "private": true,
   "scripts": {
-    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun --define process.env.NODE_ENV='\"production\"' test.js"
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun test.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz"
diff --git a/integrationTests/prod-deno/env-shim.js b/integrationTests/prod-deno/env-shim.js
diff --git a/integrationTests/prod-deno/package.json b/integrationTests/prod-deno/package.json
@@ -2,7 +2,7 @@
   "description": "graphql-js production mode should work with Deno",
   "private": true,
   "scripts": {
-    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:alpine-\"$DENO_VERSION\" deno run --allow-env --preload env-shim.js test.js"
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:alpine-\"$DENO_VERSION\" deno run test.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz"
diff --git a/integrationTests/prod-esbuild/package.json b/integrationTests/prod-esbuild/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm --define:process.env.NODE_ENV='\"production\"'",
+    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm",
     "test": "npm run build && node dist/bundle.js"
   },
   "dependencies": {
diff --git a/integrationTests/prod-node/package.json b/integrationTests/prod-node/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "test": "NODE_ENV=production node test.js"
+    "test": "node test.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz"
diff --git a/integrationTests/prod-rollup/package.json b/integrationTests/prod-rollup/package.json
@@ -9,7 +9,6 @@
   "dependencies": {
     "graphql": "file:../graphql.tgz",
     "rollup": "^4.0.0",
-    "@rollup/plugin-node-resolve": "^15.0.0",
-    "@rollup/plugin-replace": "^5.0.0"
+    "@rollup/plugin-node-resolve": "^15.0.0"
   }
 }
diff --git a/integrationTests/prod-rollup/rollup.config.js b/integrationTests/prod-rollup/rollup.config.js
@@ -1,22 +1,9 @@
-// eslint-disable-next-line n/no-missing-import
-import resolve from '@rollup/plugin-node-resolve';
-// eslint-disable-next-line n/no-missing-import
-import replace from '@rollup/plugin-replace';
-
 const rollupConfig = {
   input: 'index.js',
   output: {
     file: 'dist/bundle.js',
     format: 'es',
   },
-  plugins: [
-    replace({
-      preventAssignment: true,
-      'process.env.NODE_ENV': JSON.stringify('production'),
-      include: ['node_modules/graphql/**'],
-    }),
-    resolve(),
-  ],
 };
 
 // eslint-disable-next-line no-restricted-exports, import/no-default-export
diff --git a/integrationTests/prod-swc/package.json b/integrationTests/prod-swc/package.json
@@ -4,7 +4,7 @@
   "type": "module",
   "scripts": {
     "build": "swc index.js -d dist",
-    "test": "npm run build && NODE_ENV=production node dist/index.js"
+    "test": "npm run build && node dist/index.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz",
diff --git a/resources/build-npm.ts b/resources/build-npm.ts
diff --git a/resources/integration-test.ts b/resources/integration-test.ts
diff --git a/resources/utils.ts b/resources/utils.ts
diff --git a/src/__tests__/devMode-test.ts b/src/__tests__/devMode-test.ts
diff --git a/src/devMode.ts b/src/devMode.ts
diff --git a/src/index.ts b/src/index.ts
diff --git a/src/jsutils/__tests__/instanceOf-test.ts b/src/jsutils/__tests__/instanceOf-test.ts
diff --git a/src/jsutils/instanceOf.ts b/src/jsutils/instanceOf.ts
diff --git a/website/pages/docs/_meta.ts b/website/pages/docs/_meta.ts
diff --git a/website/pages/docs/development-mode.mdx b/website/pages/docs/development-mode.mdx
diff --git a/website/pages/docs/going-to-production.mdx b/website/pages/docs/going-to-production.mdx
diff --git a/website/pages/upgrade-guides/v16-v17.mdx b/website/pages/upgrade-guides/v16-v17.mdx

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "description": "graphql-js development mode should work with Deno",`
	`2`	`+ "description": "graphql-js explicit development mode should work with Deno",`
`3`	`3`	`"private": true,`
`4`	`4`	`"scripts": {`
`5`	`5`	`"test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:alpine-\"$DENO_VERSION\" deno run --allow-env=NODE_ENV test.js"`