Flow: switch more types to be exact (#2269)

Author: IvanGoncharov

.eslintrc.yml

@@ -26,7 +26,7 @@ rules:
   flowtype/no-unused-expressions: off
   flowtype/no-weak-types: [error, { any: false }]
   flowtype/require-compound-type-alias: off
-  flowtype/require-exact-type: off # TODO
+  flowtype/require-exact-type: off
   flowtype/require-indexer-name: error
   flowtype/require-inexact-type: off # checked by Flow
   flowtype/require-parameter-type: off

src/language/parser.js

@@ -62,7 +62,7 @@ import {
 /**
  * Configuration options to control parser behavior
  */
-export type ParseOptions = {
+export type ParseOptions = {|
   /**
    * By default, the parser creates AST nodes that know the location
    * in the source that they correspond to. This configuration flag
@@ -107,9 +107,7 @@ export type ParseOptions = {
    * future.
    */
   experimentalFragmentVariables?: boolean,
-
-  ...
-};
+|};
 
 /**
  * Given a GraphQL source, parses it into a Document.
@@ -177,7 +175,12 @@ class Parser {
     );
 
     this._lexer = new Lexer(sourceObj);
-    this._options = options || {};
+    this._options = options || {
+      noLocation: false,
+      allowLegacySDLEmptyFields: false,
+      allowLegacySDLImplementsInterfaces: false,
+      experimentalFragmentVariables: false,
+    };
   }
 
   /**

src/utilities/buildASTSchema.js

@@ -75,7 +75,7 @@ import {
 
 import { valueFromAST } from './valueFromAST';
 
-export type BuildSchemaOptions = {
+export type BuildSchemaOptions = {|
   ...GraphQLSchemaValidationOptions,
 
   /**
@@ -94,9 +94,7 @@ export type BuildSchemaOptions = {
    * Default: false
    */
   assumeValidSDL?: boolean,
-
-  ...
-};
+|};
 
 /**
  * This takes the ast of a schema document produced by the parse function in
@@ -525,7 +523,21 @@ function getLeadingCommentBlock(node): void | string {
  */
 export function buildSchema(
   source: string | Source,
-  options?: BuildSchemaOptions & ParseOptions,
+  options?: {| ...BuildSchemaOptions, ...ParseOptions |},
 ): GraphQLSchema {
-  return buildASTSchema(parse(source, options), options);
+  const document = parse(source, {
+    noLocation: (options && options.noLocation) || false,
+    allowLegacySDLEmptyFields:
+      (options && options.allowLegacySDLEmptyFields) || false,
+    allowLegacySDLImplementsInterfaces:
+      (options && options.allowLegacySDLImplementsInterfaces) || false,
+    experimentalFragmentVariables:
+      (options && options.experimentalFragmentVariables) || false,
+  });
+
+  return buildASTSchema(document, {
+    commentDescriptions: (options && options.commentDescriptions) || false,
+    assumeValidSDL: (options && options.assumeValidSDL) || false,
+    assumeValid: (options && options.assumeValid) || false,
+  });
 }