Skip to content

Commit d06c883

Browse files
committed
Fix tests for node v0.10, widen test matrix
1 parent 188881b commit d06c883

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
language: node_js
22

33
node_js:
4-
- "stable"
4+
- "6"
5+
- "5"
56
- "4"
67
- "iojs"
78
- "0.12"

src/utilities/isValidJSValue.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,20 +65,21 @@ export function isValidJSValue(value: mixed, type: GraphQLInputType): [string] {
6565
const errors = [];
6666

6767
// Ensure every provided field is defined.
68-
for (const providedField of Object.keys(value)) {
68+
Object.keys(value).forEach(providedField => {
6969
if (!fields[providedField]) {
7070
errors.push(`In field "${providedField}": Unknown field.`);
7171
}
72-
}
72+
});
7373

7474
// Ensure every defined field is valid.
75-
for (const fieldName of Object.keys(fields)) {
75+
Object.keys(fields).forEach(fieldName => {
7676
const newErrors =
77-
isValidJSValue(value[fieldName], fields[fieldName].type);
77+
isValidJSValue((value: any)[fieldName], fields[fieldName].type);
7878
errors.push(...(newErrors.map(error =>
7979
`In field "${fieldName}": ${error}`
8080
)));
81-
}
81+
});
82+
8283
return errors;
8384
}
8485

src/utilities/isValidLiteralValue.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,25 +85,25 @@ export function isValidLiteralValue(
8585

8686
// Ensure every provided field is defined.
8787
const fieldASTs = (valueAST: ObjectValue).fields;
88-
for (const providedFieldAST of fieldASTs) {
88+
fieldASTs.forEach(providedFieldAST => {
8989
if (!fields[providedFieldAST.name.value]) {
9090
errors.push(
9191
`In field "${providedFieldAST.name.value}": Unknown field.`
9292
);
9393
}
94-
}
94+
});
9595

9696
// Ensure every defined field is valid.
9797
const fieldASTMap = keyMap(fieldASTs, fieldAST => fieldAST.name.value);
98-
for (const fieldName of Object.keys(fields)) {
98+
Object.keys(fields).forEach(fieldName => {
9999
const result = isValidLiteralValue(
100100
fields[fieldName].type,
101101
fieldASTMap[fieldName] && fieldASTMap[fieldName].value
102102
);
103103
errors.push(...(result.map(error =>
104104
`In field "${fieldName}": ${error}`
105105
)));
106-
}
106+
});
107107

108108
return errors;
109109
}

0 commit comments

Comments
 (0)