Skip to content

Commit e1c59a4

Browse files
committed
Make unknown field errors uniform with other errors
1 parent 98364f6 commit e1c59a4

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/utilities/isValidJSValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export function isValidJSValue(value: any, type: GraphQLInputType): [ string ] {
6868
// Ensure every provided field is defined.
6969
for (var providedField of Object.keys(value)) {
7070
if (!fields[providedField]) {
71-
errors.push('Unknown field "${providedField}".');
71+
errors.push('In field "${providedField}": Unknown field.');
7272
}
7373
}
7474

src/utilities/isValidLiteralValue.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ export function isValidLiteralValue(
8888
var fieldASTs = (valueAST: ObjectValue).fields;
8989
for (var providedFieldAST of fieldASTs) {
9090
if (!fields[providedFieldAST.name.value]) {
91-
errors.push(`Unknown field "${providedFieldAST.name.value}".`);
91+
errors.push(
92+
`In field "${providedFieldAST.name.value}": Unknown field.`
93+
);
9294
}
9395
}
9496

src/validation/__tests__/ArgumentsOfCorrectType.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,7 @@ describe('Validate: Argument values of correct type', () => {
782782
'{requiredField: true, unknownField: "value"}',
783783
4,
784784
41,
785-
[ 'Unknown field "unknownField".' ]
785+
[ 'In field "unknownField": Unknown field.' ]
786786
),
787787
]);
788788
});

0 commit comments

Comments
 (0)