Mark 'config' as readonly argument to contructors (#2312)

Author: IvanGoncharov

src/type/definition.d.ts

@@ -292,7 +292,7 @@ export class GraphQLScalarType {
   astNode: Maybe<ScalarTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<ScalarTypeExtensionNode>>;
 
-  constructor(config: GraphQLScalarTypeConfig<any, any>);
+  constructor(config: Readonly<GraphQLScalarTypeConfig<any, any>>);
 
   toConfig(): GraphQLScalarTypeConfig<any, any> & {
     serialize: GraphQLScalarSerializer<any>;
@@ -381,7 +381,9 @@ export class GraphQLObjectType<
   astNode: Maybe<ObjectTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<ObjectTypeExtensionNode>>;
 
-  constructor(config: GraphQLObjectTypeConfig<TSource, TContext, TArgs>);
+  constructor(
+    config: Readonly<GraphQLObjectTypeConfig<TSource, TContext, TArgs>>,
+  );
   getFields(): GraphQLFieldMap<any, TContext, TArgs>;
   getInterfaces(): GraphQLInterfaceType[];
 
@@ -560,7 +562,7 @@ export class GraphQLInterfaceType {
   astNode?: Maybe<InterfaceTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<InterfaceTypeExtensionNode>>;
 
-  constructor(config: GraphQLInterfaceTypeConfig<any, any>);
+  constructor(config: Readonly<GraphQLInterfaceTypeConfig<any, any>>);
   getFields(): GraphQLFieldMap<any, any>;
   getInterfaces(): GraphQLInterfaceType[];
 
@@ -628,7 +630,7 @@ export class GraphQLUnionType {
   astNode: Maybe<UnionTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<UnionTypeExtensionNode>>;
 
-  constructor(config: GraphQLUnionTypeConfig<any, any>);
+  constructor(config: Readonly<GraphQLUnionTypeConfig<any, any>>);
   getTypes(): GraphQLObjectType[];
 
   toConfig(): GraphQLUnionTypeConfig<any, any> & {
@@ -685,7 +687,7 @@ export class GraphQLEnumType {
   astNode: Maybe<EnumTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<EnumTypeExtensionNode>>;
 
-  constructor(config: GraphQLEnumTypeConfig);
+  constructor(config: Readonly<GraphQLEnumTypeConfig>);
   getValues(): GraphQLEnumValue[];
   getValue(name: string): Maybe<GraphQLEnumValue>;
   serialize(value: any): Maybe<string>;
@@ -763,7 +765,7 @@ export class GraphQLInputObjectType {
   astNode: Maybe<InputObjectTypeDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<InputObjectTypeExtensionNode>>;
 
-  constructor(config: GraphQLInputObjectTypeConfig);
+  constructor(config: Readonly<GraphQLInputObjectTypeConfig>);
   getFields(): GraphQLInputFieldMap;
 
   toConfig(): GraphQLInputObjectTypeConfig & {

src/type/definition.js

@@ -553,7 +553,7 @@ export class GraphQLScalarType {
   astNode: ?ScalarTypeDefinitionNode;
   extensionASTNodes: ?$ReadOnlyArray<ScalarTypeExtensionNode>;
 
-  constructor(config: GraphQLScalarTypeConfig<mixed, mixed>): void {
+  constructor(config: $ReadOnly<GraphQLScalarTypeConfig<mixed, mixed>>): void {
     const parseValue = config.parseValue || identityFunc;
     this.name = config.name;
     this.description = config.description;
@@ -678,7 +678,7 @@ export class GraphQLObjectType {
   _fields: Thunk<GraphQLFieldMap<any, any>>;
   _interfaces: Thunk<Array<GraphQLInterfaceType>>;
 
-  constructor(config: GraphQLObjectTypeConfig<any, any>): void {
+  constructor(config: $ReadOnly<GraphQLObjectTypeConfig<any, any>>): void {
     this.name = config.name;
     this.description = config.description;
     this.isTypeOf = config.isTypeOf;
@@ -739,9 +739,10 @@ defineToStringTag(GraphQLObjectType);
 defineToJSON(GraphQLObjectType);
 
 function defineInterfaces(
-  config:
+  config: $ReadOnly<
     | GraphQLObjectTypeConfig<mixed, mixed>
     | GraphQLInterfaceTypeConfig<mixed, mixed>,
+  >,
 ): Array<GraphQLInterfaceType> {
   const interfaces = resolveThunk(config.interfaces) || [];
   devAssert(
@@ -752,9 +753,10 @@ function defineInterfaces(
 }
 
 function defineFieldMap<TSource, TContext>(
-  config:
+  config: $ReadOnly<
     | GraphQLObjectTypeConfig<TSource, TContext>
     | GraphQLInterfaceTypeConfig<TSource, TContext>,
+  >,
 ): GraphQLFieldMap<TSource, TContext> {
   const fieldMap = resolveThunk(config.fields) || {};
   devAssert(
@@ -983,7 +985,7 @@ export class GraphQLInterfaceType {
   _fields: Thunk<GraphQLFieldMap<any, any>>;
   _interfaces: Thunk<Array<GraphQLInterfaceType>>;
 
-  constructor(config: GraphQLInterfaceTypeConfig<any, any>): void {
+  constructor(config: $ReadOnly<GraphQLInterfaceTypeConfig<any, any>>): void {
     this.name = config.name;
     this.description = config.description;
     this.resolveType = config.resolveType;
@@ -1092,7 +1094,7 @@ export class GraphQLUnionType {
 
   _types: Thunk<Array<GraphQLObjectType>>;
 
-  constructor(config: GraphQLUnionTypeConfig<any, any>): void {
+  constructor(config: $ReadOnly<GraphQLUnionTypeConfig<any, any>>): void {
     this.name = config.name;
     this.description = config.description;
     this.resolveType = config.resolveType;
@@ -1143,7 +1145,7 @@ defineToStringTag(GraphQLUnionType);
 defineToJSON(GraphQLUnionType);
 
 function defineTypes(
-  config: GraphQLUnionTypeConfig<mixed, mixed>,
+  config: $ReadOnly<GraphQLUnionTypeConfig<mixed, mixed>>,
 ): Array<GraphQLObjectType> {
   const types = resolveThunk(config.types) || [];
   devAssert(
@@ -1200,7 +1202,7 @@ export class GraphQLEnumType /* <T> */ {
   _valueLookup: Map<any /* T */, GraphQLEnumValue>;
   _nameLookup: ObjMap<GraphQLEnumValue>;
 
-  constructor(config: GraphQLEnumTypeConfig /* <T> */): void {
+  constructor(config: $ReadOnly<GraphQLEnumTypeConfig /* <T> */>): void {
     this.name = config.name;
     this.description = config.description;
     this.extensions = config.extensions && toObjMap(config.extensions);
@@ -1374,7 +1376,7 @@ export class GraphQLInputObjectType {
 
   _fields: Thunk<GraphQLInputFieldMap>;
 
-  constructor(config: GraphQLInputObjectTypeConfig): void {
+  constructor(config: $ReadOnly<GraphQLInputObjectTypeConfig>): void {
     this.name = config.name;
     this.description = config.description;
     this.extensions = config.extensions && toObjMap(config.extensions);
@@ -1426,7 +1428,7 @@ defineToStringTag(GraphQLInputObjectType);
 defineToJSON(GraphQLInputObjectType);
 
 function defineInputFieldMap(
-  config: GraphQLInputObjectTypeConfig,
+  config: $ReadOnly<GraphQLInputObjectTypeConfig>,
 ): GraphQLInputFieldMap {
   const fieldMap = resolveThunk(config.fields) || {};
   devAssert(

src/type/directives.d.ts

@@ -21,7 +21,7 @@ export class GraphQLDirective {
   extensions: Maybe<Readonly<Record<string, any>>>;
   astNode: Maybe<DirectiveDefinitionNode>;
 
-  constructor(config: GraphQLDirectiveConfig);
+  constructor(config: Readonly<GraphQLDirectiveConfig>);
 
   toConfig(): GraphQLDirectiveConfig & {
     args: GraphQLFieldConfigArgumentMap;

src/type/directives.js

@@ -61,7 +61,7 @@ export class GraphQLDirective {
   extensions: ?ReadOnlyObjMap<mixed>;
   astNode: ?DirectiveDefinitionNode;
 
-  constructor(config: GraphQLDirectiveConfig): void {
+  constructor(config: $ReadOnly<GraphQLDirectiveConfig>): void {
     this.name = config.name;
     this.description = config.description;
     this.locations = config.locations;

src/type/schema.d.ts

@@ -46,7 +46,7 @@ export class GraphQLSchema {
   astNode: Maybe<SchemaDefinitionNode>;
   extensionASTNodes: Maybe<ReadonlyArray<SchemaExtensionNode>>;
 
-  constructor(config: GraphQLSchemaConfig);
+  constructor(config: Readonly<GraphQLSchemaConfig>);
   getQueryType(): Maybe<GraphQLObjectType>;
   getMutationType(): Maybe<GraphQLObjectType>;
   getSubscriptionType(): Maybe<GraphQLObjectType>;

src/type/schema.js

@@ -135,7 +135,7 @@ export class GraphQLSchema {
   // Used as a cache for validateSchema().
   __validationErrors: ?$ReadOnlyArray<GraphQLError>;
 
-  constructor(config: GraphQLSchemaConfig): void {
+  constructor(config: $ReadOnly<GraphQLSchemaConfig>): void {
     // If this schema was built from a source known to be valid, then it may be
     // marked with assumeValid to avoid an additional type system validation.
     if (config && config.assumeValid) {