First draft for upgrade guide to v17 #4310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
yaacovCR
reviewed
Jan 30, 2025
|
@JoviDeCroock I have started working on merging in what I have been tracking in #4198 ... these are a few suggestions so far, let me know if you'd rather have me open up PRs to this PR rather than do it like this. |
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
6652fda to
1c1fa22
Compare
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
1c1fa22 to
0301509
Compare
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
0301509 to
edf1802
Compare
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
edf1802 to
0b835b3
Compare
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
0b835b3 to
b1d1e2d
Compare
yaacovCR
reviewed
Feb 16, 2025
Co-authored-by: Yaacov Rydzinski <[email protected]>
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
b1f64bc to
6d49a35
Compare
JoviDeCroock
force-pushed
the
v17-upgrade-guide
branch
from
6d49a35 to
baa39f1
Compare
yaacovCR
reviewed
Feb 17, 2025
yaacovCR
reviewed
Feb 17, 2025
yaacovCR
reviewed
Feb 17, 2025
yaacovCR
reviewed
Feb 17, 2025
yaacovCR
reviewed
Feb 17, 2025
yaacovCR
reviewed
Feb 17, 2025
Closed #4198, added the remainder of items from that PR as review comments. Let me know if you would just prefer a PR into this PR. |
Co-Authored-By: yaacovcr <[email protected]>
benjie
reviewed
Feb 20, 2025
| that you are working with externally provided values i.e. the SDL provided defaultValue to a variable. | ||
| - Deprecated `valueFromAST` use `coerceInputLiteral` instead | ||
| - Deprecated `findBreakingChanges()` and `findDangerousChanges()`. Use `findSchemaChanges()` instead, which can also be used to find safe changes. | ||
| - Deprecated `serialize`. `parseValue`, and `parseLiteral` properties on scalar type configuration. Use `coerceOutputValue`, `coerceInputValue`, and `coerceInputLiteral` instead. |
There was a problem hiding this comment.
Is this simply a rename or is more work required?
benjie
reviewed
Feb 20, 2025
|
|
||
| - Added `hideSuggestions` option to `execute`/`validate`/`subscribe`/... to hide schema-suggestions in error messages | ||
| - Added `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods; | ||
| the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate. |
There was a problem hiding this comment.
“Can also be” - how? Should this be “is also”? Also, is it via resolveinfo?
JoviDeCroock
added a commit
that referenced
this pull request
May 4, 2025
Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 27, 2025
Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR
added a commit
that referenced
this pull request
May 30, 2025
Co-authored-by: Yaacov Rydzinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.