docs: anatomy of a resolver #4381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
reviewed
Apr 27, 2025
saihaj
approved these changes
Apr 29, 2025
|
Thanks for approving :) Feel free to merge whenever! @saihaj let me know if there is a specific process to get merge permissions |
JoviDeCroock
approved these changes
May 3, 2025
JoviDeCroock
pushed a commit
that referenced
this pull request
May 4, 2025
adds anatomy of a resolver guide This is a part of the effort to expand GraphQL.js documentation
benjie
reviewed
May 14, 2025
| - Use context effectively. Store shared per-request information, such as | ||
| authentication data or database connections, in the `context` object rather | ||
| than passing it manually between resolvers. | ||
| - Prefer batching over nested requests. For fields that trigger multiple |
There was a problem hiding this comment.
Prefer batching over nested requests.
It's not totally clear to me what this sentence means?
benjie
added a commit
that referenced
this pull request
May 14, 2025
benjie
added a commit
that referenced
this pull request
May 21, 2025
Relevant to these PRs: - #4380 - #4381 - #4382 - #4383 - #4391 In general this content was excellent - thanks @sarahxsanders! - but I wanted to add a few minor updates. I've included comments in a few places with reasoning. If this PR is too much to review all at once, I'm happy to break it up as I did review of each PR separately.
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 27, 2025
adds anatomy of a resolver guide This is a part of the effort to expand GraphQL.js documentation
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
May 27, 2025
Relevant to these PRs: - graphql#4380 - graphql#4381 - graphql#4382 - graphql#4383 - graphql#4391 In general this content was excellent - thanks @sarahxsanders! - but I wanted to add a few minor updates. I've included comments in a few places with reasoning. If this PR is too much to review all at once, I'm happy to break it up as I did review of each PR separately.
yaacovCR
pushed a commit
that referenced
this pull request
May 30, 2025
adds anatomy of a resolver guide This is a part of the effort to expand GraphQL.js documentation
yaacovCR
pushed a commit
that referenced
this pull request
May 30, 2025
Relevant to these PRs: - #4380 - #4381 - #4382 - #4383 - #4391 In general this content was excellent - thanks @sarahxsanders! - but I wanted to add a few minor updates. I've included comments in a few places with reasoning. If this PR is too much to review all at once, I'm happy to break it up as I did review of each PR separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds anatomy of a resolver guide
This is a part of the effort to expand GraphQL.js documentation