Skip to content

Clarify comment about mutually exclusive parents #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Clarify comment about mutually exclusive parents #2901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/validation/rules/OverlappingFieldsCanBeMergedRule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,9 +551,13 @@ function findConflict(
// in aliased field or arguments used as they will not present any ambiguity
// by differing.
// It is known that two parent types could never overlap if they are
// different Object types. Interface or Union types might overlap - if not
// different Object types. Interface types might overlap - if not
// in the current state of the schema, then perhaps in some future version,
// thus may not safely diverge.
// thus may not safely diverge.
// The only field that can have a Union as parent is __typename which can't
// conflict as it is a Scalar with no arguments. Therefore the condition
// could be arguably changed to "isObjectOrUnionType", but this implementation
// follows the current spec.
const areMutuallyExclusive =
parentFieldsAreMutuallyExclusive ||
(parentType1 !== parentType2 &&
Expand Down