Skip to content

Commit 4ef4346

Browse files
committed
fix auto completion
1 parent 3bea9dd commit 4ef4346

File tree

4 files changed

+15
-32
lines changed

4 files changed

+15
-32
lines changed

packages/graphql-playground-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
"calculate-size": "^1.1.1",
121121
"classnames": "^2.2.5",
122122
"codemirror": "^5.27.4",
123-
"codemirror-graphql": "0.6.12",
123+
"codemirror-graphql": "git+ssh://[email protected]/timsuchanek/codemirror-graphql.git#details-fix",
124124
"copy-to-clipboard": "^3.0.8",
125125
"cuid": "^1.3.8",
126126
"graphcool-styles": "0.2.7",

packages/graphql-playground-react/src/components/Playground/SchemaFetcher.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ export class SchemaFetcher {
6767
* DANGER! THIS IS AN EXTREME HACK. As soon, as codemirror-graphql doesn't use getType in .hint anymore
6868
* this can be removed.
6969
*/
70-
const oldGetType = schema.getType
71-
schema.getType = type => {
72-
const getTypeResult = oldGetType.call(schema, type)
73-
return getTypeResult || type
74-
}
70+
// const oldGetType = schema.getType
71+
// schema.getType = type => {
72+
// const getTypeResult = oldGetType.call(schema, type)
73+
// return getTypeResult || type
74+
// }
7575
const tracingSupported =
7676
(schemaData.extensions && Boolean(schemaData.extensions.tracing)) ||
7777
false

packages/graphql-playground-react/src/components/Playground/onHasCompletion.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,10 @@ export default function onHasCompletion(cm, data, onHintInformationRender) {
9393
const description = ctx.description
9494
? marked(ctx.description, { sanitize: true })
9595
: ''
96-
const type = ctx.type
97-
? '<span class="infoType">' + renderType(ctx.type) + '</span>'
98-
: ''
96+
const type =
97+
ctx.type && ctx.type !== 'undefined'
98+
? '<span class="infoType">' + renderType(ctx.type) + '</span>'
99+
: ''
99100

100101
information.innerHTML =
101102
'<div class="content">' +

packages/graphql-playground-react/yarn.lock

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1764,12 +1764,12 @@ code-point-at@^1.0.0:
17641764
version "1.1.0"
17651765
resolved "https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77"
17661766

1767-
[email protected].12, codemirror-graphql@^0.6.11:
1767+
codemirror-graphql@^0.6.11, "codemirror-graphql@git+ssh://[email protected]/timsuchanek/codemirror-graphql.git#details-fix":
17681768
version "0.6.12"
1769-
resolved "https://registry.yarnpkg.com/codemirror-graphql/-/codemirror-graphql-0.6.12.tgz#91a273fe5188857524a30221d06e645b4ca41f00"
1769+
resolved "git+ssh://git@github.com/timsuchanek/codemirror-graphql.git#801ec32683c38d6dc0f8f7bc19014a111edc9ebd"
17701770
dependencies:
1771-
graphql-language-service-interface "^1.0.16"
1772-
graphql-language-service-parser "^0.1.14"
1771+
graphql-language-service-interface "^1.0.18"
1772+
graphql-language-service-parser "^1.0.18"
17731773

17741774
codemirror@^5.18.2, codemirror@^5.26.0, codemirror@^5.27.4:
17751775
version "5.33.0"
@@ -3419,7 +3419,7 @@ graphql-import@^0.4.0:
34193419
graphql "^0.12.3"
34203420
lodash "^4.17.4"
34213421

3422-
graphql-language-service-interface@^1.0.16:
3422+
graphql-language-service-interface@^1.0.18:
34233423
version "1.0.18"
34243424
resolved "https://registry.yarnpkg.com/graphql-language-service-interface/-/graphql-language-service-interface-1.0.18.tgz#c0fc1ef72c6f6f4bf9042bd7a8a8a66e0772caa8"
34253425
dependencies:
@@ -3428,23 +3428,13 @@ graphql-language-service-interface@^1.0.16:
34283428
graphql-language-service-types "^1.0.18"
34293429
graphql-language-service-utils "^1.0.18"
34303430

3431-
graphql-language-service-parser@^0.1.14:
3432-
version "0.1.14"
3433-
resolved "https://registry.yarnpkg.com/graphql-language-service-parser/-/graphql-language-service-parser-0.1.14.tgz#dd25abda5dcff4f2268c9a19e026004271491661"
3434-
dependencies:
3435-
graphql-language-service-types "^0.1.14"
3436-
34373431
graphql-language-service-parser@^1.0.18:
34383432
version "1.0.18"
34393433
resolved "https://registry.yarnpkg.com/graphql-language-service-parser/-/graphql-language-service-parser-1.0.18.tgz#80fe714f244fc81bc0352d0008ecafdf8fa75fe8"
34403434
dependencies:
34413435
graphql-config "1.1.4"
34423436
graphql-language-service-types "^1.0.18"
34433437

3444-
graphql-language-service-types@^0.1.14:
3445-
version "0.1.14"
3446-
resolved "https://registry.yarnpkg.com/graphql-language-service-types/-/graphql-language-service-types-0.1.14.tgz#e6112785fc23ea8222f59a7f00e61b359f263c88"
3447-
34483438
graphql-language-service-types@^1.0.18:
34493439
version "1.0.18"
34503440
resolved "https://registry.yarnpkg.com/graphql-language-service-types/-/graphql-language-service-types-1.0.18.tgz#0c9ebb6dd7babd61bf6b3bea0675abde5d7e5b16"
@@ -6617,14 +6607,6 @@ query-string@^4.1.0:
66176607
object-assign "^4.1.0"
66186608
strict-uri-encode "^1.0.0"
66196609

6620-
query-string@^5.1.0:
6621-
version "5.1.0"
6622-
resolved "https://registry.yarnpkg.com/query-string/-/query-string-5.1.0.tgz#9583b15fd1307f899e973ed418886426a9976469"
6623-
dependencies:
6624-
decode-uri-component "^0.2.0"
6625-
object-assign "^4.1.0"
6626-
strict-uri-encode "^1.0.0"
6627-
66286610
querystring-es3@^0.2.0:
66296611
version "0.2.1"
66306612
resolved "https://registry.yarnpkg.com/querystring-es3/-/querystring-es3-0.2.1.tgz#9ec61f79049875707d69414596fd907a4d711e73"

0 commit comments

Comments
 (0)