Skip to content

Commit 6e6f16b

Browse files
authored
Merge pull request #90 from guigrpa/master
Use UTF-8 instead of ASCII for base64 conversion
2 parents d374b43 + c9bac2e commit 6e6f16b

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

src/utils/__tests__/base64.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import { describe, it } from 'mocha';
2+
import { expect } from 'chai';
3+
4+
import {
5+
base64,
6+
unbase64
7+
} from '../base64';
8+
9+
var exampleUtf8 = 'Some examples: ❤😀';
10+
var exampleBase64 = 'U29tZSBleGFtcGxlczog4p2k8J+YgA==';
11+
12+
describe('base64 conversion', () => {
13+
it('converts from utf-8 to base64', () => {
14+
return expect(base64(exampleUtf8)).to.equal(exampleBase64);
15+
});
16+
17+
it('converts from base64 to utf-8', () => {
18+
return expect(unbase64(exampleBase64)).to.equal(exampleUtf8);
19+
});
20+
});

src/utils/base64.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
export type Base64String = string;
1212

1313
export function base64(i: string): Base64String {
14-
return ((new Buffer(i, 'ascii')).toString('base64'));
14+
return ((new Buffer(i, 'utf8')).toString('base64'));
1515
}
1616

1717
export function unbase64(i: Base64String): string {
18-
return ((new Buffer(i, 'base64')).toString('ascii'));
18+
return ((new Buffer(i, 'base64')).toString('utf8'));
1919
}

0 commit comments

Comments
 (0)