-
Notifications
You must be signed in to change notification settings - Fork 9
Add spec for Long custom scalar type
#26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jakobmerrild
wants to merge
5
commits into
graphql:main
Choose a base branch
from
jakobmerrild:add-spec-for-long-scalar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
66fb671
Add spec for `Long` custom scalar type
jakobmerrild 086bfff
Update scalars/contributed/jakobmerrild/long.md
jakobmerrild efeab84
Update scalars/contributed/jakobmerrild/long.md
jakobmerrild e20ed45
Update wording of Long spec
jakobmerrild 28ba686
Update Long spec to not allow strings for input
jakobmerrild File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <!-- cspell:ignore <github user name> --> | ||
|
|
||
| # Long — GraphQL Custom Scalar | ||
|
|
||
| Author - jakobmerrild | ||
|
|
||
| Date - 2024-12-16 | ||
|
|
||
| **License and Copyright** | ||
|
|
||
| Copyright © GraphQL contributors. This specification is licensed under | ||
| [OWFa 1.0](https://www.openwebfoundation.org/the-agreements/the-owf-1-0-agreements-granted-claims/owfa-1-0). | ||
|
|
||
| # Overview | ||
|
|
||
| This scalar represents a 64-bit signed integer (non-fractional) value, ranging from `-2^63` to `2^63-1`. ``` | ||
|
|
||
| # Name | ||
|
|
||
| The scalar should be named `Long` to match commonly used names for the same data structure in a variety of programming languages. | ||
| Alternatively the scalar can be named `Int64` to represent the 64-bit encoding. | ||
|
|
||
| # Result coercion | ||
|
|
||
| A field of type `Long` should result in a `number` without a fractional or exponential part. A leading `-` should only be | ||
| added if the field represents a negative value. | ||
|
|
||
| These are valid examples: | ||
|
|
||
| | Output | Explanation | | ||
| | ---------------------- | -------------------------------------------------------------- | | ||
| | `0` | Zero is a valid integer within the range | | ||
| | `-9223372036854775808` | This is the lowest value that can be represented in the range | | ||
| | `9223372036854775807` | This is the largest value that can be represented in the range | | ||
|
|
||
| These are invalid examples: | ||
|
|
||
| | Output | Explanation | | ||
| | ----------------------- | ------------------------------------------------------------------------ | | ||
| | `+1234` | Leading `+` is not allowed | | ||
| | `-10223372036854775808` | Value is lower than `-2^63` | | ||
| | `12223372036854775807` | Value is greater than `2^63-1` | | ||
| | `123.0` | Fractional part is not allowed even if it is zero | | ||
| | `1e6` | Exponential notation is not allowed, even if it represents a valid value | | ||
| | `"12345"` | String representations of a valid value are not allowed | | ||
|
|
||
| # Input coercion | ||
|
|
||
| For input `number` values shall be accepted so long as they fall within the range represented by the spec. | ||
|
|
||
| These are valid examples: | ||
|
|
||
| | Input | Explanation | | ||
| | ---------------------- | ------------------------------------------------------------------------- | | ||
| | `0` | IntValue within range | | ||
| | `-9223372036854775808` | This is the lowest value that can be represented in the range | | ||
| | `9223372036854775807` | This is the largest value that can be represented in the range | | ||
|
|
||
| These are invalid examples: | ||
|
|
||
| | Output | Explanation | | ||
| | ----------------------- | ---------------------------------------------------------------------------------------------------------------------------- | | ||
| | `-10223372036854775808` | Value is lower than `-2^63` | | ||
| | `12223372036854775807` | Value is greater than `2^63-1` | | ||
| | `123.0` | FloatValue is not allowed | | ||
| | `"FFFFF"` | A StringValue containing a base-16 representation of a valid value is not allowed | | ||
| | `"6543.000"` | A StringValue containing a base-10 representation with a fractional part is not allowed. Even if the fractional part is zero | | ||
| | `"987654321"` | A StringValue containing a base-10 representation of the value is not allowed | | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.