Do not exclude schema keyword if schema has description #1167
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaelstaib
approved these changes
May 19, 2025
mjmahone
approved these changes
May 20, 2025
enisdenjo
approved these changes
May 20, 2025
PascalSenn
approved these changes
May 21, 2025
martinbonnin
approved these changes
May 28, 2025
BoD
approved these changes
Jun 5, 2025
leebyron
added
📄 Draft (RFC 2)
|
Jumping to RFC2 - waiting on GraphQL.js unit tests to confirm this behavior |
|
GraphQL.js test passes: graphql/graphql-js#4441 |
yaacovCR
pushed a commit
to graphql/graphql-js
that referenced
this pull request
Jun 26, 2025
leebyron
added
🏁 Accepted (RFC 3)
leebyron
approved these changes
Jun 26, 2025
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix; previously we said that the
schemakeyword can/should be omitted if the root operation type names line up, but we neglected to think about the schema description. This fixes that.Trivial fix @graphql/tsc
(Discussed as part of #1166, but since there's pushback to the naked schema keyword I'm separating this out into its own standalone fix.)