Skip to content

Commit b3d32a6

Browse files
authored
Clarify C relates to nullability of unadorned type (#1659)
1 parent 2a09600 commit b3d32a6

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

β€Ž.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
agendas/*/*.md
22
agendas/*/*/*.md
3+
rfcs/SemanticNullability.md

β€Žrfcs/SemanticNullability.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,11 +242,11 @@ same meaning as they always did.
242242

243243
Criteria score: πŸ₯‡
244244

245-
## 🎯 C. Existing meanings should be retained
245+
## 🎯 C. Unadorned type should mean nullable
246246

247247
GraphQL has been public for 10 years and there's a lot of content out there
248248
noting that GraphQL types are nullable by default (unadorned type is nullable)
249-
and that `!` means non-nullable. Our changes should not invalidate this content.
249+
and our changes should not invalidate this content.
250250

251251
| [1][solution-1] | [2][solution-2] | [3][solution-3] | [4][solution-4] | [5][solution-5] |
252252
|-----------------|-----------------|-----------------|-----------------|-----------------|
@@ -488,7 +488,7 @@ day-to-day work.
488488
- [B][criteria-b]
489489
- βœ… Executable documents are not impacted by this proposal.
490490
- [C][criteria-c]
491-
- βœ… `Int` means nullable, and `Int!` means non-nullable, still.
491+
- βœ… `Int` means nullable still.
492492
- [D][criteria-d]
493493
- βœ… `Int!` to indicate non-nullable is common in programming languages; and
494494
`Int!!` looks like it indicates "danger".
@@ -560,7 +560,7 @@ This proposal relies on the ability of clients to opt out of error propagation;
560560
- [B][criteria-b]
561561
- βœ… The change from nullable to non-nullable on output is backwards compatible from a type perspective; for impact on error boundaries see G.
562562
- [C][criteria-c]
563-
- βœ… `Int` means nullable, and `Int!` means non-nullable, still.
563+
- βœ… `Int` means nullable still.
564564
- [D][criteria-d]
565565
- ⚠️ Adding `@onError` to operations is not immediately intuitive but most error-handling clients should add it automatically, making it transparent to end users.
566566
- [E][criteria-e]

0 commit comments

Comments
Β (0)