tests + code to ts

Author: gagoar

.flowconfig

@@ -7,12 +7,13 @@ module.exports = {
   name: packageJSON.name,
   displayName: packageJSON.name,
   transform: {
-    '\\.[jt]sx?$': 'babel-jest',
+    '^.+\\.[jt]sx?$': 'ts-jest',
   },
+  preset: 'ts-jest',
   moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
   testURL: 'http://localhost',
   transformIgnorePatterns: ['[/\\\\]node_modules[/\\\\].+\\.(js|jsx)$'],
-  testMatch: ['**/*.(spec|test).js'],
+  testMatch: ['**/*.(spec|test).[jt]s'],
   collectCoverage: true,
   coverageDirectory: './coverage/',
 };

jest.config.js

@@ -17,6 +17,17 @@
   "engines": {
     "node": ">=6.0.0"
   },
+  "eslintConfig": {
+    "extends": [
+      "plugin:@typescript-eslint/recommended",
+      "prettier",
+      "prettier/@typescript-eslint"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+      "project": "./tsconfig.eslint.json"
+    }
+  },
   "browserify": {
     "transform": [
       "babelify"
@@ -29,18 +40,17 @@
     "postinstall": "npm run download && npm run build",
     "start": "node lib/server",
     "watch": "babel scripts/watch.js | node",
-    "test": "npm run lint && npm run check && npm run test:only",
+    "test": "npm run lint && npm run test:only",
     "test:only": "jest",
     "lint": "eslint src handler",
     "lint:fix": "eslint --fix src handler",
-    "check": "flow check",
     "cover": "babel-node node_modules/.bin/isparta cover --root src --report html node_modules/.bin/_mocha -- $npm_package_options_mocha",
     "coveralls": "babel-node node_modules/.bin/isparta cover --root src --report lcovonly node_modules/.bin/_mocha -- $npm_package_options_mocha && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js",
     "build": "rimraf lib && babel src --ignore __tests__,public --out-dir lib/ && npm run build:lambda",
     "build:lambda": "NODE_ENV=development netlify-lambda build handler",
     "download": "babel-node scripts/download.js cache/data.json",
     "serve-public": "babel-node scripts/serve-public",
-    "prettier": "prettier --write 'src/**/*.js'",
+    "prettier": "prettier --write 'src/**/*.ts'",
     "print-schema": "babel-node scripts/print-schema.js",
     "store-schema": "babel-node scripts/store-schema.js"
   },
@@ -52,10 +62,12 @@
     "express": "^4.17.1",
     "express-graphql": "^0.9.0",
     "graphql": "14.5.8",
-    "graphql-relay": "0.6.0"
+    "graphql-relay": "^0.6.0"
   },
   "devDependencies": {
     "@babel/core": "^7.12.3",
+    "@types/graphql-relay": "^0.6.0",
+    "@types/jest": "^26.0.15",
     "babel-cli": "^6.26.0",
     "babel-core": "^6.26.3",
     "babel-eslint": "^10.0.3",
@@ -77,6 +89,8 @@
     "jest": "^26.6.3",
     "netlify-lambda": "^1.6.3",
     "prettier": "^1.18.2",
-    "sane": "^4.1.0"
+    "sane": "^4.1.0",
+    "ts-jest": "^26.4.4",
+    "typescript": "^4.1.2"
   }
 }

package-lock.json

@@ -39,7 +39,7 @@ async function cacheResources() {
   for (const name of resources) {
     let url = `https://swapi.dev/api/${name}/`;
 
-    while (url != null) {
+    while (url !== null) {
       console.error(url);
       const response = await fetch(url, { agent });
       const text = await response.text();

package.json

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 /**
  * Copyright (c) 2020, GraphQL Contributors
  * All rights reserved.
@@ -12,7 +13,7 @@ import { printSchema } from 'graphql/utilities';
 import { writeFileSync } from 'fs';
 
 try {
-  var output = printSchema(swapiSchema);
+  const output = printSchema(swapiSchema);
   writeFileSync('schema.graphql', output, 'utf8');
 } catch (error) {
   console.error(error);

scripts/download.js

@@ -8,16 +8,23 @@
  * @flow strict
  */
 
-import swapiData from '../../cache/data';
+import swapiData from '../../cache/data.json';
 
 /**
  * Given a URL of an object in the SWAPI, return the data
  * from our local cache.
  */
+// casting json file to a Record with Index. 
+const typedSwapiData = swapiData as typeof swapiData & { [key: string]: any }
 export async function getFromLocalUrl(
-  url: string,
-): Promise<{ [key: string]: any }> {
-  const text = swapiData[url];
+  url: unknown,
+): Promise<Record<string, any>> {
+
+  if (!(typeof url === 'string')) {
+    throw new Error('Url provided is not a string');
+  }
+
+  const text = typedSwapiData[url];
   if (!text) {
     throw new Error(`No entry in local cache for ${url}`);
   }