isProc: recognize builtin-commands (denisenkom#252)

* mssql: recognize builtin-commands

* Update mssql_test.go

* .golangci: fixed version in the config

Author: giautm

.golangci.yml

@@ -1,9 +1,9 @@
+version: "2"
 linters:
   enable:
     # basic go linters
-    - gofmt
-    - golint
     - govet
+    - revive # replacing golint as it is deprecated
 
     # sql related linters
     - rowserrcheck

mssql.go

@@ -563,6 +563,10 @@ func (s *Stmt) sendQuery(ctx context.Context, args []namedValue) (err error) {
 	return
 }
 
+// Builtin commands are not stored procs, but rather T-SQL commands
+// those commands can be invoke without extra options
+var builtinCommands = []string{"RECONFIGURE", "SHUTDOWN", "CHECKPOINT"}
+
 // isProc takes the query text in s and determines if it is a stored proc name
 // or SQL text.
 func isProc(s string) bool {
@@ -621,6 +625,12 @@ func isProc(s string) bool {
 			}
 		}
 	}
+	s = strings.ToUpper(s)
+	for _, cmd := range builtinCommands {
+		if s == cmd {
+			return false
+		}
+	}
 	return true
 }
 

mssql_test.go

@@ -48,6 +48,9 @@ func TestIsProc(t *testing.T) {
 		{"--proc", false},
 		{"[proc;]", true},
 		{" proc", false},
+		{"RECONFIGURE", false},
+		{"SHUTDOWN", false},
+		{"CHECKPOINT", false},
 	}
 
 	for _, item := range list {