Skip to content

Proposal: abandon ChartKitSettings and use props instead #488

@vrozaev

Description

@vrozaev

Right now chartkit using ChartKitSettings singleton class for it's settings.

This might lead to a bug when developer trying to set several plugins in different modules;

// Module 1
settings.set({plugins: [YagrPlugin]});

// Module 2 
settings.set({plugins: [MyAmazingPlugin]});  

This code above might lead to error - one plugin will be overwrited with another, and chart will now be shown.

Proposal: lets pass chartkit settings to the chartkit as props.

<ChartKit type="d3" settings={settings} data={data} />

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions