Skip to content

Commit 8077294

Browse files
NasgulNexusNasgulNexus
committed
feat: eslint add rules import type and order
1 parent fcf6372 commit 8077294

File tree

224 files changed

+3353
-2690
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

224 files changed

+3353
-2690
lines changed

‎.eslintrc‎

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,34 @@
22
"extends": [
33
"@gravity-ui/eslint-config",
44
"@gravity-ui/eslint-config/prettier",
5-
"@gravity-ui/eslint-config/client"
5+
"@gravity-ui/eslint-config/client",
6+
"@gravity-ui/eslint-config/import-order"
67
],
78
"root": true,
89
"env": {
910
"node": true,
1011
"jest": true
11-
}
12+
},
13+
"rules": {
14+
"@typescript-eslint/no-unused-vars": [
15+
"error",
16+
{
17+
"argsIgnorePattern": "^_",
18+
"varsIgnorePattern": "^_",
19+
"caughtErrorsIgnorePattern": "^_"
20+
}
21+
]
22+
},
23+
"overrides": [
24+
{
25+
"files": ["*.ts", "*.tsx"],
26+
"rules": {
27+
"@typescript-eslint/prefer-ts-expect-error": "error",
28+
"@typescript-eslint/consistent-type-imports": [
29+
"error",
30+
{"prefer": "type-imports", "fixStyle": "separate-type-imports"}
31+
]
32+
}
33+
}
34+
]
1235
}

‎package-lock.json‎

Lines changed: 2839 additions & 2208 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"@babel/preset-typescript": "^7.18.6",
5757
"@commitlint/cli": "^17.0.0",
5858
"@commitlint/config-conventional": "^17.0.0",
59-
"@gravity-ui/eslint-config": "^3.1.1",
59+
"@gravity-ui/eslint-config": "^3.3.0",
6060
"@gravity-ui/prettier-config": "^1.1.0",
6161
"@gravity-ui/stylelint-config": "^4.0.1",
6262
"@gravity-ui/tsconfig": "^1.0.0",

‎src/lib/core/components/Form/Controller/Controller.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import React from 'react';
22

33
import omit from 'lodash/omit';
44

5-
import {FormValue, Spec} from '../../../types';
5+
import type {FormValue, Spec} from '../../../types';
66
import {useControllerMirror, useDynamicFormsCtx, useSearch} from '../hooks';
7-
import {ControllerMirror, FieldValue, ValidateError} from '../types';
7+
import type {ControllerMirror, FieldValue, ValidateError} from '../types';
88

9-
import {ControllerStore} from './types';
9+
import type {ControllerStore} from './types';
1010
import {callUnmout, getFieldMethods, initializeStore, updateStore} from './utils';
1111

1212
export interface ControllerProps<DirtyValue extends FieldValue, SpecType extends Spec> {

‎src/lib/core/components/Form/Controller/types.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import {FormValue, Spec} from '../../../types';
2-
import {
1+
import type {FormValue, Spec} from '../../../types';
2+
import type {
33
DynamicFormConfig,
44
DynamicFormMutatorsStore,
55
DynamicFormsContext,

‎src/lib/core/components/Form/Controller/utils.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import {isValidElementType} from 'react-is';
1616

1717
import {SpecTypes} from '../../../constants';
1818
import {isArraySpec, isCorrectSpec, isNumberSpec, isObjectSpec} from '../../../helpers';
19-
import {FormValue, Spec} from '../../../types';
19+
import type {FormValue, Spec} from '../../../types';
2020
import {EMPTY_MUTATOR, OBJECT_ARRAY_CNT, OBJECT_ARRAY_FLAG} from '../constants';
21-
import {
21+
import type {
2222
BaseValidateError,
2323
FieldArrayValue,
2424
FieldObjectValue,
@@ -29,7 +29,7 @@ import {
2929
} from '../types';
3030
import {isArrayItem, isCorrectConfig, transformArrIn, transformArrOut} from '../utils';
3131

32-
import {
32+
import type {
3333
ControllerStore,
3434
GetComponentsParams,
3535
GetComponentsReturn,

‎src/lib/core/components/Form/DynamicField.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {isValidElementType} from 'react-is';
77
import type {MonacoEditorProps} from 'react-monaco-editor/lib/types';
88

99
import {isCorrectSpec} from '../../helpers';
10-
import {Spec, StringSpec} from '../../types';
10+
import type {Spec, StringSpec} from '../../types';
1111

1212
import {Controller} from './Controller';
1313
import {
@@ -20,7 +20,7 @@ import {
2020
useSearchStore,
2121
useStore,
2222
} from './hooks';
23-
import {DynamicFormConfig, DynamicFormMutators, FieldValue, WonderMirror} from './types';
23+
import type {DynamicFormConfig, DynamicFormMutators, FieldValue, WonderMirror} from './types';
2424
import {getDefaultSearchFunction, isCorrectConfig} from './utils';
2525

2626
export interface DynamicFieldProps {

‎src/lib/core/components/Form/__tests__/DynamicField.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@ import React from 'react';
22

33
import {ThemeProvider} from '@gravity-ui/uikit';
44
import {act, render} from '@testing-library/react';
5-
import {FormApi} from 'final-form';
5+
import type {FormApi} from 'final-form';
66
import noop from 'lodash/noop';
77
import values from 'lodash/values';
88
import {Form, useForm} from 'react-final-form';
99

1010
import {ErrorMessages, dynamicConfig} from '../../../../kit';
1111
import {SpecTypes} from '../../../constants';
12-
import {ObjectSpec} from '../../../types';
12+
import type {ObjectSpec} from '../../../types';
1313
import {DynamicField} from '../DynamicField';
14-
import {FieldArrayValue, WonderMirror} from '../types';
14+
import type {FieldArrayValue, WonderMirror} from '../types';
1515
import {transformArrOut} from '../utils';
1616

1717
const name = 'name';

‎src/lib/core/components/Form/hooks/__tests__/useIntegrationFF.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import React from 'react';
22

33
import {act, render} from '@testing-library/react';
4-
import {FormApi} from 'final-form';
4+
import type {FormApi} from 'final-form';
55
import cloneDeep from 'lodash/cloneDeep';
66
import noop from 'lodash/noop';
77
import {Form, useForm} from 'react-final-form';
88

99
import {ErrorMessages, dynamicConfig} from '../../../../../kit';
1010
import {SpecTypes} from '../../../../constants';
11-
import {ObjectSpec} from '../../../../types';
11+
import type {ObjectSpec} from '../../../../types';
1212
import {DynamicField} from '../../DynamicField';
13-
import {WonderMirror} from '../../types';
13+
import type {WonderMirror} from '../../types';
1414

1515
const spec: ObjectSpec = {type: SpecTypes.Object, viewSpec: {type: ''}};
1616
const value = {name: {key: 'value'}};

‎src/lib/core/components/Form/hooks/__tests__/useSearch.test.tsx‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
import React from 'react';
22

33
import {render} from '@testing-library/react';
4-
54
import noop from 'lodash/noop';
6-
75
import {Form} from 'react-final-form';
86

97
import {dynamicConfig} from '../../../../../kit';
108
import {SpecTypes} from '../../../../constants';
11-
import {ObjectSpec} from '../../../../types';
9+
import type {ObjectSpec} from '../../../../types';
1210
import {DynamicField} from '../../DynamicField';
13-
import {WonderMirror} from '../../types';
11+
import type {WonderMirror} from '../../types';
1412

1513
const spec: ObjectSpec = {
1614
type: SpecTypes.Object,

0 commit comments

Comments
 (0)