chore: bump @gravity-ui/nodekit devDependency to ^2.10.1

Required for isEnded() method on AppContext type.

Author: melikhov-dev

package-lock.json

@@ -30,7 +30,7 @@
     "@commitlint/cli": "^17.7.1",
     "@commitlint/config-conventional": "^17.7.0",
     "@gravity-ui/eslint-config": "^3.2.0",
-    "@gravity-ui/nodekit": "^2.7.0",
+    "@gravity-ui/nodekit": "^2.10.1",
     "@gravity-ui/prettier-config": "^1.1.0",
     "@gravity-ui/tsconfig": "^1.0.0",
     "@types/accept-language-parser": "^1.5.6",

package.json

@@ -23,7 +23,8 @@ function isAllowedMethod(method: string): method is Lowercase<HttpMethod> | 'mou
 function wrapMiddleware(fn: AppMiddleware, i?: number): AppMiddleware {
     const result: AppMiddleware = async (req, res, next) => {
         const reqCtx = req.ctx;
-        if (reqCtx.isEnded()) {
+        // Skip creating child context if parent is already ended (e.g. client disconnected)
+        if (reqCtx.abortSignal.aborted) {
             return next();
         }
         const ctx = reqCtx.create(`${fn.name || `noname-${i}`} middleware`);
@@ -57,7 +58,8 @@ function wrapRouteHandler(fn: AppRouteHandler, handlerName?: string) {
     const handlerNameLocal = handlerName || fn.name || UNNAMED_CONTROLLER;
 
     const handler: AppMiddleware = async (req, res, next) => {
-        if (req.originalContext.isEnded()) {
+        // Skip creating child context if parent is already ended (e.g. client disconnected)
+        if (req.originalContext.abortSignal.aborted) {
             return;
         }
         req.ctx = req.originalContext.create(handlerNameLocal);

src/router.ts

@@ -328,8 +328,9 @@ describe('Context Lifecycle', () => {
     });
 
     describe('Client Disconnect Handling', () => {
-        it('should not throw when middleware runs after client disconnect', async () => {
+        it('should skip next middleware when context is already ended', async () => {
             let slowMiddlewareCalled = false;
+            let nextMiddlewareCalled = false;
 
             const slowMiddleware = async (req: Request, _res: Response, next: NextFunction) => {
                 slowMiddlewareCalled = true;
@@ -342,10 +343,15 @@ describe('Context Lifecycle', () => {
                 next();
             };
 
+            const nextMiddleware = (_req: Request, _res: Response, next: NextFunction) => {
+                nextMiddlewareCalled = true;
+                next();
+            };
+
             const nodekit = new NodeKit();
             const app = new ExpressKit(nodekit, {
                 'GET /test': {
-                    beforeAuth: [slowMiddleware],
+                    beforeAuth: [slowMiddleware, nextMiddleware],
                     handler: (_req: Request, res: Response) => {
                         res.json({ok: true});
                     },
@@ -358,6 +364,7 @@ describe('Context Lifecycle', () => {
                 .catch(() => {});
 
             expect(slowMiddlewareCalled).toBe(true);
+            expect(nextMiddlewareCalled).toBe(false);
         });
 
         it('should not throw when route handler runs after client disconnect', async () => {