chore: fix or turn-off eslint warnings (#143)

draedful · web-flow · commit 741050ad3883 · 2025-09-23T18:31:28.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -45,6 +45,23 @@
           }
         ]
       }
+    },
+    {
+      "files": [
+        "src/stories/**/*.tsx"
+      ],
+      "rules": {
+        "no-console": "off"
+      }
+    },
+    {
+      "files": [
+        "**/*.test.ts",
+        "**/*.test.tsx"
+      ],
+      "rules": {
+        "@typescript-eslint/no-explicit-any": "off"
+      }
     }
   ],
   "rules": {
@@ -54,6 +71,8 @@
     "guard-for-in": "off",
     "no-return-assign": "off",
     "@typescript-eslint/member-ordering": "off",
+    "@typescript-eslint/no-shadow": "off",
+    "valid-jsdoc": "off",
     "import/consistent-type-specifier-style": [
       "error",
       "prefer-top-level"
diff --git a/src/components/canvas/EventedComponent/EventedComponent.ts b/src/components/canvas/EventedComponent/EventedComponent.ts
@@ -78,10 +78,11 @@ export class EventedComponent<
 
     handlers?.forEach((cb) => {
       if (typeof cb === "function") {
-        cb(event);
+        return cb(event);
       } else if (cb instanceof Component && "handleEvent" in cb && typeof cb.handleEvent === "function") {
-        cb.handleEvent?.(event);
+        return cb.handleEvent?.(event);
       }
+      return undefined;
     });
   }
 
diff --git a/src/components/canvas/GraphComponent/index.tsx b/src/components/canvas/GraphComponent/index.tsx
@@ -57,7 +57,7 @@ export class GraphComponent<
     if (!this.ports.has(id)) {
       return this.createPort(id);
     }
-    return this.ports.get(id)!;
+    return this.ports.get(id);
   }
 
   protected setAffectsUsableRect(affectsUsableRect: boolean) {
diff --git a/src/components/canvas/blocks/Blocks.ts b/src/components/canvas/blocks/Blocks.ts
@@ -1,4 +1,5 @@
 import { Component } from "../../../lib/Component";
+import { CoreComponent } from "../../../lib/CoreComponent";
 import { BlockState } from "../../../store/block/Block";
 import { TGraphLayerContext } from "../layers/graphLayer/GraphLayer";
 
@@ -14,7 +15,7 @@ export class Blocks extends Component {
 
   private font: string;
 
-  constructor(props: {}, context: any) {
+  constructor(props: {}, context: CoreComponent) {
     super(props, context);
 
     this.unsubscribe = this.subscribe();
diff --git a/src/components/canvas/groups/BlockGroups.ts b/src/components/canvas/groups/BlockGroups.ts
@@ -90,7 +90,7 @@ export class BlockGroups<P extends BlockGroupsProps = BlockGroupsProps> extends
       constants: this.props.graph.graphConstants,
       colors: this.props.graph.graphColors,
       graph: this.props.graph,
-      ownerDocument: this.props.root!,
+      ownerDocument: this.props.root,
     });
   }
 
diff --git a/src/graph.ts b/src/graph.ts
@@ -11,7 +11,7 @@ import { TGraphColors, TGraphConstants, initGraphColors, initGraphConstants } fr
 import { GraphEventParams, GraphEventsDefinitions } from "./graphEvents";
 import { scheduler } from "./lib/Scheduler";
 import { HitTest } from "./services/HitTest";
-import { Layer } from "./services/Layer";
+import { Layer, LayerPublicProps } from "./services/Layer";
 import { Layers } from "./services/LayersService";
 import { CameraService } from "./services/camera/CameraService";
 import { RootStore } from "./store";
@@ -23,12 +23,7 @@ import { clearTextCache } from "./utils/renderers/text";
 import { RecursivePartial } from "./utils/types/helpers";
 import { IPoint, IRect, Point, TPoint, TRect, isTRect } from "./utils/types/shapes";
 
-export type LayerConfig<T extends Constructor<Layer> = Constructor<Layer>> = [
-  T,
-  T extends Constructor<Layer<infer Props>>
-    ? Omit<Props, "root" | "camera" | "graph"> & { root?: Props["root"] }
-    : never,
-];
+export type LayerConfig<T extends Constructor<Layer> = Constructor<Layer>> = [T, LayerPublicProps<T>];
 export type TGraphConfig<Block extends TBlock = TBlock, Connection extends TConnection = TConnection> = {
   configurationName?: string;
   blocks?: Block[];
@@ -306,9 +301,7 @@ export class Graph {
 
   public addLayer<T extends Constructor<Layer> = Constructor<Layer>>(
     layerCtor: T,
-    props: T extends Constructor<Layer<infer Props>>
-      ? Omit<Props, "root" | "camera" | "graph" | "emitter"> & { root?: Props["root"] }
-      : never
+    props: LayerPublicProps<T>
   ): InstanceType<T> {
     // TODO: These types are too complicated, try to simplify them
     return this.layers.createLayer(layerCtor as Constructor<Layer>, {
diff --git a/src/lib/CoreComponent.ts b/src/lib/CoreComponent.ts
@@ -4,7 +4,7 @@ import { ITree, Tree } from "./Tree";
 
 type TOptions = {
   readonly key?: string;
-  readonly ref?: ((inst: any) => void) | string;
+  readonly ref?: ((inst: unknown) => void) | string;
 };
 
 export type TCoreComponent = CoreComponent<CoreComponentProps, CoreComponentContext>;
diff --git a/src/lib/tshelpers.ts b/src/lib/tshelpers.ts
diff --git a/src/plugins/minimap/layer.ts b/src/plugins/minimap/layer.ts
@@ -127,6 +127,7 @@ export class MiniMapLayer extends Layer<MiniMapLayerProps, MiniMapLayerContext>
     this.relativeY = yPos + height / 2 - this.minimapHeight / this.scale / 2;
   }
 
+  // eslint-disable-next-line complexity
   private drawCameraBorderFrame() {
     const cameraState = this.props.camera.getCameraState();
 
diff --git a/src/react-components/Block.tsx b/src/react-components/Block.tsx
@@ -66,6 +66,7 @@ export const GraphBlock = <T extends TBlock>({
         }
       });
     }
+    return undefined;
   }, [viewState]);
 
   useEffect(() => {
diff --git a/src/react-components/GraphLayer.tsx b/src/react-components/GraphLayer.tsx
@@ -1,25 +1,12 @@
 import React, { forwardRef, useImperativeHandle, useState } from "react";
 
 import { GraphState } from "../graph";
-import type { Layer } from "../services/Layer";
+import type { Layer, LayerPublicProps } from "../services/Layer";
 
 import { useGraphContext } from "./GraphContext";
 import { useGraphEvent } from "./hooks/useGraphEvents";
 import { useLayer } from "./hooks/useLayer";
 
-/**
- * Type constructor for Layer class
- */
-type Constructor<T = {}> = new (...args: any[]) => T;
-
-/**
- * Extracts property types from Layer constructor
- */
-type LayerPropsForConstructor<TLayer extends Constructor<Layer>> =
-  TLayer extends Constructor<Layer<infer LayerProps>>
-    ? Omit<LayerProps, "root" | "camera" | "graph" | "emitter"> & { root?: LayerProps["root"] }
-    : never;
-
 /**
  * Extracts layer instance type from constructor
  */
@@ -37,7 +24,7 @@ export interface GraphLayerProps<TLayer extends Constructor<Layer> = Constructor
   /**
    * Props to pass to layer constructor
    */
-  props?: LayerPropsForConstructor<TLayer>;
+  props?: LayerPublicProps<TLayer>;
   /**
    * Ref to access layer instance
    */
@@ -64,10 +51,10 @@ export const GraphLayer = forwardRef<LayerInstanceForConstructor<Constructor<Lay
     });
 
     // Always create layer using useLayer (hooks must be called unconditionally)
-    const layer = useLayer(graph, LayerClass, (props as any) || {});
+    const layer = useLayer(graph, LayerClass, props);
 
     // Expose layer through ref
-    useImperativeHandle(ref, () => layer!, [layer]);
+    useImperativeHandle(ref, () => layer, [layer]);
 
     // GraphLayer doesn't render any visible content
     return null;
diff --git a/src/react-components/GraphPortal.tsx b/src/react-components/GraphPortal.tsx
@@ -145,7 +145,7 @@ export const GraphPortal = forwardRef<GraphPortalLayer, GraphPortalProps>(functi
   });
 
   // Expose layer through ref
-  useImperativeHandle(ref, () => layer!, [layer]);
+  useImperativeHandle(ref, () => layer, [layer]);
 
   // If graph is not ready or layer not yet created, don't render portal
   if (!graph || graphState < GraphState.ATTACHED || !layer) {
diff --git a/src/react-components/hooks/useGraph.ts b/src/react-components/hooks/useGraph.ts
@@ -5,7 +5,7 @@ import type { TBlock } from "../../components/canvas/blocks/Block";
 import { Graph, GraphState, TGraphConfig } from "../../graph";
 import type { TGraphZoomTarget } from "../../graph";
 import type { TGraphColors, TGraphConstants } from "../../graphConfig";
-import type { Layer } from "../../services/Layer";
+import type { Layer, LayerPublicProps } from "../../services/Layer";
 import type { TConnection } from "../../store/connection/ConnectionState";
 import { RecursivePartial } from "../../utils/types/helpers";
 import { useFn } from "../utils/hooks/useFn";
@@ -77,9 +77,7 @@ export function useGraph(config: HookGraphParams) {
     addLayer: useFn(
       <T extends Constructor<Layer> = Constructor<Layer>>(
         layerCtor: T,
-        props: T extends Constructor<Layer<infer Props>>
-          ? Omit<Props, "root" | "camera" | "graph" | "emitter"> & { root?: Props["root"] }
-          : never
+        props: LayerPublicProps<T>
       ): InstanceType<T> => {
         return graph.addLayer(layerCtor, props);
       }
diff --git a/src/react-components/hooks/useGraphEvents.ts b/src/react-components/hooks/useGraphEvents.ts
@@ -14,14 +14,14 @@ export function useGraphEvent<Event extends keyof GraphEventsDefinitions>(
     cb(e.detail, e);
   });
   useLayoutEffect(() => {
-    if (!graph) return;
+    if (!graph) return undefined;
     return graph.on(event, onEvent);
   }, [graph, event, onEvent]);
 }
 
 export function useGraphEvents(graph: Graph | null, events: Partial<TGraphEventCallbacks>) {
   useLayoutEffect(() => {
-    if (!graph) return;
+    if (!graph) return undefined;
 
     const unsubscribe = [];
     const fn = (cb: TGraphEventCallbacks[keyof TGraphEventCallbacks]) => (event: CustomEvent) => {
diff --git a/src/react-components/hooks/useLayer.ts b/src/react-components/hooks/useLayer.ts
@@ -3,7 +3,7 @@ import { useDeferredValue, useLayoutEffect, useState } from "react";
 import isEqual from "lodash/isEqual";
 
 import type { Graph } from "../../graph";
-import type { Layer } from "../../services/Layer";
+import type { Layer, LayerPublicProps } from "../../services/Layer";
 
 import { usePrevious } from "./usePrevious";
 
@@ -31,9 +31,7 @@ import { usePrevious } from "./usePrevious";
 export function useLayer<T extends Constructor<Layer> = Constructor<Layer>>(
   graph: Graph | null,
   layerCtor: T,
-  props: T extends Constructor<Layer<infer Props>>
-    ? Omit<Props, "root" | "camera" | "graph" | "emitter"> & { root?: Props["root"] }
-    : never
+  props: LayerPublicProps<T>
 ) {
   const [layer, setLayer] = useState<InstanceType<T> | null>(null);
   const deferredLayer = useDeferredValue(layer);
diff --git a/src/react-components/utils/cn.ts b/src/react-components/utils/cn.ts
@@ -22,6 +22,7 @@ export const cn = (
       .map(([key]) => key) // Extract the class name (key)
       .join(" ");
 
+    // eslint-disable-next-line no-nested-ternary
     return items ? (acc ? `${acc} ${items}` : items) : acc;
   }, "");
 };
diff --git a/src/services/Layer.ts b/src/services/Layer.ts
@@ -33,6 +33,24 @@ export type LayerContext = {
   layer: Layer;
 };
 
+/**
+ * Utility type to extract public props for a Layer constructor.
+ * Excludes internal props that are provided by the graph instance:
+ * - root: managed by the layers service
+ * - camera: provided by the graph's camera service
+ * - graph: provided by the graph instance
+ *
+ * The root prop is made optional as it can be overridden by the user.
+ *
+ * @template T - Layer constructor type
+ */
+export type LayerPublicProps<T extends Constructor<Layer>> =
+  T extends Constructor<Layer<infer Props>>
+    ? Omit<Props, "root" | "camera" | "graph"> & { root?: Props["root"] }
+    : never;
+
+export type LayerConstructor<T extends Constructor<Layer>> = T extends Constructor<Layer> ? T : never;
+
 export class Layer<
   Props extends LayerProps = LayerProps,
   Context extends LayerContext = LayerContext,
diff --git a/src/services/optimizations/frameDebouncer.ts b/src/services/optimizations/frameDebouncer.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 // TODO: throtled with leading need test
 
 import { scheduler } from "../../lib/Scheduler";
diff --git a/src/utils/Emitter.ts b/src/utils/Emitter.ts
@@ -6,6 +6,35 @@ const rIC = globalObject.requestIdleCallback || globalObject.setTimeout;
 
 const getTime = () => performance.now();
 type EmitterEventsDefinition = Record<string, (...args: unknown[]) => void>;
+
+type EmitterFn = (...args: unknown[]) => void;
+
+class FnWrapper<Fn extends EmitterFn> {
+  public fn: Fn;
+
+  public once: boolean;
+
+  public canBeDeleted: boolean;
+
+  constructor(fn: Fn, once: boolean) {
+    this.fn = fn;
+    this.once = once;
+    this.canBeDeleted = false;
+  }
+
+  public run(...args: Parameters<Fn>) {
+    this.fn.apply(null, Array.from(args));
+    if (this.once) {
+      this.destroy();
+    }
+  }
+
+  public destroy() {
+    this.fn = noop as Fn;
+    this.canBeDeleted = true;
+  }
+}
+
 export class Emitter<T extends EmitterEventsDefinition = EmitterEventsDefinition> {
   private gcLaunched: boolean;
 
@@ -63,7 +92,7 @@ export class Emitter<T extends EmitterEventsDefinition = EmitterEventsDefinition
   }
 
   public emit<Name extends keyof T>(event: Name, ...args: Parameters<T[Name]>) {
-    if (!this.mapEventToFnWrapper?.has(event)) return;
+    if (!this.mapEventToFnWrapper?.has(event)) return this;
 
     const fnWrappers = this.mapEventToFnWrapper.get(event) ?? [];
 
@@ -125,31 +154,3 @@ export class Emitter<T extends EmitterEventsDefinition = EmitterEventsDefinition
     }
   }
 }
-
-type EmitterFn = (...args: unknown[]) => void;
-
-class FnWrapper<Fn extends EmitterFn> {
-  public fn: Fn;
-
-  public once: boolean;
-
-  public canBeDeleted: boolean;
-
-  constructor(fn: Fn, once: boolean) {
-    this.fn = fn;
-    this.once = once;
-    this.canBeDeleted = false;
-  }
-
-  public run(...args: Parameters<Fn>) {
-    this.fn.apply(null, Array.from(args));
-    if (this.once) {
-      this.destroy();
-    }
-  }
-
-  public destroy() {
-    this.fn = noop as Fn;
-    this.canBeDeleted = true;
-  }
-}
diff --git a/src/utils/types/global.d.ts b/src/utils/types/global.d.ts
@@ -5,6 +5,7 @@ type Interface<T> = { [P in keyof T]: T[P] };
 
 type PartialObject<T> = Pick<T, keyof T>;
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 declare const global: any;
 
 interface IWithEvent extends EventTarget {
diff --git a/src/utils/types/shapes.ts b/src/utils/types/shapes.ts
@@ -1,3 +1,5 @@
+import isObject from "lodash/isObject";
+
 export type TPoint = {
   x: number;
   y: number;
@@ -55,8 +57,9 @@ export type TRect = {
   height: number;
 };
 
-export function isTRect(rect: any): rect is TRect {
+export function isTRect(rect: unknown): rect is TRect {
   return (
+    isObject(rect) &&
     "x" in rect &&
     typeof rect.x === "number" &&
     "y" in rect &&

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,11 @@ export class EventedComponent<`
`78`	`78`
`79`	`79`	`handlers?.forEach((cb) => {`
`80`	`80`	`if (typeof cb === "function") {`
`81`		`- cb(event);`
	`81`	`+ return cb(event);`
`82`	`82`	`} else if (cb instanceof Component && "handleEvent" in cb && typeof cb.handleEvent === "function") {`
`83`		`- cb.handleEvent?.(event);`
	`83`	`+ return cb.handleEvent?.(event);`
`84`	`84`	`}`
	`85`	`+ return undefined;`
`85`	`86`	`});`
`86`	`87`	`}`
`87`	`88`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export class GraphComponent<`
`57`	`57`	`if (!this.ports.has(id)) {`
`58`	`58`	`return this.createPort(id);`
`59`	`59`	`}`
`60`		`- return this.ports.get(id)!;`
	`60`	`+ return this.ports.get(id);`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`protected setAffectsUsableRect(affectsUsableRect: boolean) {`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ export class BlockGroups<P extends BlockGroupsProps = BlockGroupsProps> extends`
`90`	`90`	`constants: this.props.graph.graphConstants,`
`91`	`91`	`colors: this.props.graph.graphColors,`
`92`	`92`	`graph: this.props.graph,`
`93`		`- ownerDocument: this.props.root!,`
	`93`	`+ ownerDocument: this.props.root,`
`94`	`94`	`});`
`95`	`95`	`}`
`96`	`96`
Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,7 @@ export class MiniMapLayer extends Layer<MiniMapLayerProps, MiniMapLayerContext>`
`127`	`127`	`this.relativeY = yPos + height / 2 - this.minimapHeight / this.scale / 2;`
`128`	`128`	`}`
`129`	`129`
	`130`	`+ // eslint-disable-next-line complexity`
`130`	`131`	`private drawCameraBorderFrame() {`
`131`	`132`	`const cameraState = this.props.camera.getCameraState();`
`132`	`133`
Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ export const GraphBlock = <T extends TBlock>({`
`66`	`66`	`}`
`67`	`67`	`});`
`68`	`68`	`}`
	`69`	`+ return undefined;`
`69`	`70`	`}, [viewState]);`
`70`	`71`
`71`	`72`	`useEffect(() => {`