feat(GraphComponent)!: provide absolute diff from drag start in onDrag callback #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g callback BREAKING CHANGE: `diffX`/`diffY` in `onDragUpdate` callback now represent absolute displacement from drag start position instead of incremental frame-to-frame values. Changes: - `diffX`/`diffY` now calculated as `currentCoords - startCoords` - Added `startCoords` - initial position when drag started - Added `deltaX`/`deltaY` - incremental change since previous frame - Removed integer truncation (`| 0`) for better precision with slow movements
Contributor
|
Preview is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
diffX/diffYinonDragUpdatecallback now representabsolute displacement from drag start position instead of incremental
frame-to-frame values.
Changes:
diffX/diffYnow calculated ascurrentCoords - startCoordsstartCoords- initial position when drag starteddeltaX/deltaY- incremental change since previous frame| 0) for better precision with slow movements