feat: support overriding codemirror history extension (#331)

* feat: support overriding codemirror history extension

* feat: support overriding codemirror history extension

Author: beliarh

src/bundle/Editor.ts

@@ -111,6 +111,10 @@ type ChangeEditorModeOptions = {
 export type MarkupConfig = {
     /** Additional extensions for codemirror instance. */
     extensions?: CreateCodemirrorParams['extensions'];
+    /** Can be used to disable some of the default extensions */
+    disabledExtensions?: CreateCodemirrorParams['disabledExtensions'];
+    /** Additional keymaps for codemirror instance */
+    keymaps?: CreateCodemirrorParams['keymaps'];
     /**
      * Additional language data for markdown language in codemirror.
      * Can be used to configure additional autocompletions and others.
@@ -287,6 +291,8 @@ export class EditorImpl extends SafeEventEmitter<EventMapInt> implements EditorI
                     uploadHandler: this.fileUploadHandler,
                     needImgDimms: this.needToSetDimensionsForUploadedImages,
                     extensions: this.#markupConfig.extensions,
+                    disabledExtensions: this.#markupConfig.disabledExtensions,
+                    keymaps: this.#markupConfig.keymaps,
                     yfmLangOptions: {languageData: this.#markupConfig.languageData},
                     receiver: this,
                 }),

src/markup/codemirror/create.ts

@@ -8,7 +8,7 @@ import {
 } from '@codemirror/commands';
 import {syntaxHighlighting} from '@codemirror/language';
 import type {Extension, StateCommand} from '@codemirror/state';
-import {EditorView, EditorViewConfig, keymap, placeholder} from '@codemirror/view';
+import {EditorView, EditorViewConfig, KeyBinding, keymap, placeholder} from '@codemirror/view';
 
 import {EventMap} from '../../bundle/Editor';
 import {ActionName} from '../../bundle/config/action-names';
@@ -55,6 +55,10 @@ export type CreateCodemirrorParams = {
     uploadHandler?: FileUploadHandler;
     needImgDimms?: boolean;
     extensions?: Extension[];
+    disabledExtensions?: {
+        history?: boolean;
+    };
+    keymaps?: readonly KeyBinding[];
     receiver?: Receiver<EventMap>;
     yfmLangOptions?: YfmLangOptions;
 };
@@ -70,14 +74,19 @@ export function createCodemirror(params: CreateCodemirrorParams) {
         onChange,
         onDocChange,
         extensions: extraExtensions,
+        disabledExtensions = {},
+        keymaps = [],
         receiver,
         yfmLangOptions,
     } = params;
 
-    const extensions: Extension[] = [
-        gravityTheme,
-        placeholder(placeholderText),
-        history(),
+    const extensions: Extension[] = [gravityTheme, placeholder(placeholderText)];
+
+    if (!disabledExtensions.history) {
+        extensions.push(history());
+    }
+
+    extensions.push(
         syntaxHighlighting(gravityHighlightStyle),
         keymap.of([
             {key: f.toCM(A.Bold)!, run: withLogger(ActionName.bold, toggleBold)},
@@ -114,7 +123,8 @@ export function createCodemirror(params: CreateCodemirrorParams) {
             {key: 'Tab', preventDefault: true, run: insertTab},
             indentWithTab,
             ...defaultKeymap,
-            ...historyKeymap,
+            ...(disabledExtensions.history ? [] : historyKeymap),
+            ...keymaps,
         ]),
         autocompletion(),
         yfmLang(yfmLangOptions),
@@ -131,7 +141,8 @@ export function createCodemirror(params: CreateCodemirrorParams) {
             anchorSelector: '.g-md-search-anchor',
             receiver,
         }),
-    ];
+    );
+
     if (params.uploadHandler) {
         extensions.push(
             FileUploadHandlerFacet.of({
@@ -140,6 +151,7 @@ export function createCodemirror(params: CreateCodemirrorParams) {
             }),
         );
     }
+
     if (extraExtensions) {
         extensions.push(...extraExtensions);
     }