Skip to content

Commit 64c83fb

Browse files
authored
fix: update lint rules and remove import of lodash global object (#175)
FIX: remove import of lodash global Also: - update eslint, stylelint, prettier and lint configs - add `@gravity-ui/eslint-config/a11y` preset - add `@gravity-ui/eslint-config/import-order` preset - add `lodash/import-scope` rule
1 parent 5cf59e7 commit 64c83fb

File tree

256 files changed

+3143
-1242
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

256 files changed

+3143
-1242
lines changed

.eslintrc

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
{
2-
"extends": ["@gravity-ui/eslint-config", "@gravity-ui/eslint-config/prettier"],
3-
"root": true
2+
"root": true,
3+
"extends": [
4+
"@gravity-ui/eslint-config",
5+
"@gravity-ui/eslint-config/a11y",
6+
"@gravity-ui/eslint-config/prettier",
7+
"@gravity-ui/eslint-config/import-order"
8+
],
9+
"plugins": ["lodash"],
10+
"rules": {
11+
"lodash/import-scope": [2, "method"]
12+
}
413
}

demo/HtmlPreview.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import React from 'react';
2+
23
import transform from '@diplodoc/transform';
4+
5+
import {MarkupString, colorClassName} from '../src';
36
import type {ClassNameProps} from '../src/classname';
4-
import {colorClassName, MarkupString} from '../src';
7+
58
import {plugins} from './md-plugins';
69

710
type PlaygroundHtmlPreviewProps = ClassNameProps & {

demo/PMSelection.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import React from 'react';
2+
23
import type {EditorView} from 'prosemirror-view';
3-
import {isTextSelection, isNodeSelection, isWholeSelection, ClassNameProps} from '../src';
4+
5+
import {ClassNameProps, isNodeSelection, isTextSelection, isWholeSelection} from '../src';
46

57
export type PMSelectionProps = ClassNameProps & {
68
view: EditorView;

demo/Playground.stories.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react';
2-
import {ComponentMeta, Story} from '@storybook/react';
2+
3+
import type {ComponentMeta, Story} from '@storybook/react'; // eslint-disable-line import/no-extraneous-dependencies
34

45
import {Playground as PlaygroundComponent, PlaygroundProps} from './Playground';
56
import {initialMdContent} from './md-content';

demo/Playground.tsx

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,33 @@
11
import React from 'react';
2-
import block from 'bem-cn-lite';
3-
import {useUpdate} from 'react-use';
2+
43
import {Button, RadioButton, TextArea} from '@gravity-ui/uikit';
4+
import block from 'bem-cn-lite'; // eslint-disable-line import/no-extraneous-dependencies
5+
import {useUpdate} from 'react-use';
56

67
import {
78
BaseNode,
89
BasePreset,
910
BehaviorPreset,
11+
Extension,
12+
FlexToolbar,
1013
MarkdownBlocksPreset,
1114
MarkdownMarksPreset,
1215
MarkupString,
13-
YfmEditorComponent,
14-
useYfmEditor,
15-
YfmPreset,
16-
Extension,
1716
ReactRenderStorage,
1817
ReactRendererComponent,
19-
FlexToolbar,
18+
YfmEditorComponent,
19+
YfmPreset,
20+
logger,
21+
useYfmEditor,
2022
} from '../src';
2123
import {wHiddenData, wToolbarConfig} from '../src/toolbar/config/wysiwyg';
2224

2325
import {PlaygroundHtmlPreview} from './HtmlPreview';
24-
import {ProseMirrorDevTools} from './ProseMirrorDevTools';
2526
import {PMSelection} from './PMSelection';
26-
import {logger} from '../src/index';
27+
import {ProseMirrorDevTools} from './ProseMirrorDevTools';
28+
import {keys} from './keys';
2729

2830
import './Playground.scss';
29-
import {keys} from './keys';
3031

3132
const b = block('playground');
3233

demo/ProseMirrorDevTools.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {useEffect} from 'react';
2-
import type {EditorView} from 'prosemirror-view';
2+
33
import {applyDevTools, removeDevTools} from 'prosemirror-dev-toolkit';
4+
import type {EditorView} from 'prosemirror-view';
45

56
export type ProseMirrorDevToolsProps = {
67
view: EditorView;

demo/md-plugins.ts

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,23 @@
1-
import type {PluginWithParams} from 'markdown-it/lib';
2-
1+
import anchors from '@diplodoc/transform/lib/plugins/anchors';
2+
import checkbox from '@diplodoc/transform/lib/plugins/checkbox';
3+
import code from '@diplodoc/transform/lib/plugins/code';
4+
import cut from '@diplodoc/transform/lib/plugins/cut';
5+
import deflist from '@diplodoc/transform/lib/plugins/deflist';
36
import file from '@diplodoc/transform/lib/plugins/file';
47
import imsize from '@diplodoc/transform/lib/plugins/imsize';
5-
6-
import sub from 'markdown-it-sub';
7-
import ins from 'markdown-it-ins';
8-
import mark from 'markdown-it-mark';
9-
import color from 'markdown-it-color';
10-
import math from 'markdown-it-katex';
11-
128
import meta from '@diplodoc/transform/lib/plugins/meta';
13-
import checkbox from '@diplodoc/transform/lib/plugins/checkbox';
14-
import deflist from '@diplodoc/transform/lib/plugins/deflist';
15-
import anchors from '@diplodoc/transform/lib/plugins/anchors';
16-
import cut from '@diplodoc/transform/lib/plugins/cut';
9+
import monospace from '@diplodoc/transform/lib/plugins/monospace';
1710
import notes from '@diplodoc/transform/lib/plugins/notes';
18-
import tabs from '@diplodoc/transform/lib/plugins/tabs';
19-
import code from '@diplodoc/transform/lib/plugins/code';
2011
import sup from '@diplodoc/transform/lib/plugins/sup';
21-
import video from '@diplodoc/transform/lib/plugins/video';
22-
import monospace from '@diplodoc/transform/lib/plugins/monospace';
2312
import yfmTable from '@diplodoc/transform/lib/plugins/table';
13+
import tabs from '@diplodoc/transform/lib/plugins/tabs';
14+
import video from '@diplodoc/transform/lib/plugins/video';
15+
import type {PluginWithParams} from 'markdown-it/lib';
16+
import color from 'markdown-it-color';
17+
import ins from 'markdown-it-ins';
18+
import math from 'markdown-it-katex';
19+
import mark from 'markdown-it-mark';
20+
import sub from 'markdown-it-sub';
2421

2522
const defaultPlugins: PluginWithParams[] = [
2623
meta,

demo/utils/preview.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import React from 'react';
2-
import type {Decorator} from '@storybook/react';
3-
import {configure as configureUikit, ThemeProvider} from '@gravity-ui/uikit';
2+
43
import {configure as configureComponents} from '@gravity-ui/components';
4+
import {ThemeProvider, configure as configureUikit} from '@gravity-ui/uikit';
5+
import type {Decorator} from '@storybook/react'; // eslint-disable-line import/no-extraneous-dependencies
6+
57
import {configure as configureYfmEditor} from '../../src';
68

79
import '@gravity-ui/uikit/styles/styles.scss';

0 commit comments

Comments
 (0)