Skip to content

Commit b1b7447

Browse files
authored
feat: add passive flage to every addEventListener (#318)
1 parent 7ee5cd2 commit b1b7447

File tree

19 files changed

+34
-30
lines changed

19 files changed

+34
-30
lines changed

src/blocks/Slider/Slider.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export const SliderBlock = (props: WithChildren<SliderProps>) => {
156156
useEffect(() => {
157157
onResize();
158158

159-
window.addEventListener('resize', onResize);
159+
window.addEventListener('resize', onResize, {passive: true});
160160

161161
return () => window.removeEventListener('resize', onResize);
162162
}, [onResize]);

src/components/BalancedMasonry/BalancedMasonry.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ const BalancedMasonry = (props: WithChildren<BalancedMasonryProps>) => {
9393
useEffect(() => {
9494
const updateColumnCounter = () => setColumnCount(getCurrentColumnsCount());
9595

96-
window.addEventListener('resize', updateColumnCounter);
96+
window.addEventListener('resize', updateColumnCounter, {passive: true});
9797
return () => window.removeEventListener('resize', updateColumnCounter);
9898
}, [setColumnCount, columns, getCurrentColumnsCount]);
9999

src/components/FullWidthBackground/FullWidthBackground.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default class FullWidthBackground extends Component<
4040
if (this?.ref?.current?.parentElement) {
4141
this.ref.current.parentElement.style.position = 'relative';
4242
this.setBg();
43-
window.addEventListener('resize', this.setBg);
43+
window.addEventListener('resize', this.setBg, {passive: true});
4444
}
4545
}
4646

src/components/HeightCalculator/HeightCalculator.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const HeightCalculator = ({onCalculate, children}: WithChildren<HeightCalculator
4747
}, 1000);
4848

4949
calculateContainerHeight();
50-
window.addEventListener('resize', handleResize);
50+
window.addEventListener('resize', handleResize, {passive: true});
5151

5252
return () => window.removeEventListener('resize', handleResize);
5353
}, [calculateContainerHeight]);

src/components/Map/GoogleMap.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const GoogleMap: React.FC<GMapProps> = (props) => {
4949
}, 100);
5050

5151
updateSize();
52-
window.addEventListener('resize', updateSize);
52+
window.addEventListener('resize', updateSize, {passive: true});
5353

5454
return () => {
5555
window.removeEventListener('resize', updateSize);

src/components/Map/YMap/YandexMap.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ const YandexMap: React.FC<YMapProps> = (props) => {
7676
}, 100);
7777

7878
updateSize();
79-
window.addEventListener('resize', updateSize);
79+
window.addEventListener('resize', updateSize, {passive: true});
8080

8181
return () => {
8282
window.removeEventListener('resize', updateSize);

src/components/Media/Image/Image.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const Image = (props: ImageAllProps) => {
4040
useEffect(() => {
4141
if (parallax) {
4242
const handleScroll = () => setScrollY(window.scrollY);
43-
window.addEventListener('scroll', _.debounce(handleScroll, 5));
43+
window.addEventListener('scroll', _.debounce(handleScroll, 5), {passive: true});
4444
return () => window.removeEventListener('scroll', _.debounce(handleScroll, 5));
4545
}
4646

src/components/Media/Video/Video.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,19 @@ const Video = (props: VideoAllProps) => {
4747
if (loop && typeof loop !== 'boolean') {
4848
const {start = 0, end} = loop;
4949

50-
ref.current.addEventListener('timeupdate', () => {
51-
const videoRef = ref.current;
52-
const endTime = end || (videoRef && videoRef.duration);
53-
54-
if (videoRef && videoRef.currentTime === endTime) {
55-
videoRef.currentTime = start;
56-
videoRef.play().catch(() => setHasVideoFallback(true));
57-
}
58-
});
50+
ref.current.addEventListener(
51+
'timeupdate',
52+
() => {
53+
const videoRef = ref.current;
54+
const endTime = end || (videoRef && videoRef.duration);
55+
56+
if (videoRef && videoRef.currentTime === endTime) {
57+
videoRef.currentTime = start;
58+
videoRef.play().catch(() => setHasVideoFallback(true));
59+
}
60+
},
61+
{passive: true},
62+
);
5963
}
6064

6165
if (playVideo) {

src/components/OutsideClick/OutsideClick.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default class OutsideClick extends React.Component<PropsWithChildren<Outs
1111
ref = createRef<HTMLDivElement>();
1212

1313
componentDidMount() {
14-
document.addEventListener('click', this.handleOutsideClick);
14+
document.addEventListener('click', this.handleOutsideClick, {passive: true});
1515
}
1616

1717
componentWillUnmount() {

src/components/OverflowScroller/OverflowScroller.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default class OverflowScroller extends React.Component<
3737

3838
componentDidMount() {
3939
this.checkOverflow();
40-
window.addEventListener('resize', this.checkOverflow);
40+
window.addEventListener('resize', this.checkOverflow, {passive: true});
4141
}
4242

4343
componentDidUpdate(

0 commit comments

Comments
 (0)