-
Notifications
You must be signed in to change notification settings - Fork 137
test(TableColumnSetup): add visual tests #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test(TableColumnSetup): add visual tests #2492
Conversation
|
Preview is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like "lock" item has different offset. Let's fix it in this PR so screenshot would be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests for different variants popupPlacement
| items: [ | ||
| {id: 'name', title: 'Имя', selected: true, required: true}, | ||
| {id: 'email', title: 'Email', selected: true}, | ||
| {id: 'phone', title: 'Телефон', selected: false}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default we use english texts in demos and examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Visual Tests Report is ready. |
|
@tungulin You should update screenshots in docker environment only |
No description provided.