gravity-forms/gw-display-html-field-on-entry-detail.php (1)

80-118: Secure processing and display of HTML content.

The method properly:

1. Retrieves saved content
2. Conditionally processes Live Merge Tags
3. Processes shortcodes
4. Securely outputs content with proper escaping via esc_html() and wp_kses_post()

Consider making the HTML output structure more customizable for different display requirements.

- printf(
-   '<h4>%s</h4><div>%s</div><hr>',
-   esc_html( $field->label ),
-   wp_kses_post( $content )
- );
+ // Add a filter to allow customization of the HTML output structure
+ $output_template = apply_filters(
+   'gw_display_html_field_template', 
+   '<h4>%1$s</h4><div class="gw-html-field-content">%2$s</div><hr>',
+   $field,
+   $entry
+ );
+ printf(
+   $output_template,
+   esc_html( $field->label ),
+   wp_kses_post( $content )
+ );

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

gravity-forms/gw-display-html-field-on-entry-detail.php (3)

35-36: Consider extending support to the Entry List page.
At present, the snippet only hooks into gform_entry_detail. Per the PR discussion, you may also wish to display the HTML field on the Entry List. Gravity Forms offers filters (e.g., gform_entries_list_columns or gform_entries_list_column_value) for customizing column output in listing views.

Here's a starting point if you decide to pursue this:

 add_action( 'gform_entry_detail', array( $this, 'display_html_field_content' ), 10, 2 );
+// Consider hooking into the entries list to display HTML field content in the listing view as well.
+add_filter( 'gform_entries_list_column_value', array( $this, 'display_html_field_in_list' ), 10, 4 );

---

100-105: Check for the class existence before invoking methods.
method_exists( 'GP_Populate_Anything_Live_Merge_Tags', 'has_live_merge_tag' ) will return false if the class does not exist, but referencing GP_Populate_Anything_Live_Merge_Tags::get_instance() could still cause an error if the class is not loaded. Consider adding a class_exists() check for complete safety.

---

113-118: Use a different heading level or remove the <hr> for a cleaner layout.
Using <h4> and <hr> for each field might be visually cluttered on certain admin pages. If multiple HTML fields exist, consider a simpler heading or a refined stylistic approach.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

gravity-forms/gw-display-html-field-on-entry-detail.php (1)

66-72: ⚠️ Potential issue

Validate $form before referencing $form['fields'].
If GFAPI::get_form() returns false, $form will not be an array and $form['fields'] will trigger an error. This repeats a concern raised in previous reviews. Consider adding a guard clause to prevent potential PHP notices or fatal errors.

 $form = GFAPI::get_form( rgar( $entry, 'form_id' ) );

+if ( ! is_array( $form ) ) {
+    return $entry;
+}

 if ( ! $this->is_applicable_form( $form ) ) {
     return $entry;
 }

gravity-forms/gw-display-html-field-on-entry-detail.php (1)

102-121: Consider unifying or documenting your display logic for Entry Detail and Entry List.
Both methods share similar steps (fetch and process content). Creating a reusable helper or adding docblocks could improve maintainability and clarity.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

gravity-forms/gw-display-html-field-on-entry-detail.php (2)

82-83: Consider improving the recursion prevention mechanism.

The static $is_running flag provides basic recursion protection, but it could remain true if an exception occurs during processing, potentially blocking future executions. Consider using a try-finally block or a more robust mechanism.

 static $is_running = false;

 if ( $is_running || rgget( 'page' ) !== 'gf_entries' || ! $this->is_applicable_field( $field ) ) {
     return $value;
 }

-$is_running = true;
-$content    = $this->process_html_content( $field->content, $form, $entry );
-$is_running = false;
+$is_running = true;
+try {
+    $content = $this->process_html_content( $field->content, $form, $entry );
+} finally {
+    $is_running = false;
+}

Also applies to: 93-95

---

102-105: Update configuration values for production use.

The configuration section contains hardcoded form ID (846) and field ID (4) values that appear to be specific to a development/testing environment. These should be updated to match the target form and field IDs for the actual implementation.

Consider adding a comment to make it clearer that these values need to be customized:

 # Configuration
+// TODO: Update these IDs to match your specific form and HTML field
 new GW_Display_HTML_Field_Entry_Detail( array(
-    'form_id'  => 846, // Replace with your form ID or leave false for all.
-    'field_id' => 4,   // Replace with your HTML field ID or leave false to process all HTML fields.
+    'form_id'  => false, // Replace with your form ID or leave false for all forms.
+    'field_id' => false, // Replace with your HTML field ID or leave false to process all HTML fields.
 ) );

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro