Skip to content

gppa-acf-repeater-mapper.php: Added Image Choice field support in acf repeater mapper. #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

gppa-acf-repeater-mapper.php: Added Image Choice field support in acf repeater mapper. #1079

merged 1 commit into from
Apr 17, 2025

Conversation

@malayladu
Copy link
Contributor

@malayladu malayladu commented Apr 16, 2025

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2904943955/82068

Summary

This PR added support for Image Choice field in GPPA ACF Repeater Mapper snippet.

Before

GPPA-ACF-Repeater-Mapper- Before Fix

After

GPPA-ACF-Repeater-Mapper- After Fix

@malayladu malayladu self-assigned this Apr 16, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 16, 2025 •
edited
Loading

"""

Walkthrough

The update refactors the logic for constructing choice arrays related to ACF repeater rows. Instead of handling separate label and value variables, the code now builds a unified associative array for each choice, containing keys for text, value, and optionally image and attachment ID. The change introduces support for an image field, resolving image URLs to attachment IDs when present. It also improves the handling of fallback values by adding checks to prevent undefined index errors. No changes are made to public APIs or exported function signatures.

Changes

File(s) Change Summary
gp-populate-anything/gppa-acf-repeater-mapper.php Refactored choice construction to use a unified array; added image and attachment ID support; improved fallback handling with isset checks.

Suggested reviewers

  • saifsultanc
    """

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62c15bc and bb1bb14.

📒 Files selected for processing (1)
  • gp-populate-anything/gppa-acf-repeater-mapper.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • gp-populate-anything/gppa-acf-repeater-mapper.php
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@malayladu malayladu force-pushed the malay/fix/82068-gppa-acf-repeater-mapper-issue-with-image-choice-field branch from 4484c25 to 62c15bc Compare April 16, 2025 07:43
@github-actions
Copy link

github-actions bot commented Apr 16, 2025 •
edited
Loading

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against bb1bb14

coderabbitai[bot]
coderabbitai bot reviewed Apr 16, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
gp-populate-anything/gppa-acf-repeater-mapper.php (1)

70-98: Consider adding a unit test for the Image Choice functionality.

While the implementation looks solid, it would be beneficial to add test coverage for this new functionality to ensure it works properly with various image formats and edge cases.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0390f25 and 62c15bc.

📒 Files selected for processing (1)
  • gp-populate-anything/gppa-acf-repeater-mapper.php (1 hunks)
🔇 Additional comments (3)
gp-populate-anything/gppa-acf-repeater-mapper.php (3)

70-76: Clean refactoring of choice construction logic.

The refactoring from separate variables to a unified $choice associative array with 'text' and 'value' keys improves code consistency and readability. The isset() checks also improve robustness by preventing potential undefined index errors.

78-87: Well-implemented Image Choice field support.

Good addition of image support with proper handling of:

  1. Retrieving the image URL from mapped or custom fields
  2. Converting the URL to an attachment ID (required by Image Choice fields)
  3. Adding clear comments explaining the purpose

The implementation follows the same pattern as other field types, maintaining code consistency.

93-95: Consistent handling of price field.

The price handling has been updated to match the same pattern used for other fields, maintaining code consistency throughout the snippet. The isset() check for fallback values prevents potential undefined index errors.

saifsultanc
saifsultanc reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@saifsultanc saifsultanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just that one safety check as suggested by coderabbit please. Thanks!

@malayladu malayladu force-pushed the malay/fix/82068-gppa-acf-repeater-mapper-issue-with-image-choice-field branch from 62c15bc to bb1bb14 Compare April 17, 2025 06:23
saifsultanc
saifsultanc approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@saifsultanc saifsultanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S&M

@malayladu malayladu merged commit 7eb6216 into master Apr 17, 2025
3 of 4 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@saifsultanc saifsultanc saifsultanc approved these changes

Assignees

@malayladu malayladu

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malayladu @saifsultanc