Skip to content

gpnf-sortable-entries.php: Fixed an issue with Sortable Entries snippet not working with Gravity Flow. #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

gpnf-sortable-entries.php: Fixed an issue with Sortable Entries snippet not working with Gravity Flow. #1113

merged 1 commit into from
May 30, 2025

Conversation

@saifsultanc
Copy link
Contributor

@saifsultanc saifsultanc commented May 29, 2025

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2918586555/82589

Summary

Sortable Entries snippet not working in context of Gravity Flow. The scripts were not fired on the admin side, we add that with admin_footer. Also, since the code logic already have conditional guards checking for is_applicable_form etc, I can confirm that the script does not get run on other admin pages (or cause any conflicts or console errors etc).

BEFORE:
Nested entries do not show up, and console errors.
Screenshot 2025-05-29 at 12 37 58 PM

AFTER:
https://www.loom.com/share/2f3639e609c0449c8e89285613fd55db

@coderabbitai
Copy link

coderabbitai bot commented May 29, 2025 •
edited
Loading

Walkthrough

The update adds the WordPress admin_footer action hook to the load_form_script method in the GPNF_Sortable_Entries class. This ensures the sortable entries script is also loaded in the WordPress admin interface, in addition to the front-end and form preview areas.

Changes

File(s) Change Summary
gp-nested-forms/gpnf-sortable-entries.php Added admin_footer action hook in load_form_script to output script in admin

Suggested reviewers

  • veryspry
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented May 29, 2025

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 24644ca

coderabbitai[bot]
coderabbitai bot reviewed May 29, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
gp-nested-forms/gpnf-sortable-entries.php (1)

287-287: Remove debug console.log statement.

The console.log(gpnf) statement appears to be debug code that should be removed for production use. This will prevent unnecessary console output in browsers.

Apply this diff to remove the debug statement:

-						console.log(gpnf)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0797abf and 24644ca.

📒 Files selected for processing (1)
  • gp-nested-forms/gpnf-sortable-entries.php (1 hunks)
🔇 Additional comments (1)
gp-nested-forms/gpnf-sortable-entries.php (1)

185-189: LGTM! Hook addition follows existing pattern correctly.

The addition of the admin_footer hook is implemented correctly and follows the same conditional pattern as the existing hooks. This ensures the sortable entries script will run in the WordPress admin area, which is necessary for Gravity Flow integration.

The conditional check ! has_action( 'wp_footer', array( $this, 'output_script' ) ) appropriately prevents all hooks from being added multiple times.

@saifsultanc saifsultanc merged commit 2baed26 into master May 30, 2025
3 of 4 checks passed
@saifsultanc saifsultanc deleted the saif/fix/82589-fix-gravityflow-sortable-nf branch May 30, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@veryspry veryspry veryspry approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saifsultanc @veryspry