Skip to content

gw-cache-buster.php: Fixed an issue with Cache Buster causing conflict with GP Entry Blocks when editing entries. #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

gw-cache-buster.php: Fixed an issue with Cache Buster causing conflict with GP Entry Blocks when editing entries. #1138

merged 2 commits into from
Jul 31, 2025

Conversation

@saifsultanc
Copy link
Contributor

@saifsultanc saifsultanc commented Jul 31, 2025

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/3019129686/87078

Summary

When Cache Buster active, clicking the edit button on Entry Blocks creates a new entry instead of updating the existing one.

BEFORE:
https://www.loom.com/share/19d881969a4640259a4838ce8deb9e65

AFTER:
https://www.loom.com/share/0bbe4985606f4aa5a8067e71fae6e2dc

@saifsultanc
gw-cache-buster.php: Fixed an issue with Cache Buster causing confl…
c9cd0a3 
…ict with GP Entry Blocks on editing entries.
@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025 •
edited
Loading

Walkthrough

The plugin version was updated from 0.6.5 to 0.6.6. In the form_filter method, the recursion prevention condition was extended to also detect when the form is being edited via GP Entry Blocks by checking for the existence of the gp_entry_blocks function and the editing state. No public API or signature changes were made.

Changes

Cohort / File(s) Change Summary
Plugin Version & Recursion Prevention
gravity-forms/gw-cache-buster.php		 Incremented version to 0.6.6. Enhanced form_filter method to additionally check if the form is being edited via GP Entry Blocks and return original markup if so, preventing recursion during entry editing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • veryspry

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9cd0a3 and 02fc59e.

📒 Files selected for processing (1)
  • gravity-forms/gw-cache-buster.php (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • gravity-forms/gw-cache-buster.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch saif/fix/87078-fix-gpeb-cb-compat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 31, 2025 •
edited
Loading

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 02fc59e

claygriffiths
claygriffiths reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try gp_entry_blocks()->block_edit_form->is_editing_entry( $form['id'] )?

You'll want to do a function_exists()

@saifsultanc
gw-cache-buster.php: Fixed an issue with Cache Buster causing confl…
02fc59e 
…ict with GP Entry Blocks on editing entries.
@saifsultanc
Copy link
Contributor Author

saifsultanc commented Jul 31, 2025

Can you try gp_entry_blocks()->block_edit_form->is_editing_entry( $form['id'] )?

You'll want to do a function_exists()

Tested and updated

@claygriffiths claygriffiths changed the title gw-cache-buster.php: Fixed an issue with Cache Buster causing conflict with GP Entry Blocks on editing entries. gw-cache-buster.php: Fixed an issue with Cache Buster causing conflict with GP Entry Blocks when editing entries. Jul 31, 2025
claygriffiths
claygriffiths approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

S&M with

`gw-cache-buster.php`: Fixed an issue with Cache Buster causing conflict with GP Entry Blocks when editing entries.

(changed on to when)

@saifsultanc saifsultanc merged commit 1d6d31c into master Jul 31, 2025
4 of 5 checks passed
@saifsultanc saifsultanc deleted the saif/fix/87078-fix-gpeb-cb-compat branch July 31, 2025 14:02
@coderabbitai coderabbitai bot mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claygriffiths claygriffiths claygriffiths approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saifsultanc @claygriffiths