gpns-add-other-fields-to-date-schedule.php: Added other fields to the GP Notification Scheduler.
#618
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Feb 10, 2023
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
LGTM! Just be sure to fix up the PHPCS issues.
I'd also go with something like this for the commit message:
gpns-add-other-fields-to-date-schedule.php: Added snippet to add a specific field ID to be treated as a date field for scheduling.
Comment on lines
+15
to
+16
| // add the target field to fields array | ||
| array_push( $fields, $field ); |
Contributor
There was a problem hiding this comment.
Would $fields[] = $field; work here?
scyt
approved these changes
Feb 14, 2023
Contributor
scyt
left a comment
scyt
left a comment
There was a problem hiding this comment.
Approved with Clay's requested changes.
…he GP Notification Scheduler.
saifsultanc
force-pushed
the
saif/add/42388-add-other-fields-to-gpns
branch
from
3d9d0b8 to
79892bf
Compare
saifsultanc
changed the title
gpns-add-other-fields-to-date-schedule.php: Add other fields to the GP Notification Scheduler.gpns-add-other-fields-to-date-schedule.php: Added other fields to the GP Notification Scheduler.
…he GP Notification Scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2115235612/42388?folderId=7098280
Summary
Add a field other than the Date field to the Notification Scheduler. In this instance, a "Single Line Text Field" was used.