gpnf-disable-sessions.php: Fixed an issue where nested form fields are not dynamically populated.
#907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not dynamically populated.
barthc
force-pushed
the
barth/fix/72085-populating-values
branch
from
222b8f6 to
1b369f2
Compare
spivurno
requested changes
Oct 15, 2024
Contributor
spivurno
left a comment
spivurno
left a comment
There was a problem hiding this comment.
@barthc This snippet is intended to be a solution for the too-large cookie issue we began solving here:
https://github.com/gravitywiz/gp-nested-forms/pull/276/
I'm hesitant to reintroduce a cookie here. 😅
I think the play might be to continue the work of simplifying the cookie by moving the query parameters from the cookie and pass them to the AJAX requests as we did with the field values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2721901699/72085
Summary
The
gpnf-disable-sessionssnippet prevents parameter-based dynamic population from functioning in the child form. The request vars are stored in the session and then used to populate the nested form field. Since this snippet disables sessions, the dynamic population won't work, hence the issue.The fix here is to store the request vars in a cookie and use it to populate the nested form fields.