gw-cache-buster.php: Fixed GP Multi-Page Navigation compatibility issue where custom starting page is not applied.
#923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claygriffiths
approved these changes
Nov 25, 2024
Contributor
claygriffiths
left a comment
claygriffiths
left a comment
There was a problem hiding this comment.
Quick question, it might be possible to simplify this.
Otherwise approved.
claygriffiths
changed the title
gw-cache-buster.php: Fixed GPMPN compatibility issue where custom starting page is not applied.gw-cache-buster.php: Fixed GP Multi-page Navigation compatibility issue where custom starting page is not applied.
claygriffiths
force-pushed
the
barth/fix/73591-gpmpn-custom-starting-page
branch
from
7dbb667 to
9fec98c
Compare
…ssue where custom starting pages are not applied.
claygriffiths
force-pushed
the
barth/fix/73591-gpmpn-custom-starting-page
branch
from
9fec98c to
052c9c0
Compare
claygriffiths
changed the title
gw-cache-buster.php: Fixed GP Multi-page Navigation compatibility issue where custom starting page is not applied.gw-cache-buster.php: Fixed GP Multi-Page Navigation compatibility issue where custom starting page is not applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2755652844/73591
Summary
When cache buster is enabled on a form, the
GPMPN, the custom starting page is not applied to the form. This fix here is to use thegpmpn_default_pagefilter hook to pass in the custom page param.