Skip to content

Commit b663979

Browse files
author
Marius Sturm
committed
use microseconds for request_duration, to be consistent with mod_log_config
1 parent 4da9aec commit b663979

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ What does the `GelfFields` string mean:
8181
| C | Connection status |
8282
| c | Extract Cookie |
8383
| D | Request duration |
84+
| | (in microseconds) |
8485
| f | Requested file |
8586
| H | Protocol |
8687
| h | Remote host |
@@ -121,9 +122,7 @@ Bundle module and configuration files to system package, e.g. for Ubuntu:
121122
Install dependent c libraries:
122123

123124
```
124-
$ sudo apt-get install apache2-dev
125-
$ sudo apt-get install libjson-c-dev
126-
$ sudo apt-get install zlib1g-dev
125+
$ sudo apt-get install apache2-dev libjson-c-dev zlib1g-dev
127126
```
128127

129128
Compile and install modules:

src/functions20.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ static const char *extract_request_time(request_rec *r, char *a)
8585
static const char *extract_request_duration(request_rec *r, char *a)
8686
{
8787
apr_time_t duration = apr_time_now() - r->request_time;
88-
return apr_psprintf(r->pool, "%.3lf", apr_time_usec(duration)/1000.0);
88+
return apr_psprintf(r->pool, "%ld", apr_time_usec(duration));
8989
}
9090

9191
static const char *extract_connection_status(request_rec *r, char *a) __attribute__((unused));

src/mod_log_gelf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ static int log_gelf_post_config(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *pte
389389
log_gelf_register_item(server,p,'B', extract_bytes_sent, NULL, "_bytes_send");
390390
log_gelf_register_item(server,p,'C', extract_connection_status, NULL, "_connection_status");
391391
log_gelf_register_item(server,p,'c', extract_specific_cookie, config->cookie, "_cookie");
392-
log_gelf_register_item(server,p,'D', extract_request_duration, NULL, "_request_duration_ms");
392+
log_gelf_register_item(server,p,'D', extract_request_duration, NULL, "_request_duration_us");
393393
log_gelf_register_item(server,p,'f', extract_request_file, NULL, "_request_file");
394394
log_gelf_register_item(server,p,'H', extract_request_protocol, NULL, "_request_protocol");
395395
log_gelf_register_item(server,p,'h', extract_remote_host, NULL, "_remote_host");

0 commit comments

Comments
 (0)