Fixes for issue #777

- Dynamically added width to link from dashboard replaying query

Author: DJCordhose

app/assets/javascripts/universalsearch.js

@@ -44,10 +44,10 @@ $(document).ready(function() {
         $("input[name='width']", $(this)).val(width);
     });
 
-    $(".stream-query-link").on("click", function() {
+    $(".added-width-search-link").on("click", function() {
         var width = $(document).width();
         var href = $(this).attr("href");
-        href += "&width=" + width;
+        href = URI(href).addSearch("width", width).toString();
         $(this).attr("href", href);
     });
 

app/controllers/SearchController.java

@@ -148,6 +148,7 @@ protected String formatHistogramResults(Map<String, Long> histogramResults, int
 
         int index = 0;
         for (Map.Entry<String, Long> result : histogramResults.entrySet()) {
+            // TODO: instead of sampling we might consider interpolation (compare DashboardsApiController)
             if (index % factor == 0) {
                 Map<String, Long> point = Maps.newHashMap();
                 point.put("x", Long.parseLong(result.getKey()));

app/controllers/api/DashboardsApiController.java

@@ -165,6 +165,7 @@ private Object filterValuesByResolution(final int resolution, final Object resul
                     final Map<Object, Object> filteredResults = new LinkedHashMap<>(resolution);
                     int index = 0;
                     for (Map.Entry entry : resultMap.entrySet()) {
+                        // TODO: instead of sampling we might consider interpolation (compare SearchController)
                         if (index % factor == 0) {
                             filteredResults.put(entry.getKey(), entry.getValue());
                         }

app/views/dashboards/show.scala.html

@@ -200,7 +200,7 @@ <h2>Widget config</h2>
                 <a class="btn" href="@routes.MetricsController.ofMasterNode("org.graylog2.dashboards.widgets.*." + widget.getId)">
                     Show widget metrics
                 </a>
-                <a class="btn btn-success" href="@DashboardWidgetRouteHelper.replayRoute(widget)">
+                <a class="btn btn-success added-width-search-link" href="@DashboardWidgetRouteHelper.replayRoute(widget)">
                     Replay search
                 </a>
                 <button class="btn btn-primary" data-dismiss="modal" aria-hidden="true">Close</button>

app/views/helpers/DashboardWidgetRouteHelper.java

@@ -33,7 +33,7 @@ protected static Call prepareNonStreamBoundReplayRoute(String query, TimeRange t
                 "",
                 "",
                 "", // TODO fields
-                -1 // TODO displayWidth
+                -1
         );
     }
 
@@ -52,7 +52,7 @@ protected static Call prepareStreamBoundReplayRoute(String streamId, String quer
                 "",
                 "",
                 "", // TODO fields
-                -1 // TODO displayWidth
+                -1
         );
     }
 }

app/views/streams/index.scala.html

@@ -41,7 +41,7 @@ <h1><i class="icon icon-barcode"></i> Streams</h1>
 
             <h3>
                 <i class="icon icon-ellipsis-vertical"></i>
-                <a class="stream-query-link" href="@routes.StreamSearchController.index(stream.getId, "*", "relative", 300)">
+                <a class="added-width-search-link" href="@routes.StreamSearchController.index(stream.getId, "*", "relative", 300)">
                     @stream.getTitle
                 </a>